From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B3AEC636CC for ; Wed, 15 Feb 2023 08:46:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=B2TqhTIp1matXNKkbMEnD2fhMfidVzJNKfQnsy1d0eM=; b=N8Q4LD+nIPN62x QznTX8dL3gKEtZqY8cklOIyP8loCL8ALuWEEkWbHdHd4uJIbvc+k4lVgadjy1+NVkvuj9q8poN9Nt XU345XDw6IteSqO7p2z1/ONamfYWkU/xlvnT4uJgjHd3/s5pdJOhtqP1IZpDXFmqc8cjIHKsBT1vw a/e3kUt6fDA3hhJMRU+XT09Y9rX6NgE+ErOZy7+tFOcykkv9H1BvgaqbcQsxtLzwyvPogSRXed2T3 TRtdsiyZUr7VsjZrE/1bQUMDcArBSm/rF+sn6K0ZA5G2oYG1ZyjEi3hk5r54ZuzINhBiLAnKzryxY zzmWHL/NwdYJjwZhsNtw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSDPO-005CwM-KS; Wed, 15 Feb 2023 08:44:58 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSDPK-005CvS-65 for linux-arm-kernel@lists.infradead.org; Wed, 15 Feb 2023 08:44:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1676450694; x=1707986694; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=z4DhdwaoH58e4ik39f3MRtwMkMTNMbsori+83AG0uWU=; b=MGYN0CSwe1ixWbZMfRqBwAJy9nbYpljjEe0df/v8PYeN4+CMyzVGpzCD WmSx1STMglL1k5EhnwqaC65l2FZE/Cm87IWebqpVhrJiKN05vhiqsbnES eO9eqUQdww7uiTW8qwO8Z0vYzTNu+QfQ5i65NW0uveNNLwFh3RGLhykV6 CIymSSnbU6m5Itvf0lp60xGFzW9/UAEzzDUZtZR1SHgMbHJfXGUE2hepT HY367SMcBuMTZYlLX41B10Q/oSg+0BRo5WRnsJFPvYoKXPiAQNMWL8Myi DKV8g9XuTk21GVEegCY9AvwMZcbdQU0LcbQHlC84oI158crGidNwKduJI Q==; X-IronPort-AV: E=Sophos;i="5.97,299,1669071600"; d="scan'208";a="29092997" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 15 Feb 2023 09:44:52 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Wed, 15 Feb 2023 09:44:52 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Wed, 15 Feb 2023 09:44:52 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1676450692; x=1707986692; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=z4DhdwaoH58e4ik39f3MRtwMkMTNMbsori+83AG0uWU=; b=nCYYzopyh/LuhaoL4m1l8AZSw5kjCYaTxnUBNu5kLOvJDIF0QxmtLQPE k5y48QlTcT078beU0d5OJljgs8oz9F1m//8EFG/CB576+Q2/n7qEJLvRh 5Ji404a9RiaE7RT6e/g9qXncDP3PViI8ibd9ZwPipQkUk6M3eBhsQasz/ MHsQntqbCyTLl5+ItYiq0M8oDogseNSPaAWOCkhNjnMuG2dSOANtkO5UN 2RrNHH1YO8qmjNXvwCxcW0b4I6yk9uD0p6KuaorAJkndUJwEj9p3FkVV/ Q49uoKXzzYinGewsgAJmRVzmhz3j+r+BQaQKWOmkUyd7tEc3qSnZEU0lQ A==; X-IronPort-AV: E=Sophos;i="5.97,299,1669071600"; d="scan'208";a="29092996" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 15 Feb 2023 09:44:51 +0100 Received: from steina-w.localnet (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 9FDDB280056; Wed, 15 Feb 2023 09:44:51 +0100 (CET) From: Alexander Stein To: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Liu Ying Cc: marex@denx.de, stefan@agner.ch, airlied@gmail.com, daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, krzysztof.kozlowski@linaro.org, LW@karo-electronics.de Subject: Re: [PATCH v3 1/6] dt-bindings: lcdif: Add i.MX93 LCDIF support Date: Wed, 15 Feb 2023 09:44:51 +0100 Message-ID: <2703596.mvXUDI8C0e@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <41bc30ac7af4b0ce3ff608b604fb6ea762428680.camel@nxp.com> References: <20230213085612.1026538-1-victor.liu@nxp.com> <2551514.Lt9SDvczpP@steina-w> <41bc30ac7af4b0ce3ff608b604fb6ea762428680.camel@nxp.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230215_004454_633523_E8F1B57F X-CRM114-Status: GOOD ( 28.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Liu, Am Mittwoch, 15. Februar 2023, 08:49:56 CET schrieb Liu Ying: > On Wed, 2023-02-15 at 08:26 +0100, Alexander Stein wrote: > > Hi Liu, > = > Hi Alexander, > = > > thanks for the update. > = > Thanks for the review. > = > > Am Montag, 13. Februar 2023, 09:56:07 CET schrieb Liu Ying: > > > There is one LCDIF embedded in i.MX93 SoC to connect with > > > MIPI DSI controller through LCDIF cross line pattern(controlled > > > by mediamix blk-ctrl) or connect with LVDS display bridge(LDB) > > > directly or connect with a parallel display through parallel > > > display format(also controlled by mediamix blk-ctrl). i.MX93 > > > LCDIF IP is essentially the same to i.MX8MP LCDIF IP. Add device > > > tree binding for i.MX93 LCDIF. > > > = > > > Acked-by: Krzysztof Kozlowski > > > Reviewed-by: Marek Vasut > > > Signed-off-by: Liu Ying > > > --- > > > v2->v3: > > > * No change. > > > = > > > v1->v2: > > > * Add Krzysztof's A-b and Marek's R-b tags on patch 1/6. > > > = > > > Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 7 > > > = > > > ++++++- > > > = > > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > = > > > diff --git > > > a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > > > b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml index > > > 75b4efd70ba8..fc11ab5fc465 100644 > > > --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > > > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > > > = > > > @@ -21,6 +21,7 @@ properties: > > > - fsl,imx28-lcdif > > > - fsl,imx6sx-lcdif > > > - fsl,imx8mp-lcdif > > > = > > > + - fsl,imx93-lcdif > > > = > > > - items: > > > - enum: > > > - fsl,imx6sl-lcdif > > > = > > > @@ -88,7 +89,9 @@ allOf: > > > properties: > > > compatible: > > > contains: > > > - const: fsl,imx8mp-lcdif > > > + enum: > > > + - fsl,imx8mp-lcdif > > > + - fsl,imx93-lcdif > > > = > > > then: > > > properties: > > > clocks: > > > @@ -107,6 +110,7 @@ allOf: > > > enum: > > > - fsl,imx6sx-lcdif > > > - fsl,imx8mp-lcdif > > > = > > > + - fsl,imx93-lcdif > > > = > > > then: > > > properties: > > > clocks: > > > @@ -123,6 +127,7 @@ allOf: > > > - fsl,imx8mm-lcdif > > > - fsl,imx8mn-lcdif > > > - fsl,imx8mp-lcdif > > > = > > > + - fsl,imx93-lcdif > > > = > > > then: > > > required: > > > - power-domains > > = > > I would have expected that fsl,imx93-lcdif supports up to 3 endpoints > > (MIPI > > DSI, LVDS, and parallel) in a 'ports' subnode. But this binding only > > supports > > a single 'port' sub-node. Also an example for this case might be very > > helpful. > = > The port node allows multiple endpoints(See graph.yaml[1]). It's > enough to use the existing port node instead of using ports node. Ah, I wasn't aware of that possibility for OF graph. Yep, agreed then it's = enough. > For i.MX93 LCDIF, the port node will be something like this: > --------------------8<-------------------------- > port { > #address-cells =3D <1>; > #size-cells =3D <0>; > = > lcdif_to_pdfc: endpoint@0 { > reg =3D <0>; > }; > = > lcdif_to_ldb: endpoint@1 { > reg =3D <1>; > }; > = > lcdif_to_cross_line_pattern: endpoint@2 { > reg =3D <2>; > }; > }; > --------------------8<-------------------------- > = > Looks like it's not necessary to add a specifc example for i.MX93 > LCDIF. Fine by me. Reviewed-by: Alexander Stein > [1] > https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/gr= aph > .yaml#L48 > = > Regards, > Liu Ying TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel