* [PATCH v2 1/5] riscv: dts: allwinner: Update opp table to allow CPU frequency scaling
2023-12-18 11:05 [PATCH v2 0/5] cpufreq support for the D1 Brandon Cheo Fusi
@ 2023-12-18 11:05 ` Brandon Cheo Fusi
2023-12-18 16:14 ` Samuel Holland
2023-12-18 11:05 ` [PATCH v2 2/5] dt-bindings: opp: sun50i: Add binding for D1 CPUs Brandon Cheo Fusi
` (3 subsequent siblings)
4 siblings, 1 reply; 14+ messages in thread
From: Brandon Cheo Fusi @ 2023-12-18 11:05 UTC (permalink / raw)
To: Yangtao Li, Viresh Kumar, Nishanth Menon, Stephen Boyd,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Rafael J . Wysocki, Maxime Ripard
Cc: linux-pm, devicetree, linux-arm-kernel, linux-sunxi, linux-kernel,
linux-riscv, Brandon Cheo Fusi
Two OPPs are currently defined for the D1/D1s; one at 408MHz and
another at 1.08GHz. Switching between these can be done with the
"sun50i-cpufreq-nvmem" driver. This patch populates the opp table
appropriately, inspired by
https://github.com/Tina-Linux/linux-5.4/blob/master/arch/riscv/boot/dts/sunxi/sun20iw1p1.dtsi
The supply voltages are PWM-controlled, but support for that IP
is still in the works. So stick to a target vdd-cpu supply of 0.9V,
which seems to be the default on most D1 boards.
Signed-off-by: Brandon Cheo Fusi <fusibrandon13@gmail.com>
---
arch/riscv/boot/dts/allwinner/sun20i-d1s.dtsi | 18 +++++++++++++++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/arch/riscv/boot/dts/allwinner/sun20i-d1s.dtsi b/arch/riscv/boot/dts/allwinner/sun20i-d1s.dtsi
index 64c3c2e6c..2f1771c19 100644
--- a/arch/riscv/boot/dts/allwinner/sun20i-d1s.dtsi
+++ b/arch/riscv/boot/dts/allwinner/sun20i-d1s.dtsi
@@ -39,16 +39,22 @@ cpu0_intc: interrupt-controller {
};
opp_table_cpu: opp-table-cpu {
- compatible = "operating-points-v2";
+ compatible = "allwinner,sun20i-d1-operating-points",
+ "allwinner,sun50i-h6-operating-points";
+ nvmem-cells = <&cpu_speed_grade>;
+ nvmem-cell-names = "speed";
+ opp-shared;
opp-408000000 {
+ clock-latency-ns = <244144>; /* 8 32k periods */
opp-hz = /bits/ 64 <408000000>;
- opp-microvolt = <900000 900000 1100000>;
+ opp-microvolt-speed0 = <900000 900000 1100000>;
};
opp-1080000000 {
+ clock-latency-ns = <244144>; /* 8 32k periods */
opp-hz = /bits/ 64 <1008000000>;
- opp-microvolt = <900000 900000 1100000>;
+ opp-microvolt-speed0 = <900000 900000 1100000>;
};
};
@@ -115,3 +121,9 @@ pmu {
<0x00000000 0x0000000f 0xffffffff 0xffffffff 0x00020000>;
};
};
+
+&sid {
+ cpu_speed_grade: cpu-speed-grade@0 {
+ reg = <0x00 0x2>;
+ };
+};
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v2 1/5] riscv: dts: allwinner: Update opp table to allow CPU frequency scaling
2023-12-18 11:05 ` [PATCH v2 1/5] riscv: dts: allwinner: Update opp table to allow CPU frequency scaling Brandon Cheo Fusi
@ 2023-12-18 16:14 ` Samuel Holland
0 siblings, 0 replies; 14+ messages in thread
From: Samuel Holland @ 2023-12-18 16:14 UTC (permalink / raw)
To: Brandon Cheo Fusi, Yangtao Li, Viresh Kumar, Nishanth Menon,
Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Chen-Yu Tsai, Jernej Skrabec, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Rafael J . Wysocki, Maxime Ripard
Cc: linux-pm, devicetree, linux-arm-kernel, linux-sunxi, linux-kernel,
linux-riscv
On 12/18/23 05:05, Brandon Cheo Fusi wrote:
> Two OPPs are currently defined for the D1/D1s; one at 408MHz and
> another at 1.08GHz. Switching between these can be done with the
> "sun50i-cpufreq-nvmem" driver. This patch populates the opp table
> appropriately, inspired by
> https://github.com/Tina-Linux/linux-5.4/blob/master/arch/riscv/boot/dts/sunxi/sun20iw1p1.dtsi
>
> The supply voltages are PWM-controlled, but support for that IP
> is still in the works. So stick to a target vdd-cpu supply of 0.9V,
> which seems to be the default on most D1 boards.
>
> Signed-off-by: Brandon Cheo Fusi <fusibrandon13@gmail.com>
> ---
> arch/riscv/boot/dts/allwinner/sun20i-d1s.dtsi | 18 +++++++++++++++---
> 1 file changed, 15 insertions(+), 3 deletions(-)
>
> diff --git a/arch/riscv/boot/dts/allwinner/sun20i-d1s.dtsi b/arch/riscv/boot/dts/allwinner/sun20i-d1s.dtsi
> index 64c3c2e6c..2f1771c19 100644
> --- a/arch/riscv/boot/dts/allwinner/sun20i-d1s.dtsi
> +++ b/arch/riscv/boot/dts/allwinner/sun20i-d1s.dtsi
> @@ -39,16 +39,22 @@ cpu0_intc: interrupt-controller {
> };
>
> opp_table_cpu: opp-table-cpu {
> - compatible = "operating-points-v2";
> + compatible = "allwinner,sun20i-d1-operating-points",
> + "allwinner,sun50i-h6-operating-points";
This is not correct. The compatible string specifies the algorithm for
looking up the speed grade from the NVMEM cell, and D1 uses a totally
different algorithm compared to H6:
https://github.com/Tina-Linux/linux-5.4/blob/master/drivers/cpufreq/sun50i-cpufreq-nvmem.c#L293-L338
So you cannot use a fallback compatible string here, and you need to add
driver support for the D1's speed bin encoding.
Regards,
Samuel
> + nvmem-cells = <&cpu_speed_grade>;
> + nvmem-cell-names = "speed";
> + opp-shared;
>
> opp-408000000 {
> + clock-latency-ns = <244144>; /* 8 32k periods */
> opp-hz = /bits/ 64 <408000000>;
> - opp-microvolt = <900000 900000 1100000>;
> + opp-microvolt-speed0 = <900000 900000 1100000>;
> };
>
> opp-1080000000 {
> + clock-latency-ns = <244144>; /* 8 32k periods */
> opp-hz = /bits/ 64 <1008000000>;
> - opp-microvolt = <900000 900000 1100000>;
> + opp-microvolt-speed0 = <900000 900000 1100000>;
> };
> };
>
> @@ -115,3 +121,9 @@ pmu {
> <0x00000000 0x0000000f 0xffffffff 0xffffffff 0x00020000>;
> };
> };
> +
> +&sid {
> + cpu_speed_grade: cpu-speed-grade@0 {
> + reg = <0x00 0x2>;
> + };
> +};
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 2/5] dt-bindings: opp: sun50i: Add binding for D1 CPUs
2023-12-18 11:05 [PATCH v2 0/5] cpufreq support for the D1 Brandon Cheo Fusi
2023-12-18 11:05 ` [PATCH v2 1/5] riscv: dts: allwinner: Update opp table to allow CPU frequency scaling Brandon Cheo Fusi
@ 2023-12-18 11:05 ` Brandon Cheo Fusi
2023-12-18 14:54 ` Conor Dooley
2023-12-18 11:05 ` [PATCH v2 3/5] cpufreq: sun50i: Add D1 support Brandon Cheo Fusi
` (2 subsequent siblings)
4 siblings, 1 reply; 14+ messages in thread
From: Brandon Cheo Fusi @ 2023-12-18 11:05 UTC (permalink / raw)
To: Yangtao Li, Viresh Kumar, Nishanth Menon, Stephen Boyd,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Rafael J . Wysocki, Maxime Ripard
Cc: linux-pm, devicetree, linux-arm-kernel, linux-sunxi, linux-kernel,
linux-riscv, Brandon Cheo Fusi
Add binding for D1 CPU OPPs.
Signed-off-by: Brandon Cheo Fusi <fusibrandon13@gmail.com>
---
.../bindings/opp/allwinner,sun50i-h6-operating-points.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml b/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml
index 51f62c3ae..fddaa3216 100644
--- a/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml
+++ b/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml
@@ -23,7 +23,9 @@ allOf:
properties:
compatible:
- const: allwinner,sun50i-h6-operating-points
+ enum:
+ - allwinner,sun50i-h6-operating-points
+ - allwinner,sun20i-d1-operating-points
nvmem-cells:
description: |
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v2 2/5] dt-bindings: opp: sun50i: Add binding for D1 CPUs
2023-12-18 11:05 ` [PATCH v2 2/5] dt-bindings: opp: sun50i: Add binding for D1 CPUs Brandon Cheo Fusi
@ 2023-12-18 14:54 ` Conor Dooley
2023-12-18 16:20 ` Conor Dooley
0 siblings, 1 reply; 14+ messages in thread
From: Conor Dooley @ 2023-12-18 14:54 UTC (permalink / raw)
To: Brandon Cheo Fusi
Cc: Yangtao Li, Viresh Kumar, Nishanth Menon, Stephen Boyd,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Rafael J . Wysocki, Maxime Ripard, linux-pm,
devicetree, linux-arm-kernel, linux-sunxi, linux-kernel,
linux-riscv
[-- Attachment #1.1: Type: text/plain, Size: 1053 bytes --]
On Mon, Dec 18, 2023 at 12:05:40PM +0100, Brandon Cheo Fusi wrote:
> Add binding for D1 CPU OPPs.
>
> Signed-off-by: Brandon Cheo Fusi <fusibrandon13@gmail.com>
> ---
> .../bindings/opp/allwinner,sun50i-h6-operating-points.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml b/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml
> index 51f62c3ae..fddaa3216 100644
> --- a/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml
> +++ b/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml
> @@ -23,7 +23,9 @@ allOf:
>
> properties:
> compatible:
> - const: allwinner,sun50i-h6-operating-points
> + enum:
> + - allwinner,sun50i-h6-operating-points
> + - allwinner,sun20i-d1-operating-points
This doesn't match what you have in your devicetree.
>
> nvmem-cells:
> description: |
> --
> 2.30.2
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/5] dt-bindings: opp: sun50i: Add binding for D1 CPUs
2023-12-18 14:54 ` Conor Dooley
@ 2023-12-18 16:20 ` Conor Dooley
0 siblings, 0 replies; 14+ messages in thread
From: Conor Dooley @ 2023-12-18 16:20 UTC (permalink / raw)
To: Brandon Cheo Fusi
Cc: Yangtao Li, Viresh Kumar, Nishanth Menon, Stephen Boyd,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Rafael J . Wysocki, Maxime Ripard, linux-pm,
devicetree, linux-arm-kernel, linux-sunxi, linux-kernel,
linux-riscv
[-- Attachment #1.1: Type: text/plain, Size: 1258 bytes --]
On Mon, Dec 18, 2023 at 02:54:35PM +0000, Conor Dooley wrote:
> On Mon, Dec 18, 2023 at 12:05:40PM +0100, Brandon Cheo Fusi wrote:
> > Add binding for D1 CPU OPPs.
> >
> > Signed-off-by: Brandon Cheo Fusi <fusibrandon13@gmail.com>
> > ---
> > .../bindings/opp/allwinner,sun50i-h6-operating-points.yaml | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml b/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml
> > index 51f62c3ae..fddaa3216 100644
> > --- a/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml
> > +++ b/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml
> > @@ -23,7 +23,9 @@ allOf:
> >
> > properties:
> > compatible:
> > - const: allwinner,sun50i-h6-operating-points
> > + enum:
> > + - allwinner,sun50i-h6-operating-points
> > + - allwinner,sun20i-d1-operating-points
>
> This doesn't match what you have in your devicetree.
Per Samuel's comments in
<aad8302d-a015-44ee-ad11-1a4c6e00074c@sholland.org>
it looks like this binding is correct but the devicetree is wrong.
Thanks,
Conor.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 3/5] cpufreq: sun50i: Add D1 support
2023-12-18 11:05 [PATCH v2 0/5] cpufreq support for the D1 Brandon Cheo Fusi
2023-12-18 11:05 ` [PATCH v2 1/5] riscv: dts: allwinner: Update opp table to allow CPU frequency scaling Brandon Cheo Fusi
2023-12-18 11:05 ` [PATCH v2 2/5] dt-bindings: opp: sun50i: Add binding for D1 CPUs Brandon Cheo Fusi
@ 2023-12-18 11:05 ` Brandon Cheo Fusi
2023-12-18 14:55 ` Conor Dooley
2023-12-18 11:05 ` [PATCH v2 4/5] cpufreq: dt-platdev: Blocklist allwinner,sun20i-d1 SoC Brandon Cheo Fusi
2023-12-18 11:05 ` [PATCH v2 5/5] cpufreq: Make sun50i h6 cpufreq Kconfig option arch generic Brandon Cheo Fusi
4 siblings, 1 reply; 14+ messages in thread
From: Brandon Cheo Fusi @ 2023-12-18 11:05 UTC (permalink / raw)
To: Yangtao Li, Viresh Kumar, Nishanth Menon, Stephen Boyd,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Rafael J . Wysocki, Maxime Ripard
Cc: linux-pm, devicetree, linux-arm-kernel, linux-sunxi, linux-kernel,
linux-riscv, Brandon Cheo Fusi
Add support for D1 based devices to the Allwinner H6 cpufreq
driver
Signed-off-by: Brandon Cheo Fusi <fusibrandon13@gmail.com>
---
drivers/cpufreq/sun50i-cpufreq-nvmem.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/cpufreq/sun50i-cpufreq-nvmem.c b/drivers/cpufreq/sun50i-cpufreq-nvmem.c
index 32a9c88f8..ccf83780f 100644
--- a/drivers/cpufreq/sun50i-cpufreq-nvmem.c
+++ b/drivers/cpufreq/sun50i-cpufreq-nvmem.c
@@ -160,6 +160,7 @@ static struct platform_driver sun50i_cpufreq_driver = {
static const struct of_device_id sun50i_cpufreq_match_list[] = {
{ .compatible = "allwinner,sun50i-h6" },
+ { .compatible = "allwinner,sun20i-d1" },
{}
};
MODULE_DEVICE_TABLE(of, sun50i_cpufreq_match_list);
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v2 3/5] cpufreq: sun50i: Add D1 support
2023-12-18 11:05 ` [PATCH v2 3/5] cpufreq: sun50i: Add D1 support Brandon Cheo Fusi
@ 2023-12-18 14:55 ` Conor Dooley
2023-12-18 15:53 ` Andre Przywara
0 siblings, 1 reply; 14+ messages in thread
From: Conor Dooley @ 2023-12-18 14:55 UTC (permalink / raw)
To: Brandon Cheo Fusi
Cc: Yangtao Li, Viresh Kumar, Nishanth Menon, Stephen Boyd,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Rafael J . Wysocki, Maxime Ripard, linux-pm,
devicetree, linux-arm-kernel, linux-sunxi, linux-kernel,
linux-riscv
[-- Attachment #1.1: Type: text/plain, Size: 900 bytes --]
On Mon, Dec 18, 2023 at 12:05:41PM +0100, Brandon Cheo Fusi wrote:
> Add support for D1 based devices to the Allwinner H6 cpufreq
> driver
>
> Signed-off-by: Brandon Cheo Fusi <fusibrandon13@gmail.com>
> ---
> drivers/cpufreq/sun50i-cpufreq-nvmem.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/sun50i-cpufreq-nvmem.c b/drivers/cpufreq/sun50i-cpufreq-nvmem.c
> index 32a9c88f8..ccf83780f 100644
> --- a/drivers/cpufreq/sun50i-cpufreq-nvmem.c
> +++ b/drivers/cpufreq/sun50i-cpufreq-nvmem.c
> @@ -160,6 +160,7 @@ static struct platform_driver sun50i_cpufreq_driver = {
>
> static const struct of_device_id sun50i_cpufreq_match_list[] = {
> { .compatible = "allwinner,sun50i-h6" },
> + { .compatible = "allwinner,sun20i-d1" },
I thought the feedback in v2 was to drop this change, since the
devicetree has the sun50i-h6 as a fallback compatible?
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH v2 3/5] cpufreq: sun50i: Add D1 support
2023-12-18 14:55 ` Conor Dooley
@ 2023-12-18 15:53 ` Andre Przywara
2023-12-18 16:15 ` Jernej Škrabec
2023-12-18 16:19 ` Conor Dooley
0 siblings, 2 replies; 14+ messages in thread
From: Andre Przywara @ 2023-12-18 15:53 UTC (permalink / raw)
To: Conor Dooley
Cc: Brandon Cheo Fusi, Yangtao Li, Viresh Kumar, Nishanth Menon,
Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, Paul Walmsley,
Palmer Dabbelt, Albert Ou, Rafael J . Wysocki, Maxime Ripard,
linux-pm, devicetree, linux-arm-kernel, linux-sunxi, linux-kernel,
linux-riscv
On Mon, 18 Dec 2023 14:55:30 +0000
Conor Dooley <conor@kernel.org> wrote:
Hi,
> On Mon, Dec 18, 2023 at 12:05:41PM +0100, Brandon Cheo Fusi wrote:
> > Add support for D1 based devices to the Allwinner H6 cpufreq
> > driver
> >
> > Signed-off-by: Brandon Cheo Fusi <fusibrandon13@gmail.com>
> > ---
> > drivers/cpufreq/sun50i-cpufreq-nvmem.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/cpufreq/sun50i-cpufreq-nvmem.c b/drivers/cpufreq/sun50i-cpufreq-nvmem.c
> > index 32a9c88f8..ccf83780f 100644
> > --- a/drivers/cpufreq/sun50i-cpufreq-nvmem.c
> > +++ b/drivers/cpufreq/sun50i-cpufreq-nvmem.c
> > @@ -160,6 +160,7 @@ static struct platform_driver sun50i_cpufreq_driver = {
> >
> > static const struct of_device_id sun50i_cpufreq_match_list[] = {
> > { .compatible = "allwinner,sun50i-h6" },
> > + { .compatible = "allwinner,sun20i-d1" },
>
> I thought the feedback in v2 was to drop this change, since the
> devicetree has the sun50i-h6 as a fallback compatible?
Well, this is the *board* (fallback) compatible string, so we cannot assign
it as we like. The whole (existing) scheme is admittedly somewhat weird,
because we not only match on a particular device compatible
(like allwinner,sun20i-d1-operating-points), but also need to blocklist and
re-match some parts against the *board compatible*, owing to the
cpufreq-dt driver. The board name is basically used as a placeholder to
find out the SoC, because there is (or was?) no other good way - the
CPU DT nodes don't work for this. Back when this was introduced, this was
the "least worst" solution.
I don't remember all the details, and didn't find time yet to look into
this in more detail, but fixing this is non-trivial. If this isn't 6.8
material, I might have a look at this later this week/month.
Cheers,
Andre
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH v2 3/5] cpufreq: sun50i: Add D1 support
2023-12-18 15:53 ` Andre Przywara
@ 2023-12-18 16:15 ` Jernej Škrabec
2023-12-18 16:19 ` Conor Dooley
1 sibling, 0 replies; 14+ messages in thread
From: Jernej Škrabec @ 2023-12-18 16:15 UTC (permalink / raw)
To: Conor Dooley, Andre Przywara
Cc: Brandon Cheo Fusi, Yangtao Li, Viresh Kumar, Nishanth Menon,
Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Chen-Yu Tsai, Samuel Holland, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Rafael J . Wysocki, Maxime Ripard, linux-pm,
devicetree, linux-arm-kernel, linux-sunxi, linux-kernel,
linux-riscv
Dne ponedeljek, 18. december 2023 ob 16:53:45 CET je Andre Przywara napisal(a):
> On Mon, 18 Dec 2023 14:55:30 +0000
> Conor Dooley <conor@kernel.org> wrote:
>
> Hi,
>
> > On Mon, Dec 18, 2023 at 12:05:41PM +0100, Brandon Cheo Fusi wrote:
> > > Add support for D1 based devices to the Allwinner H6 cpufreq
> > > driver
> > >
> > > Signed-off-by: Brandon Cheo Fusi <fusibrandon13@gmail.com>
> > > ---
> > > drivers/cpufreq/sun50i-cpufreq-nvmem.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/cpufreq/sun50i-cpufreq-nvmem.c b/drivers/cpufreq/sun50i-cpufreq-nvmem.c
> > > index 32a9c88f8..ccf83780f 100644
> > > --- a/drivers/cpufreq/sun50i-cpufreq-nvmem.c
> > > +++ b/drivers/cpufreq/sun50i-cpufreq-nvmem.c
> > > @@ -160,6 +160,7 @@ static struct platform_driver sun50i_cpufreq_driver = {
> > >
> > > static const struct of_device_id sun50i_cpufreq_match_list[] = {
> > > { .compatible = "allwinner,sun50i-h6" },
> > > + { .compatible = "allwinner,sun20i-d1" },
> >
> > I thought the feedback in v2 was to drop this change, since the
> > devicetree has the sun50i-h6 as a fallback compatible?
>
> Well, this is the *board* (fallback) compatible string, so we cannot assign
> it as we like. The whole (existing) scheme is admittedly somewhat weird,
> because we not only match on a particular device compatible
> (like allwinner,sun20i-d1-operating-points), but also need to blocklist and
> re-match some parts against the *board compatible*, owing to the
> cpufreq-dt driver. The board name is basically used as a placeholder to
> find out the SoC, because there is (or was?) no other good way - the
> CPU DT nodes don't work for this. Back when this was introduced, this was
> the "least worst" solution.
>
> I don't remember all the details, and didn't find time yet to look into
> this in more detail, but fixing this is non-trivial. If this isn't 6.8
> material, I might have a look at this later this week/month.
I would say it's 6.9 material. -rc6 already passed and it's not yet aligned
with all maintainers.
Best regards,
Jernej
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH v2 3/5] cpufreq: sun50i: Add D1 support
2023-12-18 15:53 ` Andre Przywara
2023-12-18 16:15 ` Jernej Škrabec
@ 2023-12-18 16:19 ` Conor Dooley
1 sibling, 0 replies; 14+ messages in thread
From: Conor Dooley @ 2023-12-18 16:19 UTC (permalink / raw)
To: Andre Przywara
Cc: Brandon Cheo Fusi, Yangtao Li, Viresh Kumar, Nishanth Menon,
Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, Paul Walmsley,
Palmer Dabbelt, Albert Ou, Rafael J . Wysocki, Maxime Ripard,
linux-pm, devicetree, linux-arm-kernel, linux-sunxi, linux-kernel,
linux-riscv
[-- Attachment #1.1: Type: text/plain, Size: 1377 bytes --]
On Mon, Dec 18, 2023 at 03:53:45PM +0000, Andre Przywara wrote:
> On Mon, 18 Dec 2023 14:55:30 +0000
> Conor Dooley <conor@kernel.org> wrote:
>
> Hi,
>
> > On Mon, Dec 18, 2023 at 12:05:41PM +0100, Brandon Cheo Fusi wrote:
> > > Add support for D1 based devices to the Allwinner H6 cpufreq
> > > driver
> > >
> > > Signed-off-by: Brandon Cheo Fusi <fusibrandon13@gmail.com>
> > > ---
> > > drivers/cpufreq/sun50i-cpufreq-nvmem.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/cpufreq/sun50i-cpufreq-nvmem.c b/drivers/cpufreq/sun50i-cpufreq-nvmem.c
> > > index 32a9c88f8..ccf83780f 100644
> > > --- a/drivers/cpufreq/sun50i-cpufreq-nvmem.c
> > > +++ b/drivers/cpufreq/sun50i-cpufreq-nvmem.c
> > > @@ -160,6 +160,7 @@ static struct platform_driver sun50i_cpufreq_driver = {
> > >
> > > static const struct of_device_id sun50i_cpufreq_match_list[] = {
> > > { .compatible = "allwinner,sun50i-h6" },
> > > + { .compatible = "allwinner,sun20i-d1" },
> >
> > I thought the feedback in v2 was to drop this change, since the
> > devicetree has the sun50i-h6 as a fallback compatible?
>
> Well, this is the *board* (fallback) compatible string, so we cannot assign
Oh of course... That's both me and Jernej that tripped up on this.
Brandon, please ignore the comment from me on this patch.
Thanks,
Conor.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 4/5] cpufreq: dt-platdev: Blocklist allwinner,sun20i-d1 SoC
2023-12-18 11:05 [PATCH v2 0/5] cpufreq support for the D1 Brandon Cheo Fusi
` (2 preceding siblings ...)
2023-12-18 11:05 ` [PATCH v2 3/5] cpufreq: sun50i: Add D1 support Brandon Cheo Fusi
@ 2023-12-18 11:05 ` Brandon Cheo Fusi
2023-12-18 11:05 ` [PATCH v2 5/5] cpufreq: Make sun50i h6 cpufreq Kconfig option arch generic Brandon Cheo Fusi
4 siblings, 0 replies; 14+ messages in thread
From: Brandon Cheo Fusi @ 2023-12-18 11:05 UTC (permalink / raw)
To: Yangtao Li, Viresh Kumar, Nishanth Menon, Stephen Boyd,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Rafael J . Wysocki, Maxime Ripard
Cc: linux-pm, devicetree, linux-arm-kernel, linux-sunxi, linux-kernel,
linux-riscv, Brandon Cheo Fusi
The Allwinner D1 uses H6 cpufreq driver. Add it to blocklist
so the "cpufreq-dt" device is not created twice.
Signed-off-by: Brandon Cheo Fusi <fusibrandon13@gmail.com>
---
drivers/cpufreq/cpufreq-dt-platdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
index bd1e1357c..2febcfc2c 100644
--- a/drivers/cpufreq/cpufreq-dt-platdev.c
+++ b/drivers/cpufreq/cpufreq-dt-platdev.c
@@ -104,6 +104,7 @@ static const struct of_device_id allowlist[] __initconst = {
*/
static const struct of_device_id blocklist[] __initconst = {
{ .compatible = "allwinner,sun50i-h6", },
+ { .compatible = "allwinner,sun20i-d1", },
{ .compatible = "apple,arm-platform", },
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v2 5/5] cpufreq: Make sun50i h6 cpufreq Kconfig option arch generic
2023-12-18 11:05 [PATCH v2 0/5] cpufreq support for the D1 Brandon Cheo Fusi
` (3 preceding siblings ...)
2023-12-18 11:05 ` [PATCH v2 4/5] cpufreq: dt-platdev: Blocklist allwinner,sun20i-d1 SoC Brandon Cheo Fusi
@ 2023-12-18 11:05 ` Brandon Cheo Fusi
2023-12-18 16:16 ` Jernej Škrabec
4 siblings, 1 reply; 14+ messages in thread
From: Brandon Cheo Fusi @ 2023-12-18 11:05 UTC (permalink / raw)
To: Yangtao Li, Viresh Kumar, Nishanth Menon, Stephen Boyd,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Rafael J . Wysocki, Maxime Ripard
Cc: linux-pm, devicetree, linux-arm-kernel, linux-sunxi, linux-kernel,
linux-riscv, Brandon Cheo Fusi
Move the Allwinner SUN50I cpufreq driver from Kconfig.arm to the
main Kconfig file so it supports other architectures, like RISC-V
in our case, and drop the 'ARM_' prefix.
Signed-off-by: Brandon Cheo Fusi <fusibrandon13@gmail.com>
---
drivers/cpufreq/Kconfig | 12 ++++++++++++
drivers/cpufreq/Kconfig.arm | 12 ------------
drivers/cpufreq/Makefile | 2 +-
3 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
index 35efb53d5..50aa66cfc 100644
--- a/drivers/cpufreq/Kconfig
+++ b/drivers/cpufreq/Kconfig
@@ -301,5 +301,17 @@ config QORIQ_CPUFREQ
This adds the CPUFreq driver support for Freescale QorIQ SoCs
which are capable of changing the CPU's frequency dynamically.
+config ALLWINNER_SUN50I_CPUFREQ_NVMEM
+ tristate "Allwinner nvmem based SUN50I CPUFreq driver"
+ depends on ARCH_SUNXI
+ depends on NVMEM_SUNXI_SID
+ select PM_OPP
+ help
+ This adds the nvmem based CPUFreq driver for Allwinner
+ h6/D1 SoCs.
+
+ To compile this driver as a module, choose M here: the
+ module will be called sun50i-cpufreq-nvmem.
+
endif
endmenu
diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
index f91160689..98b8e6eef 100644
--- a/drivers/cpufreq/Kconfig.arm
+++ b/drivers/cpufreq/Kconfig.arm
@@ -29,18 +29,6 @@ config ACPI_CPPC_CPUFREQ_FIE
If in doubt, say N.
-config ARM_ALLWINNER_SUN50I_CPUFREQ_NVMEM
- tristate "Allwinner nvmem based SUN50I CPUFreq driver"
- depends on ARCH_SUNXI
- depends on NVMEM_SUNXI_SID
- select PM_OPP
- help
- This adds the nvmem based CPUFreq driver for Allwinner
- h6 SoC.
-
- To compile this driver as a module, choose M here: the
- module will be called sun50i-cpufreq-nvmem.
-
config ARM_APPLE_SOC_CPUFREQ
tristate "Apple Silicon SoC CPUFreq support"
depends on ARCH_APPLE || (COMPILE_TEST && 64BIT)
diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
index 8d141c71b..110b676d2 100644
--- a/drivers/cpufreq/Makefile
+++ b/drivers/cpufreq/Makefile
@@ -78,7 +78,7 @@ obj-$(CONFIG_ARM_SCMI_CPUFREQ) += scmi-cpufreq.o
obj-$(CONFIG_ARM_SCPI_CPUFREQ) += scpi-cpufreq.o
obj-$(CONFIG_ARM_SPEAR_CPUFREQ) += spear-cpufreq.o
obj-$(CONFIG_ARM_STI_CPUFREQ) += sti-cpufreq.o
-obj-$(CONFIG_ARM_ALLWINNER_SUN50I_CPUFREQ_NVMEM) += sun50i-cpufreq-nvmem.o
+obj-$(CONFIG_ALLWINNER_SUN50I_CPUFREQ_NVMEM) += sun50i-cpufreq-nvmem.o
obj-$(CONFIG_ARM_TEGRA20_CPUFREQ) += tegra20-cpufreq.o
obj-$(CONFIG_ARM_TEGRA124_CPUFREQ) += tegra124-cpufreq.o
obj-$(CONFIG_ARM_TEGRA186_CPUFREQ) += tegra186-cpufreq.o
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v2 5/5] cpufreq: Make sun50i h6 cpufreq Kconfig option arch generic
2023-12-18 11:05 ` [PATCH v2 5/5] cpufreq: Make sun50i h6 cpufreq Kconfig option arch generic Brandon Cheo Fusi
@ 2023-12-18 16:16 ` Jernej Škrabec
0 siblings, 0 replies; 14+ messages in thread
From: Jernej Škrabec @ 2023-12-18 16:16 UTC (permalink / raw)
To: Yangtao Li, Viresh Kumar, Nishanth Menon, Stephen Boyd,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai,
Samuel Holland, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Rafael J . Wysocki, Maxime Ripard, Brandon Cheo Fusi
Cc: linux-pm, devicetree, linux-arm-kernel, linux-sunxi, linux-kernel,
linux-riscv, Brandon Cheo Fusi
Dne ponedeljek, 18. december 2023 ob 12:05:43 CET je Brandon Cheo Fusi napisal(a):
> Move the Allwinner SUN50I cpufreq driver from Kconfig.arm to the
> main Kconfig file so it supports other architectures, like RISC-V
> in our case, and drop the 'ARM_' prefix.
>
> Signed-off-by: Brandon Cheo Fusi <fusibrandon13@gmail.com>
> ---
> drivers/cpufreq/Kconfig | 12 ++++++++++++
> drivers/cpufreq/Kconfig.arm | 12 ------------
> drivers/cpufreq/Makefile | 2 +-
> 3 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
> index 35efb53d5..50aa66cfc 100644
> --- a/drivers/cpufreq/Kconfig
> +++ b/drivers/cpufreq/Kconfig
> @@ -301,5 +301,17 @@ config QORIQ_CPUFREQ
> This adds the CPUFreq driver support for Freescale QorIQ SoCs
> which are capable of changing the CPU's frequency dynamically.
>
> +config ALLWINNER_SUN50I_CPUFREQ_NVMEM
> + tristate "Allwinner nvmem based SUN50I CPUFreq driver"
> + depends on ARCH_SUNXI
> + depends on NVMEM_SUNXI_SID
> + select PM_OPP
> + help
> + This adds the nvmem based CPUFreq driver for Allwinner
> + h6/D1 SoCs.
> +
> + To compile this driver as a module, choose M here: the
> + module will be called sun50i-cpufreq-nvmem.
> +
> endif
> endmenu
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index f91160689..98b8e6eef 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -29,18 +29,6 @@ config ACPI_CPPC_CPUFREQ_FIE
>
> If in doubt, say N.
>
> -config ARM_ALLWINNER_SUN50I_CPUFREQ_NVMEM
> - tristate "Allwinner nvmem based SUN50I CPUFreq driver"
> - depends on ARCH_SUNXI
> - depends on NVMEM_SUNXI_SID
> - select PM_OPP
> - help
> - This adds the nvmem based CPUFreq driver for Allwinner
> - h6 SoC.
> -
> - To compile this driver as a module, choose M here: the
> - module will be called sun50i-cpufreq-nvmem.
> -
> config ARM_APPLE_SOC_CPUFREQ
> tristate "Apple Silicon SoC CPUFreq support"
> depends on ARCH_APPLE || (COMPILE_TEST && 64BIT)
> diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
> index 8d141c71b..110b676d2 100644
> --- a/drivers/cpufreq/Makefile
> +++ b/drivers/cpufreq/Makefile
> @@ -78,7 +78,7 @@ obj-$(CONFIG_ARM_SCMI_CPUFREQ) += scmi-cpufreq.o
> obj-$(CONFIG_ARM_SCPI_CPUFREQ) += scpi-cpufreq.o
> obj-$(CONFIG_ARM_SPEAR_CPUFREQ) += spear-cpufreq.o
> obj-$(CONFIG_ARM_STI_CPUFREQ) += sti-cpufreq.o
> -obj-$(CONFIG_ARM_ALLWINNER_SUN50I_CPUFREQ_NVMEM) += sun50i-cpufreq-nvmem.o
> +obj-$(CONFIG_ALLWINNER_SUN50I_CPUFREQ_NVMEM) += sun50i-cpufreq-nvmem.o
This should be moved, so it's sorted alphabetically.
Best regards,
Jernej
> obj-$(CONFIG_ARM_TEGRA20_CPUFREQ) += tegra20-cpufreq.o
> obj-$(CONFIG_ARM_TEGRA124_CPUFREQ) += tegra124-cpufreq.o
> obj-$(CONFIG_ARM_TEGRA186_CPUFREQ) += tegra186-cpufreq.o
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread