From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B53FC4167B for ; Mon, 11 Dec 2023 07:42:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yJBdxISQ7dI8939f0uXaYQf7HlqmunMp0y1LsKM8ECs=; b=NAmxaQg5Drz9BO yLXZSDnou4LEnc8tWp8EepmdPwtlWGhBxiTTibCjDGCfrs+hD45umb2ixlQPj3Sru+0vF5Riiv23U t4bcy/CBCyxB89a6b6L7F2wsyKqg31XeBIxcjzyKeptvgJ+H0XtSu53tbN+HYxu5RSNSkncoM2W0+ nsCvj35WSfGpgmOk5finYQPoJ9E72FRNiVOE0GG5ohwhlk1nH0j88wJo9qDOpmfshSD9osmZWG1QU FBqmoLTrSu0dZUlC9aVTn56Vvqcc3dpD+AST4kECOkmLjZYroeaKT9WcSNyapEvrzHiRHm3L03SkA IC2uDSUs/pEv54ceOj1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rCavd-004Gge-08; Mon, 11 Dec 2023 07:42:13 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rCavY-004GfT-1X for linux-arm-kernel@lists.infradead.org; Mon, 11 Dec 2023 07:42:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1702280528; x=1733816528; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=6h8wfbt0NTPohBnMnp15S8AIcYYqBr7uhMcKH2yr4QM=; b=AnhoTyLEE/zh8yUE/0c7CIyTKVrKEd2nK/FCFM7swBlgCAP/tTG8np7V 6c0bce8ATrwZFI7HSsy3uonq0Q9Kqyg2STO1ML7XS0FrM9EEPt42YPWb3 wJ/95WLDuCNLwgi12i+tXEmW0Gtt8YKoxc0K8syd3KEjp5xck1EVzmBtd z3dU+hSGTn9zdyjw+RjfXjpaILHksCZPXOuRzF4rW053f7EdAjclpKTu4 IF539+rPdA+r0UovVa5eLWhlxKl1RS1ThtDosqST1Pzh7MHKG5QKg1ejh e6GeL2toeeiN/Eyq9Pd/ebZ4Ibb0OoOpFuSkuq/O4vqOsBAkqoQMsEoR9 Q==; X-IronPort-AV: E=Sophos;i="6.04,267,1695679200"; d="scan'208";a="34423571" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 11 Dec 2023 08:42:00 +0100 Received: from steina-w.localnet (steina-w.tq-net.de [10.123.53.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 75929280075; Mon, 11 Dec 2023 08:42:00 +0100 (CET) From: Alexander Stein To: shawnguo@kernel.org, Fabio Estevam Cc: linux-arm-kernel@lists.infradead.org, tharvey@gateworks.com, marcel.ziswiler@toradex.com, Fabio Estevam Subject: Re: [PATCH 3/3] arm64: dts: imx8mp-tqma8mpql-mba8mpxl: Fix USB connector description Date: Mon, 11 Dec 2023 08:42:01 +0100 Message-ID: <2710885.mvXUDI8C0e@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20231207185543.2699697-3-festevam@gmail.com> References: <20231207185543.2699697-1-festevam@gmail.com> <20231207185543.2699697-3-festevam@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231210_234209_097946_2479C19F X-CRM114-Status: GOOD ( 15.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Fabio, Am Donnerstag, 7. Dezember 2023, 19:55:43 CET schrieb Fabio Estevam: > From: Fabio Estevam > = > The USB connector should not be placed under the dwc3 node. > = > Move the USB connector out of the SoC level and use port to describe > the connection to the dwc3 controller. > = > This fixes the following dt-schema warning: > = > imx8mp-tqma8mpql-mba8mpxl.dtb: usb@38100000: Unevaluated properties are n= ot > allowed ('connector' was unexpected) from schema $id: > http://devicetree.org/schemas/usb/snps,dwc3.yaml# > = > Signed-off-by: Fabio Estevam Reviewed-by: Alexander Stein Tested-by: Alexander Stein Thanks Alexander > --- > .../freescale/imx8mp-tqma8mpql-mba8mpxl.dts | 26 ++++++++++++++----- > 1 file changed, 19 insertions(+), 7 deletions(-) > = > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts > b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts index > 4b161564a284..505b70cb2bd7 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts > @@ -55,6 +55,21 @@ clk_xtal25: clk-xtal25 { > clock-frequency =3D <25000000>; > }; > = > + connector { > + compatible =3D "gpio-usb-b-connector", "usb-b-connector"; > + type =3D "micro"; > + label =3D "X29"; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&pinctrl_usbcon0>; > + id-gpios =3D <&gpio1 10 GPIO_ACTIVE_HIGH>; > + > + port { > + usb_dr_connector: endpoint { > + remote-endpoint =3D <&usb3_dwc>; > + }; > + }; > + }; > + > fan0: pwm-fan { > compatible =3D "pwm-fan"; > pinctrl-names =3D "default"; > @@ -625,13 +640,10 @@ &usb_dwc3_0 { > role-switch-default-mode =3D "peripheral"; > status =3D "okay"; > = > - connector { > - compatible =3D "gpio-usb-b-connector", "usb-b-connector"; > - type =3D "micro"; > - label =3D "X29"; > - pinctrl-names =3D "default"; > - pinctrl-0 =3D <&pinctrl_usbcon0>; > - id-gpios =3D <&gpio1 10 GPIO_ACTIVE_HIGH>; > + port { > + usb3_dwc: endpoint { > + remote-endpoint =3D <&usb_dr_connector>; > + }; > }; > }; -- = TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel