From: t.figa@samsung.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 6/6] ARM: EXYNOS: Add secure firmware support to secondary CPU bring-up
Date: Mon, 12 Nov 2012 11:11:20 +0100 [thread overview]
Message-ID: <2714070.uUa63CRanW@amdc1227> (raw)
In-Reply-To: <20121112095231.GE28327@n2100.arm.linux.org.uk>
On Monday 12 of November 2012 09:52:31 Russell King - ARM Linux wrote:
> On Thu, Oct 25, 2012 at 05:22:40PM +0200, Tomasz Figa wrote:
> > @@ -47,6 +48,8 @@ static inline void __iomem *cpu_boot_reg(int cpu)
> >
> > {
> >
> > void __iomem *boot_reg;
> >
> > + if (!call_firmware_op(cpu_boot_reg, cpu, &boot_reg))
> > + return boot_reg;
> >
> > boot_reg = cpu_boot_reg_base();
>
> That code makes no sense.
Why?
call_firmware_op returning 0 means a success, so boot_reg is filled with
proper boot register address, which should be used.
Otherwise (call_firmware_op returning an error) the legacy boot register
is used.
Best regards,
--
Tomasz Figa
Samsung Poland R&D Center
SW Solution Development, Linux Platform
next prev parent reply other threads:[~2012-11-12 10:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 15:22 [PATCH v3 0/6] ARM: EXYNOS: Add secure firmware support Tomasz Figa
2012-10-25 15:22 ` [PATCH v3 1/6] ARM: Add interface for registering and calling firmware-specific operations Tomasz Figa
2012-10-25 15:22 ` [PATCH v3 2/6] ARM: EXYNOS: Add support for secure monitor calls Tomasz Figa
2012-10-25 15:22 ` [PATCH v3 3/6] ARM: EXYNOS: Add IO mapping for non-secure SYSRAM Tomasz Figa
2012-10-25 15:22 ` [PATCH v3 4/6] ARM: EXYNOS: Add support for Exynos secure firmware Tomasz Figa
2012-11-12 9:51 ` Russell King - ARM Linux
2012-11-12 10:09 ` Tomasz Figa
2012-12-26 8:30 ` Barry Song
2012-10-25 15:22 ` [PATCH v3 5/6] ARM: EXYNOS: Add support for secondary CPU bring-up on Exynos4412 Tomasz Figa
2012-10-25 15:22 ` [PATCH v3 6/6] ARM: EXYNOS: Add secure firmware support to secondary CPU bring-up Tomasz Figa
2012-11-12 9:52 ` Russell King - ARM Linux
2012-11-12 10:11 ` Tomasz Figa [this message]
2012-11-12 7:39 ` [PATCH v3 0/6] ARM: EXYNOS: Add secure firmware support Kukjin Kim
2012-11-12 9:55 ` Russell King - ARM Linux
2012-11-12 10:14 ` Tomasz Figa
2012-11-22 6:52 ` Kukjin Kim
2012-11-22 9:33 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2714070.uUa63CRanW@amdc1227 \
--to=t.figa@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).