From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53903C48292 for ; Mon, 5 Feb 2024 17:45:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gepeKTwJ7KnpV2IgUPfoC+cP6oMB9VoF7aRMCIjkVOs=; b=qfUs78jF6TRtlA /TAkTOr467bJRre74xfFERfANgp9vUmonqBU2EcezOlJrPsHXPVxhaWNdwlOIY2fxmP/tjWqQw5Sj E6eXKQ2JC1zmJQ8xZIO9qofF3NSActL9sQNB159V2Jx0p5Hgnr3if6XOWxf454g9EBjk5b9vD/Lbl mGq2lk2zfDb3GZVf+LQ61UE4NTr3KBd0FItdrYqzk6f2CAQTrXxFq1R+df3LYncHOSTJV/pFnXtUF bKHbUm+GUUCflcpy2k+vM9sm5LtQrAqIDPzvhiZzrajSxtaa/putku/sXKdF1wpt7A+eR87EbRq56 bfqBN/H77Af6WY80Jibw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rX32H-00000004EDx-1ZrN; Mon, 05 Feb 2024 17:45:37 +0000 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rX32E-00000004EBM-2Sxa for linux-arm-kernel@lists.infradead.org; Mon, 05 Feb 2024 17:45:35 +0000 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-40fc6343bd2so29667595e9.1 for ; Mon, 05 Feb 2024 09:45:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707155130; x=1707759930; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=m0wzRpVZw3TnGWQm+s3AU8BkpazXaoqZkM6kOW1G/WQ=; b=Tg3jZhjVCJtxk0FTFKyaMfT2tjjMEhC6RQ1f2KjnTdlGWxY2QBy4449IrnujRFWpVV /uFk5otUKly0jkd1l1iT1zRmmulSj3UZ/XODIdCCm53NPDV4P62NOJPRWYYgvpyGgBMX A+fZvZ310QBv4vUA4CoFVhSK61vxTi3gR6nFXQ7gWl/EEublxcwXysslBVhVFWd9drCC tY3dQR8K7xoLX5AM1cZn+YIFEgw9z5JpQO7cbUUS+Jyp5VWC7TeyPV8Ss8fblLuwUwsM KmAX7RppjO/fwC0zLmPUQmWA8Wfk+zmnmKiMTM8AbEBEL+X1TnYP8yZCH30ym8m3pFXM cgsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707155130; x=1707759930; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m0wzRpVZw3TnGWQm+s3AU8BkpazXaoqZkM6kOW1G/WQ=; b=bKw9zk5j5Us30F3YkZC0mgn8LY61OuctQYqHkarqv1zeq4P5cyv7ph90Ptbvh7Mbg/ PKdLdpDqDs/SsUflKJXj8cVR26ErSA62IpuSy4QEBDqE4GHJrPd4kAylXFqTEyb2u1mb q3CcD12YTxk7CeJV0LmPWv/FckqaNdRoxs2QExWRNl41XlTR4QkEeTHWAosmZrSQ/jqu lfn5YNajom2ss40YoqnkffAoFK+DvbD2yqRY0CFdqgMSTAVjH7guSkiLAxay8IWM+ODO RJOiIleofHNCW9rurTaLhiEm+UlR172weY3VxC93RvRitWzfSKC+7RrOZMxtIlTSi6TP xICA== X-Gm-Message-State: AOJu0Yzj4NS/NohfcLDmvUsbquJxiKdkNN0W6STnHY2Xj3lGBU2/e2Dj 3+ouuHqWrt+6eNDraydQb7cNJsuax4z/NEJbZbjtALHQfyvkEpAs X-Google-Smtp-Source: AGHT+IHDzn+x37VJ4FfaK12jdyWyrj6HN0Ue2YwTRPprISDD+A1uWFfuwbmrJ9tOHYqi9adBbIFrKQ== X-Received: by 2002:a05:600c:3011:b0:40f:ddb1:dff6 with SMTP id j17-20020a05600c301100b0040fddb1dff6mr376290wmh.28.1707155129866; Mon, 05 Feb 2024 09:45:29 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCW0iRwJ4iK/1l5nccg8ejnbUpry1gNIfzjuLEOOT/5O1SnadHX8mF30Lt3dBquSMQ9iBWZaAoK5LYPVtw1BvDa73qNxIRIEekrw9/tuSsE5FzQt8XqtRIPnpXQ5cBWwzSiyse3B9eo51Np58H2ro7TB/GI/P/+CiHaHz9l4Le+ywVgofn63hBmTW+4vTMr9if42Vwn/dFxY+ZoTJO/4Bbs7c2Pmq4TiVExtmgujQocrxxEfWCd87n9GOQkCjgtFaKP/4JvXK+xvBpDrHK4CNj2wgp8h2GcBza2Gryvws8wnBOfFmbl1fL0/Cki6IYQ/19GQzIiRsikzV1xeytnJRhJzMjXH/HgPSktAktmvacMmOrTc27BBfSsxAcKCD/RwdZdN6utM9vwri1vyVZFbjwetOyIut79zZ+5d4g6jB1n4zLn1puq56QGYEHZVkxdnVD6UfOBCEMjn3FDx+gMRd1AgLnMuyWx/m1ENdeCIhAEdosVo2qjy9NEJlCNXhcpHWTP0Xk9O1mVBuJfKvCqNe+9ibSfD5ULoPlfEY7EzcpDDSDCNWa+nWgN6gC2dI7Hx1NlJXasSQMEDTDJZtP/CVz57zJIbVlcGNKGpgGof8Fv5KYPm03vyNz6Q2m+mMgPqqO69hb240frSev4L8YN8ugz7sHcK2k0XYvOn48j3wO+GP6KwVjX7XHv3AQ5KNx+fiauVQqvytkLaskwKk8P3CQRoi3zlNdwsuY4qSgZRAIl7VDRi/9pVggsxdyZfaqTsgbT9c5hy+uXxRA== Received: from jernej-laptop.localnet (82-149-13-182.dynamic.telemach.net. [82.149.13.182]) by smtp.gmail.com with ESMTPSA id l18-20020a05600c1d1200b0040e541ddcb1sm499607wms.33.2024.02.05.09.45.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 09:45:29 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Michael Turquette , Stephen Boyd , Chen-Yu Tsai , Samuel Holland , Guido =?ISO-8859-1?Q?G=FCnther?= , Purism Kernel Team , Ondrej Jirman , Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Oltmanns Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Frank Oltmanns Subject: Re: [PATCH v2 1/6] clk: sunxi-ng: nkm: Support constraints on m/n ratio and parent rate Date: Mon, 05 Feb 2024 18:45:27 +0100 Message-ID: <2717565.mvXUDI8C0e@jernej-laptop> In-Reply-To: <20240205-pinephone-pll-fixes-v2-1-96a46a2d8c9b@oltmanns.dev> References: <20240205-pinephone-pll-fixes-v2-0-96a46a2d8c9b@oltmanns.dev> <20240205-pinephone-pll-fixes-v2-1-96a46a2d8c9b@oltmanns.dev> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240205_094534_666394_65647DD5 X-CRM114-Status: GOOD ( 20.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne ponedeljek, 05. februar 2024 ob 16:22:24 CET je Frank Oltmanns napisal(a): > The Allwinner A64 manual lists the following constraints for the > PLL-MIPI clock: > - M/N <= 3 > - (PLL_VIDEO0)/M >= 24MHz > > The PLL-MIPI clock is implemented as ccu_nkm. Therefore, add support for > these constraints. > > Signed-off-by: Frank Oltmanns Haven't we discussed that this patch is unnecessary because same effect can be reached by limiting minimum frequency? Best regards, Jernej > --- > drivers/clk/sunxi-ng/ccu_nkm.c | 21 +++++++++++++++++++++ > drivers/clk/sunxi-ng/ccu_nkm.h | 2 ++ > 2 files changed, 23 insertions(+) > > diff --git a/drivers/clk/sunxi-ng/ccu_nkm.c b/drivers/clk/sunxi-ng/ccu_nkm.c > index 853f84398e2b..1168d894d636 100644 > --- a/drivers/clk/sunxi-ng/ccu_nkm.c > +++ b/drivers/clk/sunxi-ng/ccu_nkm.c > @@ -16,6 +16,20 @@ struct _ccu_nkm { > unsigned long m, min_m, max_m; > }; > > +static bool ccu_nkm_is_valid_rate(struct ccu_common *common, unsigned long parent, > + unsigned long n, unsigned long m) > +{ > + struct ccu_nkm *nkm = container_of(common, struct ccu_nkm, common); > + > + if (nkm->max_m_n_ratio && (m > nkm->max_m_n_ratio * n)) > + return false; > + > + if (nkm->min_parent_m_ratio && (parent < nkm->min_parent_m_ratio * m)) > + return false; > + > + return true; > +} > + > static unsigned long ccu_nkm_find_best_with_parent_adj(struct ccu_common *common, > struct clk_hw *parent_hw, > unsigned long *parent, unsigned long rate, > @@ -31,6 +45,10 @@ static unsigned long ccu_nkm_find_best_with_parent_adj(struct ccu_common *common > unsigned long tmp_rate, tmp_parent; > > tmp_parent = clk_hw_round_rate(parent_hw, rate * _m / (_n * _k)); > + > + if (!ccu_nkm_is_valid_rate(common, tmp_parent, _n, _m)) > + continue; > + > tmp_rate = tmp_parent * _n * _k / _m; > > if (ccu_is_better_rate(common, rate, tmp_rate, best_rate) || > @@ -64,6 +82,9 @@ static unsigned long ccu_nkm_find_best(unsigned long parent, unsigned long rate, > for (_k = nkm->min_k; _k <= nkm->max_k; _k++) { > for (_n = nkm->min_n; _n <= nkm->max_n; _n++) { > for (_m = nkm->min_m; _m <= nkm->max_m; _m++) { > + if (!ccu_nkm_is_valid_rate(common, parent, _n, _m)) > + continue; > + > unsigned long tmp_rate; > > tmp_rate = parent * _n * _k / _m; > diff --git a/drivers/clk/sunxi-ng/ccu_nkm.h b/drivers/clk/sunxi-ng/ccu_nkm.h > index 6601defb3f38..c409212ee40e 100644 > --- a/drivers/clk/sunxi-ng/ccu_nkm.h > +++ b/drivers/clk/sunxi-ng/ccu_nkm.h > @@ -27,6 +27,8 @@ struct ccu_nkm { > struct ccu_mux_internal mux; > > unsigned int fixed_post_div; > + unsigned long max_m_n_ratio; > + unsigned long min_parent_m_ratio; > > struct ccu_common common; > }; > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel