From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6859EC54E41 for ; Mon, 4 Mar 2024 21:33:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=14GKD/b3zAuT8A8FeFK6/m1dLGs87ghiWi6pQRFd//I=; b=NSrgdOBIgEC1F1 fZrzXAiWraaDcuqFJnzaoiTJR9IJ7DMjbpZ4IpU4g509hvuV75nLi8+TbMmd5nxmZs+j9WAjueNoN v1VLZH2Kx74RNrd5D1r5Xvry6HcIh0L2OhNTn7q5ZN2ysIQDBDTEmk+doB7VHy1xWwSX/F5/ttUDR Au+6M79kEBQhxCAWCYlz/fuxXO16Tc8VyrJuMnBZyvyri5aeiiCOuqC1Hrr6VFv+NXOIZCw3ewt62 pmJjTZUGNn9pZDPD3H4Y/3mTYE26KfTAK10Ws0/Zt8c7p68QfHnxbRBT8o2sC3TpiYFsJ2W/AFSLG IqbRuS3I4Qa1dOwrbrkg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhFvd-0000000An7C-1AZf; Mon, 04 Mar 2024 21:32:57 +0000 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhFva-0000000An5n-3EpC for linux-arm-kernel@lists.infradead.org; Mon, 04 Mar 2024 21:32:56 +0000 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-33ddd1624beso3252060f8f.1 for ; Mon, 04 Mar 2024 13:32:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709587972; x=1710192772; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4gEfJ2Kg9284/c3Le6qMD+DwxWh1aoS/80hOyg6wh6o=; b=fHKjCEpwrzV5wBk42hgBfCnorSLhFFNtj4HDFFXnDKnIjuH0g0PYfEj/X+sk8SQ2oN g0woetc1fKuAvFoqRIrk+Y0EWcyL3me54WVO2boqU8DUX0F8keuETiznA3RfTn4p8Nuq RFmOdtjKu5FPAntBqoszcYcud+nCkXZgElZx92nCm1abV4fwUlFIyfPd0CA6WLeVByxC uEwD0IvHJCKNgG6Qbjry3R6L0qxcuie6K92W20fXeBq4itMLTN30RQc37se6EozFq4NF EIvtyEJ6ENtqYA538NnQTH8MEU8NeInvfAcKAy5nzc9GqVbSYWHmCNkE38xYWyObgcTS 2b+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709587972; x=1710192772; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4gEfJ2Kg9284/c3Le6qMD+DwxWh1aoS/80hOyg6wh6o=; b=O+YhxeoSrV7B9yDusAeUDwCxFosnt6dYGY6KhZ7if6p78A3H9AAScExoeg2bWw5Msb V/1LhT+x2PHqraZIbGLGR3WCPk41qVumw64F6/ScW/TeklVCs2QIhyzyd+ussvdFIf5p yLvJfycFc39rJpGJgUpWRRkxlfPObrsulHbHOIcRmL7DyDQVLxT6crfq5wrkyg2hnfA4 5tI0to+JgFlujhYfWQY77ycA4mI9wF6qx7QgGkKIVpGw+0HmGBiZltLW74+1HWraIePS HmSlPAu/PhHwQn/JziQhpjQSyIHQ/hlMLQv85LSg6iKVaQu9SGhXssJ7ibNyvGEw2QXv VrsQ== X-Forwarded-Encrypted: i=1; AJvYcCU0/nJxYlqpzoXSJQ65ONpLKpTXncgMq30jalUil2w69QyRl4GQyQwtY6ufbcm9BVwSxmUHioeuw2e+SpAvwBStXTiQRZcphOwJbiQ49wOJaXUolhg= X-Gm-Message-State: AOJu0Yx4MWEg1Yjri3IGG1TMc0uNbcJ0W/Efoexp8UZhfoZ2xUtxEiAR NN26bUTa+4RotsO5xVUq2INP+uKHzHhvA7QxeYr8eSNjK62hy7fh X-Google-Smtp-Source: AGHT+IE8DqAnRoNBogGFb/riHiJFzj/xl1Ztb0tsaT8WRbkyPQ87GhcWCrkRQmVMiZdGWnSTZyDn5w== X-Received: by 2002:adf:ca04:0:b0:33d:c45:15ec with SMTP id o4-20020adfca04000000b0033d0c4515ecmr643795wrh.32.1709587972146; Mon, 04 Mar 2024 13:32:52 -0800 (PST) Received: from jernej-laptop.localnet (86-58-6-171.dynamic.telemach.net. [86.58.6.171]) by smtp.gmail.com with ESMTPSA id u20-20020adfcb14000000b0033b7ce8b496sm13078199wrh.108.2024.03.04.13.32.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 13:32:51 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= Cc: Chen-Yu Tsai , Samuel Holland , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@pengutronix.de Subject: Re: [PATCH 5/5] PM / devfreq: sun8i-a33-mbus: Convert to platform remove callback returning void Date: Mon, 04 Mar 2024 22:32:50 +0100 Message-ID: <2719174.mvXUDI8C0e@jernej-laptop> In-Reply-To: <0ca3f35bdf9549ccda7c6c10a476f28350d987df.1709587301.git.u.kleine-koenig@pengutronix.de> References: <0ca3f35bdf9549ccda7c6c10a476f28350d987df.1709587301.git.u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240304_133254_840568_EC3870C1 X-CRM114-Status: GOOD ( 23.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne ponedeljek, 04. marec 2024 ob 22:28:43 CET je Uwe Kleine-K=F6nig napisa= l(a): > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > = > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new(), which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > = > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > = > Signed-off-by: Uwe Kleine-K=F6nig Acked-by: Jernej Skrabec Best regards, Jernej > --- > drivers/devfreq/sun8i-a33-mbus.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > = > diff --git a/drivers/devfreq/sun8i-a33-mbus.c b/drivers/devfreq/sun8i-a33= -mbus.c > index 13d32213139f..bcf654f4ff96 100644 > --- a/drivers/devfreq/sun8i-a33-mbus.c > +++ b/drivers/devfreq/sun8i-a33-mbus.c > @@ -458,7 +458,7 @@ static int sun8i_a33_mbus_probe(struct platform_devic= e *pdev) > return dev_err_probe(dev, ret, err); > } > = > -static int sun8i_a33_mbus_remove(struct platform_device *pdev) > +static void sun8i_a33_mbus_remove(struct platform_device *pdev) > { > struct sun8i_a33_mbus *priv =3D platform_get_drvdata(pdev); > unsigned long initial_freq =3D priv->profile.initial_freq; > @@ -475,8 +475,6 @@ static int sun8i_a33_mbus_remove(struct platform_devi= ce *pdev) > clk_rate_exclusive_put(priv->clk_mbus); > clk_rate_exclusive_put(priv->clk_dram); > clk_disable_unprepare(priv->clk_bus); > - > - return 0; > } > = > static const struct sun8i_a33_mbus_variant sun50i_a64_mbus =3D { > @@ -497,7 +495,7 @@ static SIMPLE_DEV_PM_OPS(sun8i_a33_mbus_pm_ops, > = > static struct platform_driver sun8i_a33_mbus_driver =3D { > .probe =3D sun8i_a33_mbus_probe, > - .remove =3D sun8i_a33_mbus_remove, > + .remove_new =3D sun8i_a33_mbus_remove, > .driver =3D { > .name =3D "sun8i-a33-mbus", > .of_match_table =3D sun8i_a33_mbus_of_match, > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel