From: "Heiko Stübner" <heiko@sntech.de>
To: Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Arnd Bergmann <arnd@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
Zhang Yubing <yubing.zhang@rock-chips.com>,
Frank Wang <frank.wang@rock-chips.com>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phy: rockchip: fix CONFIG_TYPEC dependency
Date: Tue, 16 Apr 2024 08:26:57 +0200 [thread overview]
Message-ID: <2727344.mvXUDI8C0e@diego> (raw)
In-Reply-To: <20240415174241.77982-1-arnd@kernel.org>
Am Montag, 15. April 2024, 19:42:25 CEST schrieb Arnd Bergmann:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The newly added driver causes a warning about missing dependencies
> by selecting CONFIG_TYPEC unconditionally:
>
> WARNING: unmet direct dependencies detected for TYPEC
> Depends on [n]: USB_SUPPORT [=n]
> Selected by [y]:
> - PHY_ROCKCHIP_USBDP [=y] && ARCH_ROCKCHIP [=y] && OF [=y]
>
> WARNING: unmet direct dependencies detected for USB_COMMON
> Depends on [n]: USB_SUPPORT [=n]
> Selected by [y]:
> - EXTCON_RTK_TYPE_C [=y] && EXTCON [=y] && (ARCH_REALTEK [=y] || COMPILE_TEST [=y]) && TYPEC [=y]
>
> Since that is a user-visible option, it should not really be selected
> in the first place. Replace the 'select' with a 'depends on' as
> we have for similar drivers.
>
> Fixes: 2f70bbddeb45 ("phy: rockchip: add usbdp combo phy driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> ---
> drivers/phy/rockchip/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/rockchip/Kconfig b/drivers/phy/rockchip/Kconfig
> index a752ccdddb86..08b0f4345760 100644
> --- a/drivers/phy/rockchip/Kconfig
> +++ b/drivers/phy/rockchip/Kconfig
> @@ -120,8 +120,8 @@ config PHY_ROCKCHIP_USB
> config PHY_ROCKCHIP_USBDP
> tristate "Rockchip USBDP COMBO PHY Driver"
> depends on ARCH_ROCKCHIP && OF
> + depends on TYPEC
> select GENERIC_PHY
> - select TYPEC
> help
> Enable this to support the Rockchip USB3.0/DP combo PHY with
> Samsung IP block. This is required for USB3 support on RK3588.
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-04-16 6:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 17:42 [PATCH] phy: rockchip: fix CONFIG_TYPEC dependency Arnd Bergmann
2024-04-16 6:26 ` Heiko Stübner [this message]
2024-04-17 14:39 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2727344.mvXUDI8C0e@diego \
--to=heiko@sntech.de \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=cristian.ciocaltea@collabora.com \
--cc=frank.wang@rock-chips.com \
--cc=kishon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=sebastian.reichel@collabora.com \
--cc=vkoul@kernel.org \
--cc=yubing.zhang@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).