From: "Heiko Stübner" <heiko@sntech.de>
To: Dragan Simic <dsimic@manjaro.org>,
Sergey 'Jin' Bostandzhyan <jin@mediatomb.cc>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] arm64: dts: rockchip: improve eMMC speed on NanoPi R2S Plus
Date: Fri, 16 Aug 2024 12:16:47 +0200 [thread overview]
Message-ID: <2743124.mvXUDI8C0e@diego> (raw)
In-Reply-To: 002107db3dcf3f1d1d1a767f049b5b79@manjaro.org
Am Freitag, 16. August 2024, 12:10:18 CEST schrieb Sergey 'Jin' Bostandzhyan:
> Hi,
>
> On Fri, Aug 16, 2024 at 08:51:40AM +0200, Dragan Simic wrote:
> > On 2024-08-14 19:00, Sergey Bostandzhyan wrote:
> > >This change has been suggested by Daniel Golle during patch review,
> > >adding mmc-hs200-1_8v; makes sure that eMMC gets detected as HS200
> > >which improves it's performance.
> >
> > Describing who suggested the patch in the patch description looks
> > out of place. Instead, you should add a Suggested-by tag, whose
> > purpose is exactly to describe who suggested the patch.
>
> thank you for the pointer, I guess I missed that, I generally had a hard time to
> come to grips with the hole process as there are so many details and nuances.
>
> Heiko, I guess it is too late to fix that now, sine you wrote that the
> patch has been applied?
correct ... and also folded into the first devicetree patch.
So no worries :-) .
Heiko
next prev parent reply other threads:[~2024-08-16 10:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 17:00 [PATCH v3 0/3] Add DTS for NanoPi R2S Plus Sergey Bostandzhyan
2024-08-14 17:00 ` [PATCH v3 1/3] arm64: dts: rockchip: Add DTS for FriendlyARM " Sergey Bostandzhyan
2024-08-14 17:00 ` [PATCH v3 2/3] dt-bindings: arm: rockchip: Add " Sergey Bostandzhyan
2024-08-14 17:00 ` [PATCH v3 3/3] arm64: dts: rockchip: improve eMMC speed on " Sergey Bostandzhyan
2024-08-16 6:51 ` Dragan Simic
2024-08-16 10:10 ` Sergey 'Jin' Bostandzhyan
2024-08-16 10:16 ` Heiko Stübner [this message]
2024-08-15 18:28 ` [PATCH v3 0/3] Add DTS for " Rob Herring (Arm)
2024-08-15 20:18 ` Heiko Stuebner
2024-08-15 23:26 ` Sergey 'Jin' Bostandzhyan
2024-08-25 16:28 ` m.plak
2024-08-26 9:12 ` Sergey 'Jin' Bostandzhyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2743124.mvXUDI8C0e@diego \
--to=heiko@sntech.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dsimic@manjaro.org \
--cc=jin@mediatomb.cc \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).