From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 509AEC7618B for ; Wed, 15 Mar 2023 16:05:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wnFpoRAMQKtKDsAqIr2FtZdld7bbBM3OCyAxR1aLofQ=; b=UOOtC71bH4+tht 7CDTo5OAjjepm3CzzVBtcq6vUZelUmMyj7FRYuULDR5/R0mFnoZr8kMu6UkDRtqSmjg5oFoSCQnc8 Erchl7jG/cPQalio1PaLW812s6tN8idCeURQ1Of8mwqIpdL906T+IYBN61zTRFTylQScQz+x583rX s6NPxXsyRw/hC22o337YVN87xV8oiF95BN/zliDerxpg7sasre/rk79HpyACdsyYa86J4Y7zER3IZ pVU+cz3gLH9HI5G2X9W+ARPk8p8xlpnM1bxz/RdQGaqGboTVBWp1XpZQTVnAH56ER5nzY8OEhv863 nreitAE5e1JztYODq9aQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcTci-00E0Cp-0T; Wed, 15 Mar 2023 16:05:08 +0000 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pcTcf-00E02T-3A for linux-arm-kernel@lists.infradead.org; Wed, 15 Mar 2023 16:05:07 +0000 Received: by mail-ed1-x529.google.com with SMTP id o12so77492553edb.9 for ; Wed, 15 Mar 2023 09:05:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678896305; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OrfavOiI9RHFnuLIIn9fSoym+hJaH0KWDtFZHQ7FhFE=; b=GYgwADQDRBv/KWKhXsXUcAUFhDAgznha4R9pZMM9lDygOvRsskp2sjqb5eGtcIsRjb +BQBH+S7c2+bFJrgEcsJ33lmxXF+xaHV+Zf6R1acx0kd4THA11wrWaDE2PS71ADw1nhn Zx65qJONgMbEaCHuppuPpK/f19Y0eRvpyxKFsy2BYQpLOWC1Mysn+5xwS+qj0OBSMovR Uao5l7U1tmHILuzCEi0wR413TLsrQz3cmOUWwtDxd4w6T4wD/oEOOPpUwbCuBoECppEq vBHqkwqTycHcEvSf+HIIuFtDOtNKeTswqPcdwrlIsB2rmFNZOi/+cUOYLoGfJBl78Au4 pr1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678896305; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OrfavOiI9RHFnuLIIn9fSoym+hJaH0KWDtFZHQ7FhFE=; b=jfeMKxVth2bZA8MzTTgl4VfE4SluRwK8hPfr+nTkUqGumnOrkN2+APAGx3yWzlwq2D V8wB7mRZH4WsyQLv1dzm46s7J/qgFySA1pq5sfvO6GK/NUB+la6TUuLd6ASWnI2b9R6a nbewGVFRi96jJ1T9AimrkzLRVkp9E8BuEbqaBbUg0xyF9VegumKLrp5HaZufmpyMiZT1 yd7lUh8ONX7NNoL/H9MpJSNx9R+aCEynGd1nIwzQcxGfKGY39haRD3xuLAu2nhHq0QgX aRvmXypXPRHOqCSPsBPOAh5mfUixb3DenjNga9ntiVVYitC4E8oIWLGWtbxMboUQK9yT ZPKQ== X-Gm-Message-State: AO0yUKWO0oSnbp9FhDHDbDGPmLXYxDqDkM95JUXONbBncAQ77qsarqfn 0zdNNeEA4qGOvmh5n/FbNXM= X-Google-Smtp-Source: AK7set+myhS2q8BMTQLFMetCV+tCvu86Y0EnLMDAIQz6lrKoBkjoRsSEoQr/z5hKWoUoEpc8DQ+YAQ== X-Received: by 2002:a17:906:d211:b0:926:9c33:ea4 with SMTP id w17-20020a170906d21100b009269c330ea4mr7175408ejz.27.1678896305325; Wed, 15 Mar 2023 09:05:05 -0700 (PDT) Received: from jernej-laptop.localnet (82-149-1-233.dynamic.telemach.net. [82.149.1.233]) by smtp.gmail.com with ESMTPSA id h11-20020a17090619cb00b008b30e2a450csm2714894ejd.144.2023.03.15.09.05.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 09:05:04 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai , Samuel Holland , Charles Keepax , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= Cc: alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@pengutronix.de Subject: Re: [PATCH 142/173] ASoC: sunxi: sun4i-spdif: Convert to platform remove callback returning void Date: Wed, 15 Mar 2023 17:05:03 +0100 Message-ID: <2745562.BEx9A2HvPv@jernej-laptop> In-Reply-To: <20230315150745.67084-143-u.kleine-koenig@pengutronix.de> References: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> <20230315150745.67084-143-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230315_090506_016182_F55E64EA X-CRM114-Status: GOOD ( 21.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne sreda, 15. marec 2023 ob 16:07:14 CET je Uwe Kleine-K=F6nig napisal(a): > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > = > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > = > Signed-off-by: Uwe Kleine-K=F6nig Acked-by: Jernej Skrabec Best regards, Jernej > --- > sound/soc/sunxi/sun4i-spdif.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > = > diff --git a/sound/soc/sunxi/sun4i-spdif.c b/sound/soc/sunxi/sun4i-spdif.c > index bcceebca915a..ff18d4113aac 100644 > --- a/sound/soc/sunxi/sun4i-spdif.c > +++ b/sound/soc/sunxi/sun4i-spdif.c > @@ -703,13 +703,11 @@ static int sun4i_spdif_probe(struct platform_device > *pdev) return ret; > } > = > -static int sun4i_spdif_remove(struct platform_device *pdev) > +static void sun4i_spdif_remove(struct platform_device *pdev) > { > pm_runtime_disable(&pdev->dev); > if (!pm_runtime_status_suspended(&pdev->dev)) > sun4i_spdif_runtime_suspend(&pdev->dev); > - > - return 0; > } > = > static const struct dev_pm_ops sun4i_spdif_pm =3D { > @@ -724,7 +722,7 @@ static struct platform_driver sun4i_spdif_driver =3D { > .pm =3D &sun4i_spdif_pm, > }, > .probe =3D sun4i_spdif_probe, > - .remove =3D sun4i_spdif_remove, > + .remove_new =3D sun4i_spdif_remove, > }; > = > module_platform_driver(sun4i_spdif_driver); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel