Re: [v2,1/4] dt-bindings: pwm: Convert pwm-mtk-disp.txt to mediatek,pwm-disp.yaml format

Rob Herring
2022-02-24T20:50:44Z

On Thu, Feb 17, 2022 at 08:35:58PM +0800, xinlei.lee wrote:
> On Wed, 2022-02-16 at 16:51 -0600, Rob Herring wrote:
> > On Wed, 16 Feb 2022 17:32:48 +0800, xinlei.lee@mediatek.com wrote:
> > > From: Xinlei Lee <xinlei.lee@mediatek.corp-partner.google.com>
> > >
> > > Convert pwm-mtk-disp.txt to mediatek,pwm-disp.yaml format as
> > > suggested by maintainer
> > >
> > > Signed-off-by: Xinlei Lee <
> > > xinlei.lee@mediatek.corp-partner.google.com>
> > > ---
> > > .../bindings/pwm/mediatek,pwm-disp.yaml | 71
> > > +++++++++++++++++++
> > > .../devicetree/bindings/pwm/pwm-mtk-disp.txt | 44 ------------
> > > 2 files changed, 71 insertions(+), 44 deletions(-)
> > > create mode 100755
> > > Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> > > delete mode 100644 Documentation/devicetree/bindings/pwm/pwm-mtk-
> > > disp.txt
> > >
> >
> > Running 'make dtbs_check' with the schema in this patch gives the
> > following warnings. Consider if they are expected or the schema is
> > incorrect. These may not be new warnings.
> >
> > Note that it is not yet a requirement to have 0 warnings for
> > dtbs_check.
> > This will change in the future.
> >
> > Full log is available here:
> > https://patchwork.ozlabs.org/patch/1593550
> >
> >
> > pwm@1400a000: compatible:0: 'mediatek,mt7623-disp-pwm' is not one of
> > ['mediatek,mt2701-disp-pwm', 'mediatek,mt6595-disp-pwm',
> > 'mediatek,mt8173-disp-pwm', 'mediatek,mt8183-disp-pwm']
> > arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dt.yaml
> > arch/arm/boot/dts/mt7623n-rfb-emmc.dt.yaml
> >
> > pwm@1400a000: compatible: ['mediatek,mt7623-disp-pwm',
> > 'mediatek,mt2701-disp-pwm'] is too long
> > arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dt.yaml
> > arch/arm/boot/dts/mt7623n-rfb-emmc.dt.yaml
> >
> > pwm@1400a000: 'oneOf' conditional failed, one must be fixed:
> > arch/arm/boot/dts/mt2701-evb.dt.yaml
> > arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dt.yaml
> > arch/arm/boot/dts/mt7623n-rfb-emmc.dt.yaml
> >
> > pwm@1400a000: 'power-domains' is a required property
> > arch/arm/boot/dts/mt2701-evb.dt.yaml
> > arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dt.yaml
> > arch/arm/boot/dts/mt7623n-rfb-emmc.dt.yaml
> >
> > pwm@1401e000: compatible: ['mediatek,mt8173-disp-pwm',
> > 'mediatek,mt6595-disp-pwm'] is too long
> > arch/arm64/boot/dts/mediatek/mt8173-elm.dt.yaml
> > arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dt.yaml
> > arch/arm64/boot/dts/mediatek/mt8173-elm-hana-rev7.dt.yaml
> > arch/arm64/boot/dts/mediatek/mt8173-evb.dt.yaml
> >
> > pwm@1401e000: 'oneOf' conditional failed, one must be fixed:
> > arch/arm64/boot/dts/mediatek/mt8173-elm.dt.yaml
> > arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dt.yaml
> > arch/arm64/boot/dts/mediatek/mt8173-elm-hana-rev7.dt.yaml
> > arch/arm64/boot/dts/mediatek/mt8173-evb.dt.yaml
> >
> > pwm@1401e000: 'power-domains' is a required property
> > arch/arm64/boot/dts/mediatek/mt8173-elm.dt.yaml
> > arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dt.yaml
> > arch/arm64/boot/dts/mediatek/mt8173-elm-hana-rev7.dt.yaml
> > arch/arm64/boot/dts/mediatek/mt8173-evb.dt.yaml
> >
> > pwm@1401f000: compatible: ['mediatek,mt8173-disp-pwm',
> > 'mediatek,mt6595-disp-pwm'] is too long
> > arch/arm64/boot/dts/mediatek/mt8173-elm.dt.yaml
> > arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dt.yaml
> > arch/arm64/boot/dts/mediatek/mt8173-elm-hana-rev7.dt.yaml
> > arch/arm64/boot/dts/mediatek/mt8173-evb.dt.yaml
> >
> Hi Rob:
>
> Thanks for your review. I'm trying to modify the dtbs_check warning you
> mentioned. I would like to ask what cmd I can use to test the modified
> dtbs_check locally.

# Enable building all dtbs
make allmodconfig

make dtbs_check DT_SCHEMA_FILES=path/to/schema.yaml

> Also for WARNING: DT binding docs and includes should be a separate
> patch. I've also made some attempts including splitting the delete .txt
> and create .yaml files into two patches, but the warning doesn't
> resolve. Do you have any suggestions for the results of checkpatch
> ?This will help a lot with the next edition I send out.

Ignore it for conversion patches.

Rob