public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>
Cc: linux@ew.tq-group.com, devicetree@vger.kernel.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] ARM: dts: imx6qdl: Add reserved memory area for CMA memory
Date: Mon, 09 Sep 2024 16:11:14 +0200	[thread overview]
Message-ID: <2751338.mvXUDI8C0e@steina-w> (raw)
In-Reply-To: <10526262.nUPlyArG6x@steina-w>

Am Mittwoch, 28. August 2024, 09:49:36 CEST schrieb Alexander Stein:
> Am Dienstag, 27. August 2024, 16:24:58 CEST schrieb Alexander Stein:
> > Default CMA size is too small for HDMI output and VPU usage. Increase the
> > default size by providing a CMA memory area.
> > 
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> > Smallest RAM variant has 512MiB.
> > 
> >  arch/arm/boot/dts/nxp/imx/imx6qdl-mba6.dtsi | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6.dtsi
> > index d03f7065ddfd7..8ba3ec27bee07 100644
> > --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6.dtsi
> > +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6.dtsi
> > @@ -106,6 +106,20 @@ reg_vcc3v3_audio: regulator-vcc3v3-audio {
> >  		vin-supply = <&reg_mba6_3p3v>;
> >  	};
> >  
> > +	reserved-memory {
> > +		#address-cells = <1>;
> > +		#size-cells = <1>;
> > +		ranges;
> > +
> > +		linux,cma {
> > +			compatible = "shared-dma-pool";
> > +			reusable;
> > +			size = <0x14000000>;
> > +			alloc-ranges = <0x10000000 0x20000000>;
> > +			linux,cma-default;
> > +		};
> > +	};
> > +
> 
> Please do not merge yet.
> I just noticed that this breaks mmap'ed fbdev usage. It only works when CMA
> area is in HighMem.

Okay, now that commit 5a498d4d06d6d ("drm/fbdev-dma: Only install deferred
I/O if necessary") has been applied, the mentioned problem is gone.
This patch can be applied if there are no concerns.

Best regards,
Alexander
-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/




  reply	other threads:[~2024-09-09 14:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-27 14:24 [PATCH 1/1] ARM: dts: imx6qdl: Add reserved memory area for CMA memory Alexander Stein
2024-08-27 14:32 ` Fabio Estevam
2024-08-28  6:12   ` Alexander Stein
2024-08-28  7:49 ` Alexander Stein
2024-09-09 14:11   ` Alexander Stein [this message]
2024-10-08  8:50 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2751338.mvXUDI8C0e@steina-w \
    --to=alexander.stein@ew.tq-group.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@ew.tq-group.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox