From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Mon, 10 Jun 2013 16:02:04 +0200 Subject: [PATCH v2 04/11] mfd:stixxxx-syscfg: Add ST System Configuration support. In-Reply-To: <51B5DA26.6070707@st.com> References: <1370855828-5318-1-git-send-email-srinivas.kandagatla@st.com> <51B5DA26.6070707@st.com> Message-ID: <2757224.FBxg98dX57@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday 10 June 2013 14:52:38 Srinivas KANDAGATLA wrote: > On 10/06/13 14:16, Linus Walleij wrote: > > On Mon, Jun 10, 2013 at 11:22 AM, Srinivas KANDAGATLA > > wrote: > > > >> This mfd driver provides higher level inialization routines for various > >> IPs like Ethernet, USB, PCIE, SATA and so on. Also it provides way to > >> get to syscfg registers via standard regmap api which is usefull for > >> drivers like pinctrl. > >> > >> This patch adds support to ST System Configuration registers, which can > >> be configured by the drivers. > >> > >> Signed-off-by: Srinivas Kandagatla > >> CC: Stuart Menefy > >> CC: Stephen Gallimore > >> CC: Linus Walleij > >> CC: Mark Brown > > > > What is this driver doing that drivers/mfd/syscon.c is not already > > doing? > > As of now, the driver is very much similar to syscon + some additional > functionality, but we are planning to use this file to add higher level > functions to configure different IPs like ethernet, usb, power, reset > and so on which are very much specific to ST System Configuration Registers. I was expecting that you'd actually interface with the syscon code and build on top, rather than copy it. There are multiple ways of doing that, e.g. you could export a function from syscon.c that you call to register the device node and then import the regmap from syscon into your high-level driver again. Arnd