From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 676D0C48BD1 for ; Wed, 9 Jun 2021 10:54:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B36061059 for ; Wed, 9 Jun 2021 10:54:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B36061059 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hFfK0uizRlJV4Ei9WZv6CbqB1iUMr31kiwSos1ciNSg=; b=cRG2X5onZGBJb2amzvhkJ6ZCaj +iSpbS9s8NyIMLYqWIdcqAdPH/RFhRc2GXSAFX8phfZfRUt3i7AFShkcEUUPQmn7XNFyCNoXQUv5Y kL2inAbPwbG8GTznAigYVznbNJht4iRRgXRudS/J3qEFgzn6c5w6RFap4fj72nVdhrJSRpG+fPS3F TrHBJ482QZzS0RN8IHUbRjSdKVqEoLh3CKIg4vvPyVLU6FGQVCyBWj1YikPXyWwz2Yx82XIHv21dX WDkZwjAPAOh3PfBE6iKfE92Vj8++xdfrLhsPbpuXenpPPKtOs3rEpHECWlkt0b3G0OOmQ7X4DwHQg 2xnHJ7Ug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqvos-00D8pH-2X; Wed, 09 Jun 2021 10:52:22 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqvom-00D8kp-Rz for linux-arm-kernel@lists.infradead.org; Wed, 09 Jun 2021 10:52:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623235935; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VZPPxlVuFpma5nN0KBwsgNEj1D60a3U+wCT7M5MPOro=; b=Km5r1M+sxIq4QxvZF6wtjHOv+NX0GD/tnBHzME3FShlP42FQZPxI28LSs2skwcRMKR6KJh 0XJz2rmTh/jJT0lX2DtPOYM/XEAPwKAOmVwutgOGYzNlj3DmYYtDvRxwcjs6H58IXcjOxC UvVr5TV7PvMy2NUxlLSDVJZr9BvC36k= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-553-gTaaGs0rPN-bV7Yi89crVw-1; Wed, 09 Jun 2021 06:52:14 -0400 X-MC-Unique: gTaaGs0rPN-bV7Yi89crVw-1 Received: by mail-wr1-f69.google.com with SMTP id v15-20020a5d4a4f0000b0290118dc518878so10643116wrs.6 for ; Wed, 09 Jun 2021 03:52:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=VZPPxlVuFpma5nN0KBwsgNEj1D60a3U+wCT7M5MPOro=; b=eN60kI2mS4n1l80GO8l5RdidqTT4pFOOOelqTmMVpQLjUfOEnlippXSsgck6ODACmm oWpsEe3m8cRa26stj30g8F4jhTKTp2/dYeXFby+NmrAVlQV7uZ2wvWcSesCPSBuVw/LU sQ1lVqF5swWkgUHioH9XK7cQzA4vuxRcr31RgXRLzJavl3nD6AQ4WrFlFhwZ7nfyVgTX 8CeHrY7Z2BOZydibjBsnEF8pMJY3rkG0jhGDAKZXqo3su5VSCU4X+VwjtSWBPPnNBuUv zkiRw+t8UW5LqpkIk1nUoPnDGM77vUfDlEl8YF33oNTk+evENxcwo4ICZ3yVFhUCAt7o chZg== X-Gm-Message-State: AOAM531u8pLXZ4Nhlr6IaDzJ+14PvDgxKaDotM3shXvhdyw5IMYvss74 aVWrFa1ZPtiU5WteTlqLquz0tEYWL5z1wB48FajKEmDu85+RdmO6I4byqo9ftoDXOmIsT5YRz66 JpAFEJWc1AYG9GuXL65/9w1ZDm/EU1IoUQoY= X-Received: by 2002:a05:600c:c9:: with SMTP id u9mr26528260wmm.156.1623235933487; Wed, 09 Jun 2021 03:52:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwOhpm0kR/qb02GnRlZAdwrQqqdavzoWPuk2BGBrMztminfq9lmdrK+j2M/FH+Xh9QtwaeMHg== X-Received: by 2002:a05:600c:c9:: with SMTP id u9mr26528228wmm.156.1623235933268; Wed, 09 Jun 2021 03:52:13 -0700 (PDT) Received: from [192.168.3.132] (p5b0c611d.dip0.t-ipconnect.de. [91.12.97.29]) by smtp.gmail.com with ESMTPSA id 89sm25391165wrq.14.2021.06.09.03.52.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Jun 2021 03:52:13 -0700 (PDT) Subject: Re: [PATCH 2/9] arc: update comment about HIGHMEM implementation To: Mike Rapoport , Andrew Morton Cc: Arnd Bergmann , Geert Uytterhoeven , Ivan Kokshaysky , Jonathan Corbet , Matt Turner , Mike Rapoport , Richard Henderson , Vineet Gupta , kexec@lists.infradead.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-xtensa@linux-xtensa.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org References: <20210602105348.13387-1-rppt@kernel.org> <20210602105348.13387-3-rppt@kernel.org> From: David Hildenbrand Organization: Red Hat Message-ID: <2764dca8-f395-f76a-0939-215eccdfd82e@redhat.com> Date: Wed, 9 Jun 2021 12:52:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210602105348.13387-3-rppt@kernel.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210609_035217_056708_50F9A02F X-CRM114-Status: GOOD ( 24.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 02.06.21 12:53, Mike Rapoport wrote: > From: Mike Rapoport > > Arc does not use DISCONTIGMEM to implement high memory, update the comment > describing how high memory works to reflect this. > > Signed-off-by: Mike Rapoport > --- > arch/arc/mm/init.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/arch/arc/mm/init.c b/arch/arc/mm/init.c > index e2ed355438c9..397a201adfe3 100644 > --- a/arch/arc/mm/init.c > +++ b/arch/arc/mm/init.c > @@ -139,16 +139,13 @@ void __init setup_arch_memory(void) > > #ifdef CONFIG_HIGHMEM > /* > - * Populate a new node with highmem > - * > * On ARC (w/o PAE) HIGHMEM addresses are actually smaller (0 based) > - * than addresses in normal ala low memory (0x8000_0000 based). > + * than addresses in normal aka low memory (0x8000_0000 based). > * Even with PAE, the huge peripheral space hole would waste a lot of > - * mem with single mem_map[]. This warrants a mem_map per region design. > - * Thus HIGHMEM on ARC is imlemented with DISCONTIGMEM. > - * > - * DISCONTIGMEM in turns requires multiple nodes. node 0 above is > - * populated with normal memory zone while node 1 only has highmem > + * mem with single contiguous mem_map[]. > + * Thus when HIGHMEM on ARC is enabled the memory map corresponding > + * to the hole is freed and ARC specific version of pfn_valid() > + * handles the hole in the memory map. > */ > #ifdef CONFIG_DISCONTIGMEM > node_set_online(1); > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel