From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7CB04EB64DA for ; Thu, 20 Jul 2023 10:20:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xOdJZd3vbK3k8HFPZRNxoAvWYBFYLVtRn9dohp7351c=; b=UY4Q/0tLBAU0Nv tJHQ9KyNeYEAFMszVSORcQrv//ZFzHYqXI5K6yTcb+GE8rJEXOHjUllyMutET1dAIE803WHWtsmA7 jtdJUYrjjxAPVb8Zaq+JNDENFaBuB1l2T00adBuC0UbvqP5+jf2995dKdY+L2EVtttu0un5Va3chv NFEjdYPUjjegTGnHjwCGdejA/DJ9MpoeqWlIRn6B3o8L6A9dKHbLGAnDnZqMdsH3dF5KAYHY7IU19 ZbOCieQfJfDIh6HAiX7eG/U14TwiMEA6xT31wNc78GGI2JTgN0xXN6mPTuSOJTMZtYlBa1zsqFzQL dYw6vPz70H/fBjmoZgIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qMQlZ-00AjLq-1R; Thu, 20 Jul 2023 10:20:13 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qMQlV-00AjIU-1h for linux-arm-kernel@lists.infradead.org; Thu, 20 Jul 2023 10:20:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1689848409; x=1721384409; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=MboF/Yj6FZtYzwwj0ID9ddy66mCTdjv++Tu+1ox1wsc=; b=ZfjkXN3+i9uVmK5R0gOgMHlnKVJh+BeevYiBHg21bqkZ2Uilz361TYTf ZujM10irby8HfWNWUxeoSpxWgBB9wsGNEub64ZyqxCkD4eGnfstz4wEy5 m+HWQEEB+V/wc0r6fizrUDEZYY3u6mj4mppJ3CM9cgPT5mIHeDkXvRgtO vJTeNqfEQULc5CvF84N2Dba4qOGCsZmB+YUYD7IY8ROkFQt61PAtNVCHb 0FkpmH7Q1BXLtGXh7OCqCh7aXQ4kpTIhTG6DbA1tq6+DjqxNPO5LAoxPH O/lQZj+I7csPd2km3TmVY6Gnwh9cRSFN67o8AV0XHRrUkGPi8bkPJEXss Q==; X-IronPort-AV: E=Sophos;i="6.01,218,1684792800"; d="scan'208";a="32030419" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 20 Jul 2023 12:20:01 +0200 Received: from steina-w.localnet (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 05E90280078; Thu, 20 Jul 2023 12:20:01 +0200 (CEST) From: Alexander Stein To: Rui Miguel Silva , Laurent Pinchart , Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Fabio Estevam , Tim Harvey Cc: Pengutronix Kernel Team , NXP Linux Team , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] media: imx: imx7-media-csi: Fix applying format constraints Date: Thu, 20 Jul 2023 12:19:59 +0200 Message-ID: <2765509.BEx9A2HvPv@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20230720074129.3680269-2-alexander.stein@ew.tq-group.com> References: <20230720074129.3680269-1-alexander.stein@ew.tq-group.com> <20230720074129.3680269-2-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230720_032009_898884_24873795 X-CRM114-Status: GOOD ( 16.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Donnerstag, 20. Juli 2023, 09:41:29 CEST schrieb Alexander Stein: > v4l_bound_align_image aligns to a multiple power of 2 of walign, but the > result only needs to be a multiple of walign. Fix this by using > v4l2_apply_frmsize_constraints() instead. > = > Reported-by: Tim Harvey > Fixes: 6f482c4729d9 ("media: imx: imx7-media-csi: Get rid of superfluous > call to imx7_csi_mbus_fmt_to_pix_fmt") Signed-off-by: Alexander Stein > > --- > Tim, > can you please test if this fixes your problem? > Apparently this issue only arises under specific conditions, e.g. > 640/480/8bpp. This issue does not show up for 640/480/10bpp. > = > drivers/media/platform/nxp/imx7-media-csi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > = > diff --git a/drivers/media/platform/nxp/imx7-media-csi.c > b/drivers/media/platform/nxp/imx7-media-csi.c index > 73f8f2a35422..523e5f039a5a 100644 > --- a/drivers/media/platform/nxp/imx7-media-csi.c > +++ b/drivers/media/platform/nxp/imx7-media-csi.c > @@ -1141,8 +1141,8 @@ __imx7_csi_video_try_fmt(struct v4l2_pix_format > *pixfmt, * TODO: Implement configurable stride support. > */ > walign =3D 8 * 8 / cc->bpp; > - v4l_bound_align_image(&pixfmt->width, 1, 0xffff, walign, > - &pixfmt->height, 1, 0xffff, 1, 0); > + v4l2_apply_frmsize_constraints(&pixfmt->width, &pixfmt->height, > + &imx7_csi_frmsize_stepwise); Meh, this essentially removes the walign constraint. I need some more coffe= e = and this some more work. Sorry for the noise Alexander > = > pixfmt->bytesperline =3D pixfmt->width * cc->bpp / 8; > pixfmt->sizeimage =3D pixfmt->bytesperline * pixfmt->height; -- = TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel