Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Peter Griffin <peter.griffin@linaro.org>
Cc: Raghav Sharma <raghav.s@samsung.com>,
	s.nawrocki@samsung.com, cw00.choi@samsung.com,
	alim.akhtar@samsung.com, sboyd@kernel.org,
	bmasney+clk@redhat.com, jbrunet+clk@baylibre.com,
	robh@kernel.org, conor+dt@kernel.org,
	linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, is.gandhi@samsung.com,
	ts.amit@samsung.com, pokala.reddy@samsung.com
Subject: Re: [PATCH v3 00/14 RESEND] Add clock support for Exynos8855 SoC
Date: Wed, 18 Nov 2026 09:23:48 +0100	[thread overview]
Message-ID: <27677095-4f84-453b-934e-4451d8c549c6@kernel.org> (raw)
In-Reply-To: <CADrjBPpecGbRo2PhH_zqGfNf3L=bNf81q3SMXnSvD2n0Lx-cbA@mail.gmail.com>

On 16/11/2026 19:06, Peter Griffin wrote:
> Hi Krzysztof,
> 
> On Mon, 16 Nov 2026 at 10:02, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 13/11/2026 12:05, Raghav Sharma wrote:
>>> This patch series adds clock support for below blocks
>>> found in Exynos8855 SoC
>>> TOP & PERIC
>>> PERIS
>>> HSI
>>> USB
>>> There are many other blocks, for which the support will be
>>> added in a forthcoming patch series.
>>> Signed-off-by: Raghav Sharma <raghav.s@samsung.com>
>>> ---
>>
>>
>> Thanks, entire set applied (even if b4 thank-you letters show partial).
>> for-next will be updated later today after builds.
>>
> 
> Just FYI, there were a couple of outstanding review points on this series.
> https://lore.kernel.org/lkml/CADrjBPoR7_LDZmxC_bOFigvqDaagVihmybfX5AdvSPr9-FVb8w@mail.gmail.com/
> https://lore.kernel.org/lkml/CADrjBPrzHP_97OgAYacJKKqeCcp9FURoi6=Dmopk6nisTdEbdA@mail.gmail.com/
> https://lore.kernel.org/lkml/CADrjBPoAVMdxgU4P+shh+9O5rGJp+m3sRQMDd2c-7zbJ8qhiBQ@mail.gmail.com/
> 
> I guess the main thing that would be intrusive to fix in a follow up
> patch was introducing a slightly different naming scheme (compared to
> most existing Exynos SoCs). The clock names being
> "gout_<IP-clock_name>-<block-name>" as opposed to
> "gout_<block-name>_<IP-clock-name>" that we have for many SoCs. That
> also applies to the dt-bindings header "CLK_GOUT_WDT0_PERIS" not
> "CLK_GOUT_PERIS_WDT0" etc.

Oh, I completely missed these. I'll drop the series.

Best regards,
Krzysztof


      reply	other threads:[~2026-11-18  8:24 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20261113104829epcas5p13695795bc337b89816b05eec610a0dba@epcas5p1.samsung.com>
2026-11-13 11:05 ` [PATCH v3 00/14 RESEND] Add clock support for Exynos8855 SoC Raghav Sharma
2026-11-13 11:05   ` [PATCH v3 01/14 RESEND] dt-bindings: soc: samsung: Exynos8855 SYSREG compatibles Raghav Sharma
2026-11-13 10:57     ` Peter Griffin
2026-11-16 10:01     ` (subset) " Krzysztof Kozlowski
2026-11-13 11:06   ` [PATCH v3 02/14 RESEND] dt-bindings: clock: exynos8855: add top & peric clock definitions Raghav Sharma
2026-11-13 11:01     ` Peter Griffin
2026-11-13 11:06   ` [PATCH v3 03/14 RESEND] dt-bindings: clock: exynos8855: add peris " Raghav Sharma
2026-11-13 11:25     ` Peter Griffin
2026-11-13 11:06   ` [PATCH v3 04/14 RESEND] dt-bindings: clock: exynos8855: add hsi " Raghav Sharma
2026-11-13 11:02     ` Peter Griffin
2026-11-13 11:06   ` [PATCH v3 05/14 RESEND] dt-bindings: clock: exynos8855: add usb " Raghav Sharma
2026-11-13 11:03     ` Peter Griffin
2026-11-13 11:06   ` [PATCH v3 06/14 RESEND] clk: samsung: clk-pll: Add support for pll_4313 Raghav Sharma
2026-11-13 12:27     ` Peter Griffin
2026-11-19  3:52       ` Alim Akhtar
2026-11-13 11:06   ` [PATCH v3 07/14 RESEND] clk: samsung: exynos8855: add block top and peric clock support Raghav Sharma
2026-11-13 12:06     ` Peter Griffin
2026-11-13 11:06   ` [PATCH v3 08/14 RESEND] clk: samsung: exynos8855: add block peris " Raghav Sharma
2026-11-13 12:54     ` Peter Griffin
2026-11-13 11:06   ` [PATCH v3 09/14 RESEND] clk: samsung: exynos8855: add block hsi " Raghav Sharma
2026-11-13 11:06   ` [PATCH v3 10/14 RESEND] clk: samsung: exynos8855: add block usb " Raghav Sharma
2026-11-13 13:03     ` Peter Griffin
2026-11-13 11:06   ` [PATCH v3 11/14 RESEND] arm64: dts: exynos8855: add cmu_top & cmu_peric clock DT nodes Raghav Sharma
2026-11-13 12:59     ` Peter Griffin
2026-11-13 11:06   ` [PATCH v3 12/14 RESEND] arm64: dts: exynos8855: add cmu_peris " Raghav Sharma
2026-11-13 13:00     ` Peter Griffin
2026-11-13 11:06   ` [PATCH v3 13/14 RESEND] arm64: dts: exynos8855: add cmu_hsi " Raghav Sharma
2026-11-13 13:01     ` Peter Griffin
2026-11-13 11:06   ` [PATCH v3 14/14 RESEND] arm64: dts: exynos8855: add cmu_usb " Raghav Sharma
2026-11-13 13:01     ` Peter Griffin
2026-11-16 10:01   ` (subset) [PATCH v3 00/14 RESEND] Add clock support for Exynos8855 SoC Krzysztof Kozlowski
2026-11-16 10:02   ` Krzysztof Kozlowski
2026-11-16 18:06     ` Peter Griffin
2026-11-18  8:23       ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27677095-4f84-453b-934e-4451d8c549c6@kernel.org \
    --to=krzk@kernel.org \
    --cc=alim.akhtar@samsung.com \
    --cc=bmasney+clk@redhat.com \
    --cc=conor+dt@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=is.gandhi@samsung.com \
    --cc=jbrunet+clk@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=peter.griffin@linaro.org \
    --cc=pokala.reddy@samsung.com \
    --cc=raghav.s@samsung.com \
    --cc=robh@kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=sboyd@kernel.org \
    --cc=ts.amit@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox