linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v4 0/7] Reserve Timer Nodes to avoid clash with Remoteproc firmware
@ 2024-08-26 10:48 Beleswar Padhi
  2024-08-26 10:48 ` [PATCH v4 1/7] arm64: dts: ti: k3-j7200-som-p0: Change timer nodes status to reserved Beleswar Padhi
                   ` (8 more replies)
  0 siblings, 9 replies; 13+ messages in thread
From: Beleswar Padhi @ 2024-08-26 10:48 UTC (permalink / raw)
  To: nm, vigneshr, kristo, robh, krzk+dt, conor+dt
  Cc: u-kumar1, tony, bb, d-gole, afd, hnagalla, linux-arm-kernel,
	devicetree, linux-kernel

The remoteproc firmware like of R5F and DSPs in the MAIN voltage domain
use timers. At the same time, if Linux probes the timers, some
instability is observed while booting remote cores. Therefore, change
the status of the timer nodes to "reserved" to avoid any clash. 

NOTE: This series has been rebased on top of a sibling series[0] as both of them
introduce changes in the same files. Thus, please apply [0] before applying this
series.

[0]: https://lore.kernel.org/all/20240826093024.1183540-1-b-padhi@ti.com/

v4: Changelog:
1) Refactored changes from {}-common-proc-board.dts to {}-som.dtsi to put all
remoteproc related changes at one place as remotecores were getting enabled at
{}-som.dtsi file.
2) Rebased this series on top of [0].

* Nishanth:
1) Fixed $subject line for all patches to include the board level files where
the changes were applied instead of the SoC level files.
2) Applied these timer fixes to J721E-SK, AM68-SK and AM69-SK boards as well.

Link to v3:
https://lore.kernel.org/all/20240816073908.2343650-1-b-padhi@ti.com/

v3: Changelog:
* Udit
1) j7200: Updated commit message description to remove DSPs as the SoC does not
have one.
2) j722s: Updated the correct commit for "Fixes:" tag which introduced the bug.
3) For entire series, removed comment about timer usage by R5fs in the MCU
voltage domain as those are used by Device Manager firmware to get SoC
functional.

Link to v2:
https://lore.kernel.org/all/20240814104151.2038457-1-b-padhi@ti.com/

v2: Changelog:
- Split the changes into individual patches for each SoC to tag the
  correct offending commit for "Fixes:" tag.

* Udit
1) Add the correct clashing timer nodes for J7200 SoC.
2) Port these changes to board level dts files instead of SoC level dtsi files.

Link to v1:
https://lore.kernel.org/all/20240607105559.771080-1-b-padhi@ti.com/

Beleswar Padhi (7):
  arm64: dts: ti: k3-j7200-som-p0: Change timer nodes status to reserved
  arm64: dts: ti: k3-j721e-som-p0: Change timer nodes status to reserved
  arm64: dts: ti: k3-j721e-sk: Change timer nodes status to reserved
  arm64: dts: ti: k3-j721s2-som-p0: Change timer nodes status to
    reserved
  arm64: dts: ti: k3-am68-sk-som: Change timer nodes status to reserved
  arm64: dts: ti: k3-j784s4-evm: Change timer nodes status to reserved
  arm64: dts: ti: k3-am69-sk: Change timer nodes status to reserved

 arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi   | 25 ++++++++++++
 arch/arm64/boot/dts/ti/k3-am69-sk.dts        | 41 ++++++++++++++++++++
 arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi  | 13 +++++++
 arch/arm64/boot/dts/ti/k3-j721e-sk.dts       | 29 ++++++++++++++
 arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi  | 29 ++++++++++++++
 arch/arm64/boot/dts/ti/k3-j721s2-som-p0.dtsi | 25 ++++++++++++
 arch/arm64/boot/dts/ti/k3-j784s4-evm.dts     | 41 ++++++++++++++++++++
 7 files changed, 203 insertions(+)

-- 
2.34.1



^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH v4 1/7] arm64: dts: ti: k3-j7200-som-p0: Change timer nodes status to reserved
  2024-08-26 10:48 [PATCH v4 0/7] Reserve Timer Nodes to avoid clash with Remoteproc firmware Beleswar Padhi
@ 2024-08-26 10:48 ` Beleswar Padhi
  2024-08-26 10:54   ` Krzysztof Kozlowski
  2024-08-26 10:48 ` [PATCH v4 2/7] arm64: dts: ti: k3-j721e-som-p0: " Beleswar Padhi
                   ` (7 subsequent siblings)
  8 siblings, 1 reply; 13+ messages in thread
From: Beleswar Padhi @ 2024-08-26 10:48 UTC (permalink / raw)
  To: nm, vigneshr, kristo, robh, krzk+dt, conor+dt
  Cc: u-kumar1, tony, bb, d-gole, afd, hnagalla, linux-arm-kernel,
	devicetree, linux-kernel

The remoteproc firmware of R5F in the MAIN voltage domain use timers.
Therefore, change the status of the timer nodes to "reserved" to avoid
any clash. Usage is described as below:

	+===================+==========================+
	|  Remoteproc node  |        Timer Node        |
	+===================+==========================+
	| main_r5fss0_core0 | main_timer0, main_timer2 |
	+-------------------+--------------------------+
	| main_r5fss0_core1 | main_timer1              |
	+-------------------+--------------------------+

Fixes: c8a28ed4837c ("arm64: dts: ti: k3-j7200: Add general purpose timers")
Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi
index deb380a83ea1..e78b4622a7d1 100644
--- a/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi
@@ -266,6 +266,19 @@ &main_r5fss0 {
 	ti,cluster-mode = <0>;
 };
 
+/* Timers are used by Remoteproc firmware */
+&main_timer0 {
+	status = "reserved";
+};
+
+&main_timer1 {
+	status = "reserved";
+};
+
+&main_timer2 {
+	status = "reserved";
+};
+
 &main_r5fss0_core0 {
 	mboxes = <&mailbox0_cluster1 &mbox_main_r5fss0_core0>;
 	memory-region = <&main_r5fss0_core0_dma_memory_region>,
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH v4 2/7] arm64: dts: ti: k3-j721e-som-p0: Change timer nodes status to reserved
  2024-08-26 10:48 [PATCH v4 0/7] Reserve Timer Nodes to avoid clash with Remoteproc firmware Beleswar Padhi
  2024-08-26 10:48 ` [PATCH v4 1/7] arm64: dts: ti: k3-j7200-som-p0: Change timer nodes status to reserved Beleswar Padhi
@ 2024-08-26 10:48 ` Beleswar Padhi
  2024-08-26 10:48 ` [PATCH v4 3/7] arm64: dts: ti: k3-j721e-sk: " Beleswar Padhi
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 13+ messages in thread
From: Beleswar Padhi @ 2024-08-26 10:48 UTC (permalink / raw)
  To: nm, vigneshr, kristo, robh, krzk+dt, conor+dt
  Cc: u-kumar1, tony, bb, d-gole, afd, hnagalla, linux-arm-kernel,
	devicetree, linux-kernel

The remoteproc firmware like of R5F and DSPs in the MAIN voltage domain
use timers. Therefore, change the status of the timer nodes to
"reserved" to avoid any clash. Usage is described as below:

	+===================+==============+
	|  Remoteproc node  |  Timer Node  |
	+===================+==============+
	| main_r5fss0_core0 | main_timer12 |
	+-------------------+--------------+
	| main_r5fss0_core1 | main_timer13 |
	+-------------------+--------------+
	| main_r5fss1_core0 | main_timer14 |
	+-------------------+--------------+
	| main_r5fss1_core1 | main_timer15 |
	+-------------------+--------------+
	| c66_0             | main_timer0  |
	+-------------------+--------------+
	| c66_1             | main_timer1  |
	+-------------------+--------------+
	| c71_0             | main_timer2  |
	+-------------------+--------------+

Fixes: 7f209dd1267c ("arm64: dts: ti: k3-j721e: Add general purpose timers")
Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi | 29 +++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi
index cf606846e341..cef47c67493f 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi
@@ -569,6 +569,35 @@ &main_r5fss1 {
 	ti,cluster-mode = <0>;
 };
 
+/* Timers are used by Remoteproc firmware */
+&main_timer0 {
+	status = "reserved";
+};
+
+&main_timer1 {
+	status = "reserved";
+};
+
+&main_timer2 {
+	status = "reserved";
+};
+
+&main_timer12 {
+	status = "reserved";
+};
+
+&main_timer13 {
+	status = "reserved";
+};
+
+&main_timer14 {
+	status = "reserved";
+};
+
+&main_timer15 {
+	status = "reserved";
+};
+
 &main_r5fss0_core0 {
 	mboxes = <&mailbox0_cluster1 &mbox_main_r5fss0_core0>;
 	memory-region = <&main_r5fss0_core0_dma_memory_region>,
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH v4 3/7] arm64: dts: ti: k3-j721e-sk: Change timer nodes status to reserved
  2024-08-26 10:48 [PATCH v4 0/7] Reserve Timer Nodes to avoid clash with Remoteproc firmware Beleswar Padhi
  2024-08-26 10:48 ` [PATCH v4 1/7] arm64: dts: ti: k3-j7200-som-p0: Change timer nodes status to reserved Beleswar Padhi
  2024-08-26 10:48 ` [PATCH v4 2/7] arm64: dts: ti: k3-j721e-som-p0: " Beleswar Padhi
@ 2024-08-26 10:48 ` Beleswar Padhi
  2024-08-26 10:48 ` [PATCH v4 4/7] arm64: dts: ti: k3-j721s2-som-p0: " Beleswar Padhi
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 13+ messages in thread
From: Beleswar Padhi @ 2024-08-26 10:48 UTC (permalink / raw)
  To: nm, vigneshr, kristo, robh, krzk+dt, conor+dt
  Cc: u-kumar1, tony, bb, d-gole, afd, hnagalla, linux-arm-kernel,
	devicetree, linux-kernel

The remoteproc firmware like of R5F and DSPs in the MAIN voltage domain
use timers. Therefore, change the status of the timer nodes to
"reserved" to avoid any clash. Usage is described as below:

	+===================+==============+
	|  Remoteproc node  |  Timer Node  |
	+===================+==============+
	| main_r5fss0_core0 | main_timer12 |
	+-------------------+--------------+
	| main_r5fss0_core1 | main_timer13 |
	+-------------------+--------------+
	| main_r5fss1_core0 | main_timer14 |
	+-------------------+--------------+
	| main_r5fss1_core1 | main_timer15 |
	+-------------------+--------------+
	| c66_0             | main_timer0  |
	+-------------------+--------------+
	| c66_1             | main_timer1  |
	+-------------------+--------------+
	| c71_0             | main_timer2  |
	+-------------------+--------------+

Fixes: 7f209dd1267c ("arm64: dts: ti: k3-j721e: Add general purpose timers")
Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 29 ++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
index 1896218fe038..046267044e68 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
@@ -1319,6 +1319,35 @@ &main_r5fss1 {
 	ti,cluster-mode = <0>;
 };
 
+/* Timers are used by Remoteproc firmware */
+&main_timer0 {
+	status = "reserved";
+};
+
+&main_timer1 {
+	status = "reserved";
+};
+
+&main_timer2 {
+	status = "reserved";
+};
+
+&main_timer12 {
+	status = "reserved";
+};
+
+&main_timer13 {
+	status = "reserved";
+};
+
+&main_timer14 {
+	status = "reserved";
+};
+
+&main_timer15 {
+	status = "reserved";
+};
+
 &main_r5fss0_core0 {
 	mboxes = <&mailbox0_cluster1 &mbox_main_r5fss0_core0>;
 	memory-region = <&main_r5fss0_core0_dma_memory_region>,
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH v4 4/7] arm64: dts: ti: k3-j721s2-som-p0: Change timer nodes status to reserved
  2024-08-26 10:48 [PATCH v4 0/7] Reserve Timer Nodes to avoid clash with Remoteproc firmware Beleswar Padhi
                   ` (2 preceding siblings ...)
  2024-08-26 10:48 ` [PATCH v4 3/7] arm64: dts: ti: k3-j721e-sk: " Beleswar Padhi
@ 2024-08-26 10:48 ` Beleswar Padhi
  2024-08-26 10:48 ` [PATCH v4 5/7] arm64: dts: ti: k3-am68-sk-som: " Beleswar Padhi
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 13+ messages in thread
From: Beleswar Padhi @ 2024-08-26 10:48 UTC (permalink / raw)
  To: nm, vigneshr, kristo, robh, krzk+dt, conor+dt
  Cc: u-kumar1, tony, bb, d-gole, afd, hnagalla, linux-arm-kernel,
	devicetree, linux-kernel

The remoteproc firmware like of R5F and DSPs in the MAIN voltage domain
use timers. Therefore, change the status of the timer nodes to
"reserved" to avoid any clash. Usage is described as below:

	+===================+=============+
	|  Remoteproc node  | Timer Node  |
	+===================+=============+
	| main_r5fss0_core0 | main_timer2 |
	+-------------------+-------------+
	| main_r5fss0_core1 | main_timer3 |
	+-------------------+-------------+
	| main_r5fss1_core0 | main_timer4 |
	+-------------------+-------------+
	| main_r5fss1_core1 | main_timer5 |
	+-------------------+-------------+
	| c71_0             | main_timer0 |
	+-------------------+-------------+
	| c71_1             | main_timer1 |
	+-------------------+-------------+

Fixes: 835d04422f9d ("arm64: dts: ti: k3-j721s2: Add general purpose timers")
Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j721s2-som-p0.dtsi | 25 ++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-som-p0.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-som-p0.dtsi
index 92109b88e257..89252e4a5f1b 100644
--- a/arch/arm64/boot/dts/ti/k3-j721s2-som-p0.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721s2-som-p0.dtsi
@@ -524,6 +524,31 @@ &main_r5fss1 {
 	ti,cluster-mode = <0>;
 };
 
+/* Timers are used by Remoteproc firmware */
+&main_timer0 {
+	status = "reserved";
+};
+
+&main_timer1 {
+	status = "reserved";
+};
+
+&main_timer2 {
+	status = "reserved";
+};
+
+&main_timer3 {
+	status = "reserved";
+};
+
+&main_timer4 {
+	status = "reserved";
+};
+
+&main_timer5 {
+	status = "reserved";
+};
+
 &main_r5fss0_core0 {
 	mboxes = <&mailbox0_cluster1 &mbox_main_r5fss0_core0>;
 	memory-region = <&main_r5fss0_core0_dma_memory_region>,
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH v4 5/7] arm64: dts: ti: k3-am68-sk-som: Change timer nodes status to reserved
  2024-08-26 10:48 [PATCH v4 0/7] Reserve Timer Nodes to avoid clash with Remoteproc firmware Beleswar Padhi
                   ` (3 preceding siblings ...)
  2024-08-26 10:48 ` [PATCH v4 4/7] arm64: dts: ti: k3-j721s2-som-p0: " Beleswar Padhi
@ 2024-08-26 10:48 ` Beleswar Padhi
  2024-08-26 10:48 ` [PATCH v4 6/7] arm64: dts: ti: k3-j784s4-evm: " Beleswar Padhi
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 13+ messages in thread
From: Beleswar Padhi @ 2024-08-26 10:48 UTC (permalink / raw)
  To: nm, vigneshr, kristo, robh, krzk+dt, conor+dt
  Cc: u-kumar1, tony, bb, d-gole, afd, hnagalla, linux-arm-kernel,
	devicetree, linux-kernel

The remoteproc firmware like of R5F and DSPs in the MAIN voltage domain
use timers. Therefore, change the status of the timer nodes to
"reserved" to avoid any clash. Usage is described as below:

	+===================+=============+
	|  Remoteproc node  | Timer Node  |
	+===================+=============+
	| main_r5fss0_core0 | main_timer2 |
	+-------------------+-------------+
	| main_r5fss0_core1 | main_timer3 |
	+-------------------+-------------+
	| main_r5fss1_core0 | main_timer4 |
	+-------------------+-------------+
	| main_r5fss1_core1 | main_timer5 |
	+-------------------+-------------+
	| c71_0             | main_timer0 |
	+-------------------+-------------+
	| c71_1             | main_timer1 |
	+-------------------+-------------+

Fixes: 835d04422f9d ("arm64: dts: ti: k3-j721s2: Add general purpose timers")
Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi | 25 ++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi b/arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi
index 4800f956bf12..b1f7c904ad94 100644
--- a/arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi
@@ -310,6 +310,31 @@ &main_r5fss1 {
 	ti,cluster-mode = <0>;
 };
 
+/* Timers are used by Remoteproc firmware */
+&main_timer0 {
+	status = "reserved";
+};
+
+&main_timer1 {
+	status = "reserved";
+};
+
+&main_timer2 {
+	status = "reserved";
+};
+
+&main_timer3 {
+	status = "reserved";
+};
+
+&main_timer4 {
+	status = "reserved";
+};
+
+&main_timer5 {
+	status = "reserved";
+};
+
 &main_r5fss0_core0 {
 	mboxes = <&mailbox0_cluster1 &mbox_main_r5fss0_core0>;
 	memory-region = <&main_r5fss0_core0_dma_memory_region>,
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH v4 6/7] arm64: dts: ti: k3-j784s4-evm: Change timer nodes status to reserved
  2024-08-26 10:48 [PATCH v4 0/7] Reserve Timer Nodes to avoid clash with Remoteproc firmware Beleswar Padhi
                   ` (4 preceding siblings ...)
  2024-08-26 10:48 ` [PATCH v4 5/7] arm64: dts: ti: k3-am68-sk-som: " Beleswar Padhi
@ 2024-08-26 10:48 ` Beleswar Padhi
  2024-08-26 10:48 ` [PATCH v4 7/7] arm64: dts: ti: k3-am69-sk: " Beleswar Padhi
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 13+ messages in thread
From: Beleswar Padhi @ 2024-08-26 10:48 UTC (permalink / raw)
  To: nm, vigneshr, kristo, robh, krzk+dt, conor+dt
  Cc: u-kumar1, tony, bb, d-gole, afd, hnagalla, linux-arm-kernel,
	devicetree, linux-kernel

The remoteproc firmware like of R5F and DSPs in the MAIN voltage domain
use timers. Therefore, change the status of the timer nodes to
"reserved" to avoid any clash. Usage is described as below:

	+===================+=============+
	|  Remoteproc node  | Timer Node  |
	+===================+=============+
	| main_r5fss0_core0 | main_timer4 |
	+-------------------+-------------+
	| main_r5fss0_core1 | main_timer5 |
	+-------------------+-------------+
	| main_r5fss1_core0 | main_timer6 |
	+-------------------+-------------+
	| main_r5fss1_core1 | main_timer7 |
	+-------------------+-------------+
	| main_r5fss2_core0 | main_timer8 |
	+-------------------+-------------+
	| main_r5fss2_core1 | main_timer9 |
	+-------------------+-------------+
	| c71_0             | main_timer0 |
	+-------------------+-------------+
	| c71_1             | main_timer1 |
	+-------------------+-------------+
	| c71_2             | main_timer2 |
	+-------------------+-------------+
	| c71_3             | main_timer3 |
	+-------------------+-------------+

Fixes: 833377cf858b ("arm64: dts: ti: k3-j784s4: Add general purpose timers")
Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 41 ++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
index 58d550a1ac17..473cb2833783 100644
--- a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
@@ -1166,6 +1166,47 @@ &main_r5fss2 {
 	ti,cluster-mode = <0>;
 };
 
+/* Timers are used by Remoteproc firmware */
+&main_timer0 {
+	status = "reserved";
+};
+
+&main_timer1 {
+	status = "reserved";
+};
+
+&main_timer2 {
+	status = "reserved";
+};
+
+&main_timer3 {
+	status = "reserved";
+};
+
+&main_timer4 {
+	status = "reserved";
+};
+
+&main_timer5 {
+	status = "reserved";
+};
+
+&main_timer6 {
+	status = "reserved";
+};
+
+&main_timer7 {
+	status = "reserved";
+};
+
+&main_timer8 {
+	status = "reserved";
+};
+
+&main_timer9 {
+	status = "reserved";
+};
+
 &main_r5fss0_core0 {
 	status = "okay";
 	mboxes = <&mailbox0_cluster1 &mbox_main_r5fss0_core0>;
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH v4 7/7] arm64: dts: ti: k3-am69-sk: Change timer nodes status to reserved
  2024-08-26 10:48 [PATCH v4 0/7] Reserve Timer Nodes to avoid clash with Remoteproc firmware Beleswar Padhi
                   ` (5 preceding siblings ...)
  2024-08-26 10:48 ` [PATCH v4 6/7] arm64: dts: ti: k3-j784s4-evm: " Beleswar Padhi
@ 2024-08-26 10:48 ` Beleswar Padhi
  2024-08-26 10:57 ` [PATCH v4 0/7] Reserve Timer Nodes to avoid clash with Remoteproc firmware Beleswar Prasad Padhi
  2024-08-28 18:58 ` Nishanth Menon
  8 siblings, 0 replies; 13+ messages in thread
From: Beleswar Padhi @ 2024-08-26 10:48 UTC (permalink / raw)
  To: nm, vigneshr, kristo, robh, krzk+dt, conor+dt
  Cc: u-kumar1, tony, bb, d-gole, afd, hnagalla, linux-arm-kernel,
	devicetree, linux-kernel

The remoteproc firmware like of R5F and DSPs in the MAIN voltage domain
use timers. Therefore, change the status of the timer nodes to
"reserved" to avoid any clash. Usage is described as below:

	+===================+=============+
	|  Remoteproc node  | Timer Node  |
	+===================+=============+
	| main_r5fss0_core0 | main_timer4 |
	+-------------------+-------------+
	| main_r5fss0_core1 | main_timer5 |
	+-------------------+-------------+
	| main_r5fss1_core0 | main_timer6 |
	+-------------------+-------------+
	| main_r5fss1_core1 | main_timer7 |
	+-------------------+-------------+
	| main_r5fss2_core0 | main_timer8 |
	+-------------------+-------------+
	| main_r5fss2_core1 | main_timer9 |
	+-------------------+-------------+
	| c71_0             | main_timer0 |
	+-------------------+-------------+
	| c71_1             | main_timer1 |
	+-------------------+-------------+
	| c71_2             | main_timer2 |
	+-------------------+-------------+
	| c71_3             | main_timer3 |
	+-------------------+-------------+

Fixes: 833377cf858b ("arm64: dts: ti: k3-j784s4: Add general purpose timers")
Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am69-sk.dts | 41 +++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am69-sk.dts b/arch/arm64/boot/dts/ti/k3-am69-sk.dts
index ad6570c51a68..1e36965a1403 100644
--- a/arch/arm64/boot/dts/ti/k3-am69-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am69-sk.dts
@@ -987,6 +987,47 @@ &main_r5fss1 {
 	ti,cluster-mode = <0>;
 };
 
+/* Timers are used by Remoteproc firmware */
+&main_timer0 {
+	status = "reserved";
+};
+
+&main_timer1 {
+	status = "reserved";
+};
+
+&main_timer2 {
+	status = "reserved";
+};
+
+&main_timer3 {
+	status = "reserved";
+};
+
+&main_timer4 {
+	status = "reserved";
+};
+
+&main_timer5 {
+	status = "reserved";
+};
+
+&main_timer6 {
+	status = "reserved";
+};
+
+&main_timer7 {
+	status = "reserved";
+};
+
+&main_timer8 {
+	status = "reserved";
+};
+
+&main_timer9 {
+	status = "reserved";
+};
+
 &main_r5fss2 {
 	ti,cluster-mode = <0>;
 };
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: [PATCH v4 1/7] arm64: dts: ti: k3-j7200-som-p0: Change timer nodes status to reserved
  2024-08-26 10:48 ` [PATCH v4 1/7] arm64: dts: ti: k3-j7200-som-p0: Change timer nodes status to reserved Beleswar Padhi
@ 2024-08-26 10:54   ` Krzysztof Kozlowski
  2024-08-26 12:37     ` Krzysztof Kozlowski
  0 siblings, 1 reply; 13+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-26 10:54 UTC (permalink / raw)
  To: Beleswar Padhi, nm, vigneshr, kristo, robh, krzk+dt, conor+dt
  Cc: u-kumar1, tony, bb, d-gole, afd, hnagalla, linux-arm-kernel,
	devicetree, linux-kernel

On 26/08/2024 12:48, Beleswar Padhi wrote:
> The remoteproc firmware of R5F in the MAIN voltage domain use timers.
> Therefore, change the status of the timer nodes to "reserved" to avoid
> any clash. Usage is described as below:
> 
> 	+===================+==========================+
> 	|  Remoteproc node  |        Timer Node        |
> 	+===================+==========================+
> 	| main_r5fss0_core0 | main_timer0, main_timer2 |
> 	+-------------------+--------------------------+
> 	| main_r5fss0_core1 | main_timer1              |
> 	+-------------------+--------------------------+
> 
> Fixes: c8a28ed4837c ("arm64: dts: ti: k3-j7200: Add general purpose timers")
> Signed-off-by: Beleswar Padhi <b-padhi@ti.com>

You keep sending the same. Where is the changelog? Why so many same
patchsets? Why so many resends without changes?

Best regards,
Krzysztof



^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v4 0/7] Reserve Timer Nodes to avoid clash with Remoteproc firmware
  2024-08-26 10:48 [PATCH v4 0/7] Reserve Timer Nodes to avoid clash with Remoteproc firmware Beleswar Padhi
                   ` (6 preceding siblings ...)
  2024-08-26 10:48 ` [PATCH v4 7/7] arm64: dts: ti: k3-am69-sk: " Beleswar Padhi
@ 2024-08-26 10:57 ` Beleswar Prasad Padhi
  2024-08-28 18:58 ` Nishanth Menon
  8 siblings, 0 replies; 13+ messages in thread
From: Beleswar Prasad Padhi @ 2024-08-26 10:57 UTC (permalink / raw)
  To: nm, vigneshr, kristo, robh, krzk+dt, conor+dt
  Cc: u-kumar1, tony, bb, d-gole, afd, hnagalla, linux-arm-kernel,
	devicetree, linux-kernel


On 26/08/24 16:18, Beleswar Padhi wrote:
> The remoteproc firmware like of R5F and DSPs in the MAIN voltage domain
> use timers. At the same time, if Linux probes the timers, some
> instability is observed while booting remote cores. Therefore, change
> the status of the timer nodes to "reserved" to avoid any clash.
>
> NOTE: This series has been rebased on top of a sibling series[0] as both of them
> introduce changes in the same files. Thus, please apply [0] before applying this
> series.
>
> [0]: https://lore.kernel.org/all/20240826093024.1183540-1-b-padhi@ti.com/
>
> v4: Changelog:
> 1) Refactored changes from {}-common-proc-board.dts to {}-som.dtsi to put all
> remoteproc related changes at one place as remotecores were getting enabled at
> {}-som.dtsi file.
> 2) Rebased this series on top of [0].
>
> * Nishanth:
> 1) Fixed $subject line for all patches to include the board level files where
> the changes were applied instead of the SoC level files.
> 2) Applied these timer fixes to J721E-SK, AM68-SK and AM69-SK boards as well.


Adding to the changelog,
* Udit:
1) Dropped patch "arm64: dts: ti: k3-j722s: Change timer nodes status to 
reserved" in v4 revision as remoteproc support (DT) has not been 
upstreamed yet for j722s-evm platform.

Apologies for missing this changelog in the cover-letter itself.

>
> Link to v3:
> https://lore.kernel.org/all/20240816073908.2343650-1-b-padhi@ti.com/
>
> v3: Changelog:
> * Udit
> 1) j7200: Updated commit message description to remove DSPs as the SoC does not
> have one.
> 2) j722s: Updated the correct commit for "Fixes:" tag which introduced the bug.
> 3) For entire series, removed comment about timer usage by R5fs in the MCU
> voltage domain as those are used by Device Manager firmware to get SoC
> functional.
>
> Link to v2:
> https://lore.kernel.org/all/20240814104151.2038457-1-b-padhi@ti.com/
>
> v2: Changelog:
> - Split the changes into individual patches for each SoC to tag the
>    correct offending commit for "Fixes:" tag.
>
> * Udit
> 1) Add the correct clashing timer nodes for J7200 SoC.
> 2) Port these changes to board level dts files instead of SoC level dtsi files.
>
> Link to v1:
> https://lore.kernel.org/all/20240607105559.771080-1-b-padhi@ti.com/
>
> Beleswar Padhi (7):
>    arm64: dts: ti: k3-j7200-som-p0: Change timer nodes status to reserved
>    arm64: dts: ti: k3-j721e-som-p0: Change timer nodes status to reserved
>    arm64: dts: ti: k3-j721e-sk: Change timer nodes status to reserved
>    arm64: dts: ti: k3-j721s2-som-p0: Change timer nodes status to
>      reserved
>    arm64: dts: ti: k3-am68-sk-som: Change timer nodes status to reserved
>    arm64: dts: ti: k3-j784s4-evm: Change timer nodes status to reserved
>    arm64: dts: ti: k3-am69-sk: Change timer nodes status to reserved
>
>   arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi   | 25 ++++++++++++
>   arch/arm64/boot/dts/ti/k3-am69-sk.dts        | 41 ++++++++++++++++++++
>   arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi  | 13 +++++++
>   arch/arm64/boot/dts/ti/k3-j721e-sk.dts       | 29 ++++++++++++++
>   arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi  | 29 ++++++++++++++
>   arch/arm64/boot/dts/ti/k3-j721s2-som-p0.dtsi | 25 ++++++++++++
>   arch/arm64/boot/dts/ti/k3-j784s4-evm.dts     | 41 ++++++++++++++++++++
>   7 files changed, 203 insertions(+)
>


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v4 1/7] arm64: dts: ti: k3-j7200-som-p0: Change timer nodes status to reserved
  2024-08-26 10:54   ` Krzysztof Kozlowski
@ 2024-08-26 12:37     ` Krzysztof Kozlowski
  2024-08-27  4:54       ` Beleswar Prasad Padhi
  0 siblings, 1 reply; 13+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-26 12:37 UTC (permalink / raw)
  To: Beleswar Padhi, nm, vigneshr, kristo, robh, krzk+dt, conor+dt
  Cc: u-kumar1, tony, bb, d-gole, afd, hnagalla, linux-arm-kernel,
	devicetree, linux-kernel

On 26/08/2024 12:54, Krzysztof Kozlowski wrote:
> On 26/08/2024 12:48, Beleswar Padhi wrote:
>> The remoteproc firmware of R5F in the MAIN voltage domain use timers.
>> Therefore, change the status of the timer nodes to "reserved" to avoid
>> any clash. Usage is described as below:
>>
>> 	+===================+==========================+
>> 	|  Remoteproc node  |        Timer Node        |
>> 	+===================+==========================+
>> 	| main_r5fss0_core0 | main_timer0, main_timer2 |
>> 	+-------------------+--------------------------+
>> 	| main_r5fss0_core1 | main_timer1              |
>> 	+-------------------+--------------------------+
>>
>> Fixes: c8a28ed4837c ("arm64: dts: ti: k3-j7200: Add general purpose timers")
>> Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
> 
> You keep sending the same. Where is the changelog? Why so many same
> patchsets? Why so many resends without changes?

OK, now cover letter came and I see the changelog. Some hickup on mail
servers.

Best regards,
Krzysztof



^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v4 1/7] arm64: dts: ti: k3-j7200-som-p0: Change timer nodes status to reserved
  2024-08-26 12:37     ` Krzysztof Kozlowski
@ 2024-08-27  4:54       ` Beleswar Prasad Padhi
  0 siblings, 0 replies; 13+ messages in thread
From: Beleswar Prasad Padhi @ 2024-08-27  4:54 UTC (permalink / raw)
  To: Krzysztof Kozlowski, nm, vigneshr, kristo, robh, krzk+dt,
	conor+dt
  Cc: u-kumar1, tony, bb, d-gole, afd, hnagalla, linux-arm-kernel,
	devicetree, linux-kernel


On 26/08/24 18:07, Krzysztof Kozlowski wrote:
> On 26/08/2024 12:54, Krzysztof Kozlowski wrote:
>> On 26/08/2024 12:48, Beleswar Padhi wrote:
>>> The remoteproc firmware of R5F in the MAIN voltage domain use timers.
>>> Therefore, change the status of the timer nodes to "reserved" to avoid
>>> any clash. Usage is described as below:
>>>
>>> 	+===================+==========================+
>>> 	|  Remoteproc node  |        Timer Node        |
>>> 	+===================+==========================+
>>> 	| main_r5fss0_core0 | main_timer0, main_timer2 |
>>> 	+-------------------+--------------------------+
>>> 	| main_r5fss0_core1 | main_timer1              |
>>> 	+-------------------+--------------------------+
>>>
>>> Fixes: c8a28ed4837c ("arm64: dts: ti: k3-j7200: Add general purpose timers")
>>> Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
>> You keep sending the same. Where is the changelog? Why so many same
>> patchsets? Why so many resends without changes?
> OK, now cover letter came and I see the changelog. Some hickup on mail
> servers.


I understand the mistake. From next time, will mention changelogs in 
patches as well as cover letter.

>
> Best regards,
> Krzysztof
>


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v4 0/7] Reserve Timer Nodes to avoid clash with Remoteproc firmware
  2024-08-26 10:48 [PATCH v4 0/7] Reserve Timer Nodes to avoid clash with Remoteproc firmware Beleswar Padhi
                   ` (7 preceding siblings ...)
  2024-08-26 10:57 ` [PATCH v4 0/7] Reserve Timer Nodes to avoid clash with Remoteproc firmware Beleswar Prasad Padhi
@ 2024-08-28 18:58 ` Nishanth Menon
  8 siblings, 0 replies; 13+ messages in thread
From: Nishanth Menon @ 2024-08-28 18:58 UTC (permalink / raw)
  To: vigneshr, kristo, robh, krzk+dt, conor+dt, Beleswar Padhi
  Cc: Nishanth Menon, u-kumar1, tony, bb, d-gole, afd, hnagalla,
	linux-arm-kernel, devicetree, linux-kernel

Hi Beleswar Padhi,

On Mon, 26 Aug 2024 16:18:13 +0530, Beleswar Padhi wrote:
> The remoteproc firmware like of R5F and DSPs in the MAIN voltage domain
> use timers. At the same time, if Linux probes the timers, some
> instability is observed while booting remote cores. Therefore, change
> the status of the timer nodes to "reserved" to avoid any clash.
> 
> NOTE: This series has been rebased on top of a sibling series[0] as both of them
> introduce changes in the same files. Thus, please apply [0] before applying this
> series.
> 
> [...]

I have applied the following to branch ti-k3-dts-next on [1].
Thank you!

[1/7] arm64: dts: ti: k3-j7200-som-p0: Change timer nodes status to reserved
      commit: f7d6dacb233e1fe7e99e766abddd2a0247957d80
[2/7] arm64: dts: ti: k3-j721e-som-p0: Change timer nodes status to reserved
      commit: 96b2d17bfe407faae341053e1f376c7429c03c22
[3/7] arm64: dts: ti: k3-j721e-sk: Change timer nodes status to reserved
      commit: a8d1241bd6e57add2807c3127f987f8929bb45a1
[4/7] arm64: dts: ti: k3-j721s2-som-p0: Change timer nodes status to reserved
      commit: 1cf3a036f91a2e5a6187f7cea8f9bfab1d9b504f
[5/7] arm64: dts: ti: k3-am68-sk-som: Change timer nodes status to reserved
      commit: ce25e4c7dff5c9a392ad5a5c38c4fc7031305cd2
[6/7] arm64: dts: ti: k3-j784s4-evm: Change timer nodes status to reserved
      commit: d8087ca36a29fa81cc80dd0a9b347b2877cc9b3d
[7/7] arm64: dts: ti: k3-am69-sk: Change timer nodes status to reserved
      commit: bdebd509e43e508386488ba7a35cf714dffa0088

I dropped the fixes tag while applying: the behavior you are
considering here is firmware specific. While I understand it is
important for the board, the reported "fixes" tag has nothing to do
with the board, it is a SoC timer introduction which is not where the
bug is.

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D



^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2024-08-28 18:59 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-26 10:48 [PATCH v4 0/7] Reserve Timer Nodes to avoid clash with Remoteproc firmware Beleswar Padhi
2024-08-26 10:48 ` [PATCH v4 1/7] arm64: dts: ti: k3-j7200-som-p0: Change timer nodes status to reserved Beleswar Padhi
2024-08-26 10:54   ` Krzysztof Kozlowski
2024-08-26 12:37     ` Krzysztof Kozlowski
2024-08-27  4:54       ` Beleswar Prasad Padhi
2024-08-26 10:48 ` [PATCH v4 2/7] arm64: dts: ti: k3-j721e-som-p0: " Beleswar Padhi
2024-08-26 10:48 ` [PATCH v4 3/7] arm64: dts: ti: k3-j721e-sk: " Beleswar Padhi
2024-08-26 10:48 ` [PATCH v4 4/7] arm64: dts: ti: k3-j721s2-som-p0: " Beleswar Padhi
2024-08-26 10:48 ` [PATCH v4 5/7] arm64: dts: ti: k3-am68-sk-som: " Beleswar Padhi
2024-08-26 10:48 ` [PATCH v4 6/7] arm64: dts: ti: k3-j784s4-evm: " Beleswar Padhi
2024-08-26 10:48 ` [PATCH v4 7/7] arm64: dts: ti: k3-am69-sk: " Beleswar Padhi
2024-08-26 10:57 ` [PATCH v4 0/7] Reserve Timer Nodes to avoid clash with Remoteproc firmware Beleswar Prasad Padhi
2024-08-28 18:58 ` Nishanth Menon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).