* [PATCH 1/2] ARM: ux500: Silence compiler warnings due to missing ux500_read_asicid() __init
@ 2013-06-04 15:36 Lee Jones
2013-06-04 15:36 ` [PATCH 2/2] ARM: ux500: Silence compiler warnings due to missing __cpuinitdata Lee Jones
2013-06-04 15:55 ` [PATCH 1/2] ARM: ux500: Silence compiler warnings due to missing ux500_read_asicid() __init Arnd Bergmann
0 siblings, 2 replies; 6+ messages in thread
From: Lee Jones @ 2013-06-04 15:36 UTC (permalink / raw)
To: linux-arm-kernel
WARNING: vmlinux.o(.text.unlikely+0x1e8): Section mismatch in reference from\
the function ux500_read_asicid() to the function .init.text:iotable_init()
The function ux500_read_asicid() references
the function __init iotable_init().
This is often because ux500_read_asicid lacks a __init
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
arch/arm/mach-ux500/id.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-ux500/id.c b/arch/arm/mach-ux500/id.c
index 0d33d1a..b16e7c1 100644
--- a/arch/arm/mach-ux500/id.c
+++ b/arch/arm/mach-ux500/id.c
@@ -21,7 +21,7 @@
struct dbx500_asic_id dbx500_id;
-static unsigned int ux500_read_asicid(phys_addr_t addr)
+static unsigned int __init ux500_read_asicid(phys_addr_t addr)
{
phys_addr_t base = addr & ~0xfff;
struct map_desc desc = {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] ARM: ux500: Silence compiler warnings due to missing __cpuinitdata
2013-06-04 15:36 [PATCH 1/2] ARM: ux500: Silence compiler warnings due to missing ux500_read_asicid() __init Lee Jones
@ 2013-06-04 15:36 ` Lee Jones
2013-06-04 15:57 ` Arnd Bergmann
2013-06-04 15:55 ` [PATCH 1/2] ARM: ux500: Silence compiler warnings due to missing ux500_read_asicid() __init Arnd Bergmann
1 sibling, 1 reply; 6+ messages in thread
From: Lee Jones @ 2013-06-04 15:36 UTC (permalink / raw)
To: linux-arm-kernel
WARNING: vmlinux.o(.text.unlikely+0x25c): Section mismatch in reference \
from the function write_pen_release() to the variable \
.cpuinit.data:pen_release
The function write_pen_release() references
the variable __cpuinitdata pen_release.
This is often because write_pen_release lacks a __cpuinitdata
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
arch/arm/mach-ux500/platsmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-ux500/platsmp.c b/arch/arm/mach-ux500/platsmp.c
index 14d9046..3a455d5 100644
--- a/arch/arm/mach-ux500/platsmp.c
+++ b/arch/arm/mach-ux500/platsmp.c
@@ -34,7 +34,7 @@ extern void u8500_secondary_startup(void);
* observers, irrespective of whether they're taking part in coherency
* or not. This is necessary for the hotplug code to work reliably.
*/
-static void write_pen_release(int val)
+static void __cpuinitdata write_pen_release(int val)
{
pen_release = val;
smp_wmb();
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] ARM: ux500: Silence compiler warnings due to missing __cpuinitdata
2013-06-04 15:36 ` [PATCH 2/2] ARM: ux500: Silence compiler warnings due to missing __cpuinitdata Lee Jones
@ 2013-06-04 15:57 ` Arnd Bergmann
2013-06-04 16:38 ` Lee Jones
0 siblings, 1 reply; 6+ messages in thread
From: Arnd Bergmann @ 2013-06-04 15:57 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday 04 June 2013 16:36:48 Lee Jones wrote:
> WARNING: vmlinux.o(.text.unlikely+0x25c): Section mismatch in reference \
> from the function write_pen_release() to the variable \
> .cpuinit.data:pen_release
> The function write_pen_release() references
> the variable __cpuinitdata pen_release.
> This is often because write_pen_release lacks a __cpuinitdata
>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
I don't see bug on my machine. Are you sure it's not already fixed in
a different way in linux-next?
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] ARM: ux500: Silence compiler warnings due to missing __cpuinitdata
2013-06-04 15:57 ` Arnd Bergmann
@ 2013-06-04 16:38 ` Lee Jones
0 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2013-06-04 16:38 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 04 Jun 2013, Arnd Bergmann wrote:
> On Tuesday 04 June 2013 16:36:48 Lee Jones wrote:
> > WARNING: vmlinux.o(.text.unlikely+0x25c): Section mismatch in reference \
> > from the function write_pen_release() to the variable \
> > .cpuinit.data:pen_release
> > The function write_pen_release() references
> > the variable __cpuinitdata pen_release.
> > This is often because write_pen_release lacks a __cpuinitdata
> >
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
>
> I don't see bug on my machine. Are you sure it's not already fixed in
> a different way in linux-next?
It's a possibility.
Basically I have a v3.10-rc3 kernel and I did:
`git checkout next/master -- scripts`
I assumed some extra checking appeared in the scripts directory, so I
just fixed the warnings and sent out a patch.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] ARM: ux500: Silence compiler warnings due to missing ux500_read_asicid() __init
2013-06-04 15:36 [PATCH 1/2] ARM: ux500: Silence compiler warnings due to missing ux500_read_asicid() __init Lee Jones
2013-06-04 15:36 ` [PATCH 2/2] ARM: ux500: Silence compiler warnings due to missing __cpuinitdata Lee Jones
@ 2013-06-04 15:55 ` Arnd Bergmann
2013-06-05 12:32 ` Linus Walleij
1 sibling, 1 reply; 6+ messages in thread
From: Arnd Bergmann @ 2013-06-04 15:55 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday 04 June 2013 16:36:47 Lee Jones wrote:
> WARNING: vmlinux.o(.text.unlikely+0x1e8): Section mismatch in reference from\
> the function ux500_read_asicid() to the function .init.text:iotable_init()
> The function ux500_read_asicid() references
> the function __init iotable_init().
> This is often because ux500_read_asicid lacks a __init
>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Acked-by: Arnd Bergmann <arnd@arndb.de>
This is also part of my other patch to ux500_read_asicid that
Linus just applied, but we could take yours for 3.10 if he thinks
it's important.
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] ARM: ux500: Silence compiler warnings due to missing ux500_read_asicid() __init
2013-06-04 15:55 ` [PATCH 1/2] ARM: ux500: Silence compiler warnings due to missing ux500_read_asicid() __init Arnd Bergmann
@ 2013-06-05 12:32 ` Linus Walleij
0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2013-06-05 12:32 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jun 4, 2013 at 5:55 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tuesday 04 June 2013 16:36:47 Lee Jones wrote:
>> WARNING: vmlinux.o(.text.unlikely+0x1e8): Section mismatch in reference from\
>> the function ux500_read_asicid() to the function .init.text:iotable_init()
>> The function ux500_read_asicid() references
>> the function __init iotable_init().
>> This is often because ux500_read_asicid lacks a __init
>>
>> Signed-off-by: Lee Jones <lee.jones@linaro.org>
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> This is also part of my other patch to ux500_read_asicid that
> Linus just applied, but we could take yours for 3.10 if he thinks
> it's important.
We don't need two patches conflicting about such small
things, so I'll drop this in favor of your patch.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-06-05 12:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-04 15:36 [PATCH 1/2] ARM: ux500: Silence compiler warnings due to missing ux500_read_asicid() __init Lee Jones
2013-06-04 15:36 ` [PATCH 2/2] ARM: ux500: Silence compiler warnings due to missing __cpuinitdata Lee Jones
2013-06-04 15:57 ` Arnd Bergmann
2013-06-04 16:38 ` Lee Jones
2013-06-04 15:55 ` [PATCH 1/2] ARM: ux500: Silence compiler warnings due to missing ux500_read_asicid() __init Arnd Bergmann
2013-06-05 12:32 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).