[PATCH 1/3] arm64: dts: rockchip: disable display subsystem for Radxa E52C

[PATCH 1/3] arm64: dts: rockchip: disable display subsystem for Radxa E52C

[Chukun Pan]

The Radxa E52C SBC do not have HDMI output, so disable
the display subsystem.

Fixes: 9be4171219b6 ("arm64: dts: rockchip: Add Radxa E52C")
Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
---
 arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
index e04f21d8c831..3b519be6e1ea 100644
--- a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
@@ -207,6 +207,10 @@ &cpu_l3 {
 	cpu-supply = <&vdd_cpu_lit_s0>;
 };
 
+&display_subsystem {
+	status = "disabled";
+};
+
 &i2c0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&i2c0m2_xfer>;
-- 
2.25.1

[PATCH 2/3] arm64: dts: rockchip: mark eeprom as read-only for Radxa E52C

[Chukun Pan]

The eeprom on the Radxa E52C SBC contains manufacturer data
such as the mac address, so it should be marked as read-only.

Fixes: 9be4171219b6 ("arm64: dts: rockchip: Add Radxa E52C")
Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
---
 arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
index 3b519be6e1ea..fe48a0942a57 100644
--- a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
@@ -254,6 +254,7 @@ eeprom@50 {
 		compatible = "belling,bl24c16a", "atmel,24c16";
 		reg = <0x50>;
 		pagesize = <16>;
+		read-only;
 		vcc-supply = <&vcc_3v3_pmu>;
 	};
 };
-- 
2.25.1

[PATCH 3/3] arm64: dts: rockchip: improve LED config for for Radxa E52C

[Chukun Pan]

The NICs have default-trigger of "netdev" in order to show up as
LAN/WAN connected, so their default-state should be set to "off".

Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
---
 arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
index fe48a0942a57..1883bd183396 100644
--- a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
@@ -71,7 +71,7 @@ leds-1 {
 
 		led-1 {
 			color = <LED_COLOR_ID_GREEN>;
-			default-state = "on";
+			default-state = "off";
 			function = LED_FUNCTION_LAN;
 			linux,default-trigger = "netdev";
 			pwms = <&pwm14 0 1000000 PWM_POLARITY_INVERTED>;
@@ -80,7 +80,7 @@ led-1 {
 
 		led-2 {
 			color = <LED_COLOR_ID_GREEN>;
-			default-state = "on";
+			default-state = "off";
 			function = LED_FUNCTION_WAN;
 			linux,default-trigger = "netdev";
 			pwms = <&pwm11 0 1000000 PWM_POLARITY_INVERTED>;
-- 
2.25.1

Re: [PATCH 1/3] arm64: dts: rockchip: disable display subsystem for Radxa E52C

[Heiko Stübner]

Am Sonntag, 10. August 2025, 12:00:18 Mitteleuropäische Sommerzeit schrieb Chukun Pan:
> The Radxa E52C SBC do not have HDMI output, so disable
> the display subsystem.
> 
> Fixes: 9be4171219b6 ("arm64: dts: rockchip: Add Radxa E52C")
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>

What actual problem does this fix?

For example we also enable on-soc iommus all the time, because they're on
the soc and don't need board-level properties.

The "display-subsystem" without users looks mostly in the same spot.

So I do expect a description of what proplem gets fixed that this needs
to be disabled.

Thanks
Heiko

> ---
>  arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> index e04f21d8c831..3b519be6e1ea 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> @@ -207,6 +207,10 @@ &cpu_l3 {
>  	cpu-supply = <&vdd_cpu_lit_s0>;
>  };
>  
> +&display_subsystem {
> +	status = "disabled";
> +};
> +
>  &i2c0 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&i2c0m2_xfer>;
> 

Re: (subset) [PATCH 1/3] arm64: dts: rockchip: disable display subsystem for Radxa E52C

[Heiko Stuebner]

On Sun, 10 Aug 2025 18:00:18 +0800, Chukun Pan wrote:
> The Radxa E52C SBC do not have HDMI output, so disable
> the display subsystem.
> 
> 

Applied, thanks!

[2/3] arm64: dts: rockchip: mark eeprom as read-only for Radxa E52C
      commit: f18c9e79bbe65627805fff6aac3ea96b6b55b53d
[3/3] arm64: dts: rockchip: improve LED config for for Radxa E52C
      commit: 6f36b1fdb80dd1fdd24742af4ca435f76f73dfe9

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

Re: [PATCH 1/3] arm64: dts: rockchip: disable display subsystem for Radxa E52C

[Chukun Pan]

Hi,

> What actual problem does this fix?
>
> For example we also enable on-soc iommus all the time, because they're
> on the soc and don't need board-level properties.
>
> The "display-subsystem" without users looks mostly in the same spot.
>
> So I do expect a description of what problem gets fixed that this needs
> to be disabled.

Disable the display-subsystem to remove this error log:
[    1.382440] rockchip-drm display-subsystem: [drm:0xffffa3985873555c] *ERROR* No available vop found for display-subsystem.

I will improve the commit message in v2. Do I need to remove the Fixes tag?

Thanks,
Chukun

--
2.25.1

Re: [PATCH 1/3] arm64: dts: rockchip: disable display subsystem for Radxa E52C

[Heiko Stübner]

Hi,

Am Montag, 11. August 2025, 15:01:08 Mitteleuropäische Sommerzeit schrieb Chukun Pan:
> > What actual problem does this fix?
> >
> > For example we also enable on-soc iommus all the time, because they're
> > on the soc and don't need board-level properties.
> >
> > The "display-subsystem" without users looks mostly in the same spot.
> >
> > So I do expect a description of what problem gets fixed that this needs
> > to be disabled.
> 
> Disable the display-subsystem to remove this error log:
> [    1.382440] rockchip-drm display-subsystem: [drm:0xffffa3985873555c] *ERROR* No available vop found for display-subsystem.

ok, that makes sense then

> I will improve the commit message in v2. Do I need to remove the Fixes tag?

Nope, please keep the fixes tag

Thanks
Heiko