From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9E69C433EF for ; Wed, 9 Feb 2022 10:24:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4tpSGF87DwPheeI61++BUbpi2/p6XQKkeGCuNxaQ5rA=; b=l8Id9F9i6qxbHf mk8tOt8Kz2Lom47UP7kcGFF4m1QbTj3G+dp+kekg/GTeLPog4CA44Qar6AQPqO84vlfbysnE9OItH CXOa2tKnGOZyT7CZJAyK0iTebgtLFna7gLrtHMqSdcK+Yal4CfpCI6nL3aEBKZymUdFUV7kGDAP8e UGtq4QJF1A8FbCJaFFyrpPGsOW0rPN2dtXnQ1+etXqJz0Kp/4Ys9Xjy4ETVEowTmApfZWBQpf1l/T /IXf4GsFzSAzDMssp0b9pZ/xy8l+iEL+mxS+0/ffG74NInF+WKHF6kdD+jQhXjuprqNh/5AjP8iDA rw5mloKpzQ0JZIicbWfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHk7U-00HDZB-22; Wed, 09 Feb 2022 10:22:41 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHjsF-00H6pL-AB; Wed, 09 Feb 2022 10:06:57 +0000 Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHjsD-0008UB-T1; Wed, 09 Feb 2022 11:06:53 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: dri-devel@lists.freedesktop.org, Sascha Hauer Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , Peter Geis , Douglas Anderson , Yakir Yang Subject: Re: [PATCH v5 12/23] drm/rockchip: dw_hdmi: Use auto-generated tables Date: Wed, 09 Feb 2022 11:06:52 +0100 Message-ID: <2784361.GuOZkLzhrA@diego> In-Reply-To: <20220209095350.2104049-13-s.hauer@pengutronix.de> References: <20220209095350.2104049-1-s.hauer@pengutronix.de> <20220209095350.2104049-13-s.hauer@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220209_020655_428422_D2355C21 X-CRM114-Status: GOOD ( 25.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Mittwoch, 9. Februar 2022, 10:53:39 CET schrieb Sascha Hauer: > From: Douglas Anderson > > The previous tables for mpll_cfg and curr_ctrl were created using the > 20-pages of example settings provided by the PHY vendor. Those > example settings weren't particularly dense, so there were places > where we were guessing what the settings would be for 10-bit and > 12-bit (not that we use those anyway). It was also always a lot of > extra work every time we wanted to add a new clock rate since we had > to cross-reference several tables. > > In I've gone through the work to figure > out how to generate this table automatically. Let's now use the > automatically generated table and then we'll never need to look at it > again. > > We only support 8-bit mode right now and only support a small number > of clock rates and and I've verified that the only 8-bit rate that was > affected was 148.5. That mode appears to have been wrong in the old > table. > > Signed-off-by: Douglas Anderson > Signed-off-by: Yakir Yang missing Signed-off-by: Sascha Hauer <...> > --- > > Notes: > Changes since v3: > - new patch > > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 130 +++++++++++--------- > 1 file changed, 69 insertions(+), 61 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c > index b9928e622adf..160107b333ef 100644 > --- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c > +++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c > @@ -87,80 +87,88 @@ struct rockchip_hdmi { > > static const struct dw_hdmi_mpll_config rockchip_mpll_cfg[] = { > { > - 27000000, { > - { 0x00b3, 0x0000}, > - { 0x2153, 0x0000}, > - { 0x40f3, 0x0000} > + 30666000, { > + { 0x00b3, 0x0000 }, > + { 0x2153, 0x0000 }, > + { 0x40f3, 0x0000 }, > }, > - }, { > - 36000000, { > - { 0x00b3, 0x0000}, > - { 0x2153, 0x0000}, > - { 0x40f3, 0x0000} > + }, { > + 36800000, { > + { 0x00b3, 0x0000 }, > + { 0x2153, 0x0000 }, > + { 0x40a2, 0x0001 }, > }, > - }, { > - 40000000, { > - { 0x00b3, 0x0000}, > - { 0x2153, 0x0000}, > - { 0x40f3, 0x0000} > + }, { > + 46000000, { > + { 0x00b3, 0x0000 }, > + { 0x2142, 0x0001 }, > + { 0x40a2, 0x0001 }, > }, > - }, { > - 54000000, { > - { 0x0072, 0x0001}, > - { 0x2142, 0x0001}, > - { 0x40a2, 0x0001}, > + }, { > + 61333000, { > + { 0x0072, 0x0001 }, > + { 0x2142, 0x0001 }, > + { 0x40a2, 0x0001 }, > }, > - }, { > - 65000000, { > - { 0x0072, 0x0001}, > - { 0x2142, 0x0001}, > - { 0x40a2, 0x0001}, > + }, { > + 73600000, { > + { 0x0072, 0x0001 }, > + { 0x2142, 0x0001 }, > + { 0x4061, 0x0002 }, > }, > - }, { > - 66000000, { > - { 0x013e, 0x0003}, > - { 0x217e, 0x0002}, > - { 0x4061, 0x0002} > + }, { > + 92000000, { > + { 0x0072, 0x0001 }, > + { 0x2145, 0x0002 }, > + { 0x4061, 0x0002 }, > }, > - }, { > - 74250000, { > - { 0x0072, 0x0001}, > - { 0x2145, 0x0002}, > - { 0x4061, 0x0002} > + }, { > + 122666000, { > + { 0x0051, 0x0002 }, > + { 0x2145, 0x0002 }, > + { 0x4061, 0x0002 }, > }, > - }, { > - 83500000, { > - { 0x0072, 0x0001}, > + }, { > + 147200000, { > + { 0x0051, 0x0002 }, > + { 0x2145, 0x0002 }, > + { 0x4064, 0x0003 }, > }, > - }, { > - 108000000, { > - { 0x0051, 0x0002}, > - { 0x2145, 0x0002}, > - { 0x4061, 0x0002} > + }, { > + 184000000, { > + { 0x0051, 0x0002 }, > + { 0x214c, 0x0003 }, > + { 0x4064, 0x0003 }, > }, > - }, { > - 106500000, { > - { 0x0051, 0x0002}, > - { 0x2145, 0x0002}, > - { 0x4061, 0x0002} > + }, { > + 226666000, { > + { 0x0040, 0x0003 }, > + { 0x214c, 0x0003 }, > + { 0x4064, 0x0003 }, > }, > - }, { > - 146250000, { > - { 0x0051, 0x0002}, > - { 0x2145, 0x0002}, > - { 0x4061, 0x0002} > + }, { > + 272000000, { > + { 0x0040, 0x0003 }, > + { 0x214c, 0x0003 }, > + { 0x5a64, 0x0003 }, > }, > - }, { > - 148500000, { > - { 0x0051, 0x0003}, > - { 0x214c, 0x0003}, > - { 0x4064, 0x0003} > + }, { > + 340000000, { > + { 0x0040, 0x0003 }, > + { 0x3b4c, 0x0003 }, > + { 0x5a64, 0x0003 }, > }, > - }, { > + }, { > + 600000000, { > + { 0x1a40, 0x0003 }, > + { 0x3b4c, 0x0003 }, > + { 0x5a64, 0x0003 }, > + }, > + }, { > ~0UL, { > - { 0x00a0, 0x000a }, > - { 0x2001, 0x000f }, > - { 0x4002, 0x000f }, > + { 0x0000, 0x0000 }, > + { 0x0000, 0x0000 }, > + { 0x0000, 0x0000 }, > }, > } > }; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel