From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0598C433F5 for ; Tue, 15 Feb 2022 06:24:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Vw4sjrz2akT9xQG4GRN1oekLva2+cx3izaNY1NrNVsg=; b=SYS/ctLJYZEZkn z1GtGKT+NUkqlnxPmAsQ2TQBBPFziWPwrKCOaHXSkG9HbnWtA9MSM9JkHPQ7W6M0sRHqWZtjmygVF dgBVAy3SFqL2cMbbzGbxo/Omo/YURh0kS3cPjTzSeozKMXH7HgRKGbrcoQh1A86c4csBqdrDsZI9k blKgXlm8Va87RhciNPfvI6ihOo706e9zdeMyWutMqwc34u8vWqlifsoFHAPeb+4llbeKw0q6T2beY xGy/MSUVLJdzgSCPOpt5N6EU7RlPgQkIWS0aZ81sHwtHPcP/pWIrQ5PNAxXMD8Bv42EcqaOq5cMpG 5QwKZC6/XcrTYY2LrYwA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJrEx-000bWB-RR; Tue, 15 Feb 2022 06:23:07 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJrEu-000bU0-Fo; Tue, 15 Feb 2022 06:23:05 +0000 X-UUID: a7328ac92f334962a464b62ff7d00178-20220214 X-UUID: a7328ac92f334962a464b62ff7d00178-20220214 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1526273963; Mon, 14 Feb 2022 23:22:59 -0700 Received: from mtkmbs07n1.mediatek.inc (172.21.101.16) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 14 Feb 2022 22:22:58 -0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 15 Feb 2022 14:22:57 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 15 Feb 2022 14:22:56 +0800 Message-ID: <278b72f20ba57a72be325ec27f40c6d28cdabf9d.camel@mediatek.com> Subject: Re: [PATCH v3 03/31] clk: mediatek: gate: Internalize clk implementation From: Chun-Jie Chen To: Chen-Yu Tsai , Stephen Boyd , Michael Turquette , Matthias Brugger CC: AngeloGioacchino Del Regno , Miles Chen , , , , Date: Tue, 15 Feb 2022 14:22:57 +0800 In-Reply-To: <20220208124034.414635-4-wenst@chromium.org> References: <20220208124034.414635-1-wenst@chromium.org> <20220208124034.414635-4-wenst@chromium.org> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220214_222304_567579_F136A1F7 X-CRM114-Status: GOOD ( 21.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2022-02-08 at 20:40 +0800, Chen-Yu Tsai wrote: > struct mtk_clk_gate and mtk_clk_register_gate() are not used outside > of > the gate clk library. Only the API that handles a list of clks is > used > by the individual platform clk drivers. > > Internalize the parts that aren't used outside of the implementation. > > Signed-off-by: Chen-Yu Tsai > Reviewed-by: Miles Chen > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> Reviewed-by: Chun-Jie Chen > --- > drivers/clk/mediatek/clk-gate.c | 35 ++++++++++++++++++++++--------- > -- > drivers/clk/mediatek/clk-gate.h | 31 ++--------------------------- > 2 files changed, 25 insertions(+), 41 deletions(-) > > diff --git a/drivers/clk/mediatek/clk-gate.c > b/drivers/clk/mediatek/clk-gate.c > index 54921768bfba..e51cfd8c653c 100644 > --- a/drivers/clk/mediatek/clk-gate.c > +++ b/drivers/clk/mediatek/clk-gate.c > @@ -11,11 +11,28 @@ > #include > #include > #include > +#include > +#include > #include > #include > +#include > > #include "clk-gate.h" > > +struct mtk_clk_gate { > + struct clk_hw hw; > + struct regmap *regmap; > + int set_ofs; > + int clr_ofs; > + int sta_ofs; > + u8 bit; > +}; > + > +static inline struct mtk_clk_gate *to_mtk_clk_gate(struct clk_hw > *hw) > +{ > + return container_of(hw, struct mtk_clk_gate, hw); > +} > + > static u32 mtk_get_clockgating(struct clk_hw *hw) > { > struct mtk_clk_gate *cg = to_mtk_clk_gate(hw); > @@ -140,17 +157,12 @@ const struct clk_ops > mtk_clk_gate_ops_no_setclr_inv = { > }; > EXPORT_SYMBOL_GPL(mtk_clk_gate_ops_no_setclr_inv); > > -struct clk *mtk_clk_register_gate( > - const char *name, > - const char *parent_name, > - struct regmap *regmap, > - int set_ofs, > - int clr_ofs, > - int sta_ofs, > - u8 bit, > - const struct clk_ops *ops, > - unsigned long flags, > - struct device *dev) > +static struct clk *mtk_clk_register_gate(const char *name, > + const char *parent_name, > + struct regmap *regmap, int > set_ofs, > + int clr_ofs, int sta_ofs, u8 > bit, > + const struct clk_ops *ops, > + unsigned long flags, struct > device *dev) > { > struct mtk_clk_gate *cg; > struct clk *clk; > @@ -180,7 +192,6 @@ struct clk *mtk_clk_register_gate( > > return clk; > } > -EXPORT_SYMBOL_GPL(mtk_clk_register_gate); > > int mtk_clk_register_gates_with_dev(struct device_node *node, > const struct mtk_gate *clks, int > num, > diff --git a/drivers/clk/mediatek/clk-gate.h > b/drivers/clk/mediatek/clk-gate.h > index 432b571d23b3..3d75521ba20c 100644 > --- a/drivers/clk/mediatek/clk-gate.h > +++ b/drivers/clk/mediatek/clk-gate.h > @@ -7,42 +7,15 @@ > #ifndef __DRV_CLK_GATE_H > #define __DRV_CLK_GATE_H > > -#include > #include > - > -struct clk; > - > -struct mtk_clk_gate { > - struct clk_hw hw; > - struct regmap *regmap; > - int set_ofs; > - int clr_ofs; > - int sta_ofs; > - u8 bit; > -}; > - > -static inline struct mtk_clk_gate *to_mtk_clk_gate(struct clk_hw > *hw) > -{ > - return container_of(hw, struct mtk_clk_gate, hw); > -} > +#include > +#include > > extern const struct clk_ops mtk_clk_gate_ops_setclr; > extern const struct clk_ops mtk_clk_gate_ops_setclr_inv; > extern const struct clk_ops mtk_clk_gate_ops_no_setclr; > extern const struct clk_ops mtk_clk_gate_ops_no_setclr_inv; > > -struct clk *mtk_clk_register_gate( > - const char *name, > - const char *parent_name, > - struct regmap *regmap, > - int set_ofs, > - int clr_ofs, > - int sta_ofs, > - u8 bit, > - const struct clk_ops *ops, > - unsigned long flags, > - struct device *dev); > - > struct mtk_gate_regs { > u32 sta_ofs; > u32 clr_ofs; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel