From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 2/7] mailbox: arm_mhu: add driver for ARM MHU controller
Date: Thu, 05 Feb 2015 12:43:09 +0100 [thread overview]
Message-ID: <2790199.44Rvt91EcZ@wuerfel> (raw)
In-Reply-To: <CAJe_ZhcXR4oaBKZx3n0ckCzXgbREoezUXjizJ09QXQVqEQ3G_g@mail.gmail.com>
On Thursday 05 February 2015 10:38:16 Jassi Brar wrote:
> Passing pointer to a structure on stack will be automatically punished
> as a random crash/behavior.
> We just need to make sure no client passes a value directly in 'void
> *data', right?
Yes.
>
> I know typedef's are frowned upon, but how bad is the following option?
> typedef void* mbox_data_info
> int mbox_send_message(struct mbox_chan *chan, mbox_data_info data);
I don't see how that would help. I believe typedefs for pointer types
are particularly bad because they hide what is going on. If we want to
enforce the use of pointers to point to data, having the pointer in
the function prototype should be enough as a hint to driver developers ;-)
Arnd
next prev parent reply other threads:[~2015-02-05 11:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 9:21 [PATCH v5 0/7] Support for Fujitsu MB86S7X SoCs Vincent Yang
2015-02-03 9:27 ` [PATCH v5 1/7] ARM: Add platform support " Vincent Yang
2015-02-03 9:29 ` [PATCH v5 2/7] mailbox: arm_mhu: add driver for ARM MHU controller Vincent Yang
2015-02-03 12:32 ` Russell King - ARM Linux
2015-02-03 14:39 ` Jassi Brar
2015-02-03 14:46 ` Russell King - ARM Linux
2015-02-03 15:25 ` Arnd Bergmann
2015-02-04 3:27 ` Jassi Brar
2015-02-04 10:29 ` Arnd Bergmann
2015-02-04 14:34 ` Jassi Brar
2015-02-04 14:48 ` Arnd Bergmann
2015-02-04 15:33 ` Jassi Brar
2015-02-04 16:42 ` Arnd Bergmann
2015-02-05 5:08 ` Jassi Brar
2015-02-05 11:43 ` Arnd Bergmann [this message]
[not found] ` <CAJe_Zhf_WuRK2EE0Sj9ksXDDe5VA=DJ+H3eS4YRKpDZLdRRfow@mail.gmail.com>
2015-02-05 12:08 ` Russell King - ARM Linux
2015-02-05 12:31 ` Arnd Bergmann
2015-02-05 14:50 ` Jassi Brar
2015-02-04 15:09 ` Russell King - ARM Linux
2015-02-03 9:30 ` [PATCH v5 3/7] ARM: MB86S7X: Add MCPM support Vincent Yang
2015-02-03 9:31 ` [PATCH v5 4/7] clk: Add clock driver for mb86s7x Vincent Yang
2015-02-03 9:32 ` [PATCH v5 5/7] dt: mb86s7x: add dt files for MB86S7x evbs Vincent Yang
2015-02-03 9:34 ` [PATCH v5 6/7] of: add Fujitsu vendor prefix Vincent Yang
2015-02-03 9:35 ` [PATCH v5 7/7] ARM: MB86S7x: Add configs Vincent Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2790199.44Rvt91EcZ@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox