From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A6CCC5478C for ; Thu, 22 Feb 2024 20:57:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9ZXwhajYLHlBhMOh2OdnrcA/VLHL/2m9ytvYEI0yFa4=; b=iMyRdIOLk0NrEI v5yoR8vgY8Vdal3OfCWdx1JONbVoQShBqngLrBrFe/4maFtkVc64E7ja7I5Kgi+OBfGpFTNI1yc/T XRUeZZbxB7AJNrDqWaNDt3h8ehEetU9uctQEcCD+c/27+U1hRUrbelMRRc1h6UPqtgFHUc4LBan9e Mh4lu+yOVv/5gXQR5xA3a3BFrJq5HjsF0p6/HN3gl3mCvzryl/peRHcni/iUefhAwj2rEg7QnONdM FggrjFba/C4qzP/VvXYcBQPFVxYz6I49yWhPF2vampUEC8tWdvFtCWaBZzH+hJbv06k5J6DU33pCd 8ObFnBEtoF1CI8QmB1Iw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdG7v-00000006ZCl-09if; Thu, 22 Feb 2024 20:57:07 +0000 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdG7s-00000006ZBZ-3K9o for linux-arm-kernel@lists.infradead.org; Thu, 22 Feb 2024 20:57:06 +0000 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-5640fef9fa6so106423a12.0 for ; Thu, 22 Feb 2024 12:57:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708635423; x=1709240223; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=k2R6exNFMuMyEP9Zs0TU701ZxYwzvvvAfOU9DIEkDzQ=; b=jjLsqTfCGQ6zFIX3nWk2Zd6iQWkfYrUGvhdRwkxhjQaIgOTCfit7YPyIcODkMJwmpi bQNXjkoCHuq2XpFhslRf3lVyxLlJebahsnxrqkvvOW+DLTdDRZDZrzOjWcTj8CaZ6Hdf kW7VswHHpSh3MVOzxBUST94NLQnxu/8Y5nFwLH/7xkX3UITzAe129Ev9xq9wmSwHesJe 0nSCZ1YVi1ZBIEvtc3M9bx58DiqPp4YLXece21HfAgOMa7fyCVHQIfIa7R+fbSaEqNx5 iyy5OBY+aDzOO6AwTu0Jseg/+EaexGVj5HU9HhXOMa+aW+aHLarOCDTEW1WdHGEbqM2S Eszg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708635423; x=1709240223; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k2R6exNFMuMyEP9Zs0TU701ZxYwzvvvAfOU9DIEkDzQ=; b=aMgQqREh4299qnqles/a0T8E56inOxpjTTalVnvyC6MVCbEQ2ltkgzULfyYKZzTmXF kIQtIL/spEOEukD4/NgUhzem6amDEJU50I6mFgH3EFzMZDLNuHSzUG5GjGAzdKwpn+TG pHxMVfzkAx+6UIxTHfv1Nzs3kTw8SZccDL+n+CfCefVbiX6CqxzyxW2Ez1a8lja8YlDP FDsUiDd6me1xbN4/cWgRyJUUYD/F7+tIrNzGDQW2+GKxd2Z7KmJA+v0wxyOL3+8i2gQU 9YBlmt3keYxj+3dyoietyRliRprQDT8ntEHXxnxcXteg7gpHsPgHeUQpDVLL6H7YU/eE uO+g== X-Forwarded-Encrypted: i=1; AJvYcCUrVXbVaz7OX4Uddet/6ez9+Ntgr4ys4n9dKhsw+7IQBKBUBIy1RILNP29XfWR706LM70FEdavoppCOJFQllK+QqU0DvR66TIKadBr6+dJ5bHpOArE= X-Gm-Message-State: AOJu0Yy2+jf+V7eADon3ndLkTrc5tMLOeraRyA4hyJ6fI5tf9UHHwi/5 1fWpLGb2o1FaoHgvb+vsPJ+j4yF5ertI1j+H55T/0MqTCzpyPMrR X-Google-Smtp-Source: AGHT+IE/qvrg3YIq3JMhwgKa7j4LV2SY69KS3EGu1YYakjYgPPsfh2dUaKoCvH0+xzFJkFJVYOeQJA== X-Received: by 2002:a50:cd58:0:b0:563:e5e0:85e1 with SMTP id d24-20020a50cd58000000b00563e5e085e1mr16447362edj.25.1708635422647; Thu, 22 Feb 2024 12:57:02 -0800 (PST) Received: from jernej-laptop.localnet (86-58-6-171.dynamic.telemach.net. [86.58.6.171]) by smtp.gmail.com with ESMTPSA id r21-20020a50d695000000b00563f3ee5003sm6120860edi.91.2024.02.22.12.57.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 12:57:02 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-kernel@vger.kernel.org, Aren Moynihan Cc: Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, Jean-Jacques Hiblot , Chen-Yu Tsai , Ondrej Jirman , linux-sunxi@lists.linux.dev, Lee Jones , Pavel Machek , linux-arm-kernel@lists.infradead.org, linux-leds@vger.kernel.org, Conor Dooley , Miles Alan , Samuel Holland , Aren Moynihan Subject: Re: [PATCH v2 4/4] arm64: dts: sun50i-a64-pinephone: change led type to status Date: Thu, 22 Feb 2024 21:57:00 +0100 Message-ID: <2792937.BEx9A2HvPv@jernej-laptop> In-Reply-To: <20240206185400.596979-4-aren@peacevolution.org> References: <20240206185400.596979-1-aren@peacevolution.org> <20240206185400.596979-4-aren@peacevolution.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240222_125704_879645_C1308E44 X-CRM114-Status: GOOD ( 20.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne torek, 06. februar 2024 ob 19:13:20 CET je Aren Moynihan napisal(a): > The status function is described in the documentation as being a rgb led > used for system notifications on phones[1][2]. This is exactly what this > led is used for on the PinePhone, so using status is probably more > accurate than indicator. > > 1: Documentation/leds/well-known-leds.txt > 2: include/dt-bindings/leds/common.h > > Signed-off-by: Aren Moynihan Sorry for late review. Please update subject in patches 2-3. Instead of "sun50i-a64-pinephone:" use "allwinner: pinephone:" (check commit history of sun50i-a64-pinephone.dtsi). Also rgb -> RGB, led -> LED. Last, please reword commit message to exclude links and just say DT bindings documentation. Note that I'll merge patches 2-3 once patch 1 is merged. Best regards, Jernej > --- > I can't find any documentation describing the indicator function, so > it's definitely less specific than status, but besides that I'm not sure > how it compares. Please ignore this patch if it's not useful. > > (no changes since v1) > > arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi > index e53e0d4579a7..6d327266e6cc 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi > @@ -61,7 +61,7 @@ led2: led-2 { > multi-led { > compatible = "leds-group-multicolor"; > color = ; > - function = LED_FUNCTION_INDICATOR; > + function = LED_FUNCTION_STATUS; > leds = <&led0>, <&led1>, <&led2>; > }; > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel