From: "Jernej Škrabec" <jernej.skrabec@siol.net>
To: "Clément Péron" <peron.clem@gmail.com>
Cc: devicetree <devicetree@vger.kernel.org>,
Maxime Ripard <maxime.ripard@bootlin.com>,
linux-sunxi@googlegroups.com,
linux-kernel <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org, Chen-Yu Tsai <wens@csie.org>,
Rob Herring <robh+dt@kernel.org>,
Jagan Teki <jagan@amarulasolutions.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Icenowy Zheng <icenowy@aosc.io>
Subject: Re: [PATCH v2 4/8] arm64: dts: allwinner: Add ARM Mali GPU node for H6
Date: Thu, 11 Apr 2019 17:23:25 +0200 [thread overview]
Message-ID: <2797515.ZAugZ1JPiN@jernej-laptop> (raw)
In-Reply-To: <CAJiuCcdo_WAP1_rOcqOcoNkt7rdGb3H_GVMN2DiZnvo_4c=7DA@mail.gmail.com>
Dne četrtek, 11. april 2019 ob 17:20:04 CEST je Clément Péron napisal(a):
> Hi,
>
> On Thu, 11 Apr 2019 at 17:05, Jernej Škrabec <jernej.skrabec@siol.net>
wrote:
> > Dne četrtek, 11. april 2019 ob 12:57:16 CEST je Clément Péron napisal(a):
> > > Add the mali gpu node to the H6 device-tree.
> > >
> > > Signed-off-by: Clément Péron <peron.clem@gmail.com>
> > > ---
> > >
> > > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 14 ++++++++++++++
> > > 1 file changed, 14 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
> > > b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi index
> > > e0dc4a05c1ba..196753110434 100644
> > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
> > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
> > > @@ -157,6 +157,20 @@
> > >
> > > allwinner,sram = <&ve_sram 1>;
> > >
> > > };
> > >
> > > + gpu: gpu@1800000 {
> > > + compatible = "allwinner,sun50i-h6-mali",
> > > + "arm,mali-t720";
> > > + reg = <0x01800000 0x4000>;
> > > + interrupts = <GIC_SPI 84
> >
> > IRQ_TYPE_LEVEL_HIGH>,
> >
> > > + <GIC_SPI 85
> >
> > IRQ_TYPE_LEVEL_HIGH>,
> >
> > > + <GIC_SPI 83
> >
> > IRQ_TYPE_LEVEL_HIGH>;
> >
> > > + interrupt-names = "job", "mmu", "gpu";
> > > + clocks = <&ccu CLK_GPU>, <&ccu CLK_BUS_GPU>;
> > > + clock-names = "core", "bus";
> > > + resets = <&ccu RST_BUS_GPU>;
> > > + status = "disabled";
> >
> > Usually self sufficient peripherals are enabled by default in DTSI.
>
> I follow the other Mali Midgard (rk3399, rk3288) syntax.
> But I think you're right here, will go for an update I think.
>
I quickly checked A64 and H5 DTSI and both have GPU enabled by default (status
property is not set).
Best regards,
Jernej
> Clement
>
> > > + };
> > > +
> > >
> > > syscon: syscon@3000000 {
> > >
> > > compatible = "allwinner,sun50i-h6-system-
> >
> > control",
> >
> > > "allwinner,sun50i-a64-
> >
> > system-control";
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-11 15:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 10:57 [PATCH v2 0/8] Add Allwinner H6 Mali Midgard GPU Clément Péron
2019-04-11 10:57 ` [PATCH v2 1/8] dt-bindings: gpu: mali-midgard: Add resets property Clément Péron
2019-04-11 10:57 ` [PATCH v2 2/8] dt-bindings: gpu: add bus clock for Mali Midgard GPUs Clément Péron
2019-04-11 12:30 ` Maxime Ripard
2019-04-11 12:45 ` Clément Péron
2019-04-11 10:57 ` [PATCH v2 3/8] dt-bindings: gpu: mali-midgard: Add h6 mali gpu compatible Clément Péron
2019-04-11 10:57 ` [PATCH v2 4/8] arm64: dts: allwinner: Add ARM Mali GPU node for H6 Clément Péron
2019-04-11 15:05 ` Jernej Škrabec
2019-04-11 15:20 ` Clément Péron
2019-04-11 15:23 ` Jernej Škrabec [this message]
2019-04-11 15:27 ` Maxime Ripard
2019-04-11 15:42 ` Jernej Škrabec
2019-04-11 15:50 ` Maxime Ripard
2019-04-11 16:24 ` Rob Herring
2019-04-11 10:57 ` [PATCH v2 5/8] arm64: dts: allwinner: Add mali GPU supply for Pine H64 Clément Péron
2019-04-11 10:57 ` [PATCH v2 6/8] arm64: dts: allwinner: Add mali GPU supply for Beelink GS1 Clément Péron
2019-04-11 10:57 ` [PATCH v2 7/8] arm64: dts: allwinner: Add mali GPU supply for OrangePi Boards Clément Péron
2019-04-11 10:57 ` [PATCH v2 8/8] arm64: dts: allwinner: Add mali GPU supply for OrangePi 3 Clément Péron
2019-04-11 12:32 ` [PATCH v2 0/8] Add Allwinner H6 Mali Midgard GPU Maxime Ripard
2019-04-11 15:01 ` Jernej Škrabec
2019-04-11 15:09 ` Clément Péron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2797515.ZAugZ1JPiN@jernej-laptop \
--to=jernej.skrabec@siol.net \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=icenowy@aosc.io \
--cc=jagan@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@bootlin.com \
--cc=peron.clem@gmail.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).