Re: [PATCH v5 4/8] thermal: amlogic: Add support for secure monitor calibration readout

[Neil Armstrong <neil.armstrong@linaro.org>]

On 5/6/26 17:45, Daniel Lezcano wrote:
> On 4/24/26 17:45, Ronald Claveau via B4 Relay wrote:
> 
> [ ... ]
> 
>> +static int amlogic_thermal_probe_sm(struct platform_device *pdev,
>> +                    struct amlogic_thermal *pdata)
>> +{
>> +    struct device *dev = &pdev->dev;
>> +    struct of_phandle_args ph_args;
>> +    int ret;
>> +
>> +    ret = of_parse_phandle_with_fixed_args(pdev->dev.of_node,
>> +                           "amlogic,secure-monitor",
>> +                           1, 0, &ph_args);
>> +    if (ret)
>> +        return ret;
>> +
>> +    if (!ph_args.np) {
>> +        dev_err(dev, "Failed to parse secure monitor phandle\n");
>> +        return -ENODEV;
>> +    }
>> +
>> +    pdata->sm_fw = meson_sm_get(ph_args.np);
>> +    of_node_put(ph_args.np);
>> +    if (!pdata->sm_fw) {
>> +        dev_err(dev, "Failed to get secure monitor firmware\n");
>> +        return -EPROBE_DEFER;
>> +    }
>> +
>> +    pdata->tsensor_id = ph_args.args[0];
>> +
>> +    return meson_sm_get_thermal_calib(pdata->sm_fw,
>> +                      &pdata->trim_info,
>> +                      pdata->tsensor_id);
> 
> This driver has a dependency on patch 2 and 3. Shall those being merged through the thermal tree ?

It's fine for me.

Neil

> 
> 
>> +}
> 
> 
> [ ... ]
>