From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: Baoquan He <bhe@redhat.com>, linux-kernel@vger.kernel.org
Cc: kexec@lists.infradead.org, x86@kernel.org,
linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
linux-sh@vger.kernel.org, linux-mips@vger.kernel.org,
linux-riscv@lists.infradead.org, loongarch@lists.linux.dev,
akpm@linux-foundation.org, ebiederm@xmission.com,
hbathini@linux.ibm.com, piliu@redhat.com,
viro@zeniv.linux.org.uk
Subject: Re: [PATCH linux-next v3 10/14] sh, crash: wrap crash dumping code into crash related ifdefs
Date: Wed, 24 Jan 2024 09:13:09 +0100 [thread overview]
Message-ID: <27d8aa3a9e604a7e45c87b7fbc5b1ec2a63f03e3.camel@physik.fu-berlin.de> (raw)
In-Reply-To: <20240124051254.67105-11-bhe@redhat.com>
Hello Baoquan,
On Wed, 2024-01-24 at 13:12 +0800, Baoquan He wrote:
> Now crash codes under kernel/ folder has been split out from kexec
> code, crash dumping can be separated from kexec reboot in config
> items on SuperH with some adjustments.
>
> wrap up crash dumping codes with CONFIG_CRASH_DUMP ifdeffery, and
> use IS_ENABLED(CONFIG_CRASH_RESERVE) check to decide if compiling
> in the crashkernel reservation code.
Comparing this to the patches, it seems you missed the first word
"Here". Either amend that or write the word "wrap" capitalized.
I would omit "Here" as it's not necessary and just start the
sentence with "Wrap".
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-01-24 8:13 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 5:12 [PATCH linux-next v3 00/14] Split crash out from kexec and clean up related config items Baoquan He
2024-01-24 5:12 ` [PATCH linux-next v3 01/14] kexec: split crashkernel reservation code out from crash_core.c Baoquan He
2024-01-28 1:28 ` Klara Modin
2024-01-29 1:57 ` Baoquan He
2024-01-24 5:12 ` [PATCH linux-next v3 02/14] crash: split vmcoreinfo exporting " Baoquan He
2024-03-25 8:24 ` Geert Uytterhoeven
2024-03-25 9:48 ` Baoquan He
2024-01-24 5:12 ` [PATCH linux-next v3 03/14] crash: remove dependency of FA_DUMP on CRASH_DUMP Baoquan He
2024-01-24 5:12 ` [PATCH linux-next v3 04/14] crash: split crash dumping code out from kexec_core.c Baoquan He
2024-01-24 5:12 ` [PATCH linux-next v3 05/14] crash: clean up kdump related config items Baoquan He
2024-08-22 7:33 ` John Paul Adrian Glaubitz
2024-08-22 9:17 ` Baoquan He
2024-08-22 9:37 ` John Paul Adrian Glaubitz
2024-08-23 0:04 ` Baoquan He
2024-08-23 0:41 ` Dave Vasilevsky
2024-08-23 1:58 ` Baoquan He
2024-08-23 7:16 ` John Paul Adrian Glaubitz
2024-08-23 11:58 ` Dave Vasilevsky
2024-08-23 12:05 ` Dave Vasilevsky
2024-01-24 5:12 ` [PATCH linux-next v3 06/14] x86, crash: wrap crash dumping code into crash related ifdefs Baoquan He
2024-01-24 23:02 ` Michael Kelley
2024-01-25 4:09 ` Baoquan He
2024-01-25 5:12 ` Michael Kelley
2024-01-25 9:17 ` Baoquan He
2024-01-25 15:30 ` Michael Kelley
2024-01-24 5:12 ` [PATCH linux-next v3 07/14] arm64, " Baoquan He
2024-01-24 5:12 ` [PATCH linux-next v3 08/14] ppc, crash: enforce KEXEC and KEXEC_FILE to select CRASH_DUMP Baoquan He
2024-01-24 5:12 ` [PATCH linux-next v3 09/14] s390, crash: wrap crash dumping code into crash related ifdefs Baoquan He
2024-01-24 5:12 ` [PATCH linux-next v3 10/14] sh, " Baoquan He
2024-01-24 8:13 ` John Paul Adrian Glaubitz [this message]
2024-01-24 14:38 ` Baoquan He
2024-01-24 5:12 ` [PATCH linux-next v3 11/14] mips, " Baoquan He
2024-01-24 5:12 ` [PATCH linux-next v3 12/14] riscv, " Baoquan He
2024-01-24 5:12 ` [PATCH linux-next v3 13/14] arm, " Baoquan He
2024-01-24 5:12 ` [PATCH linux-next v3 14/14] loongarch, " Baoquan He
2024-01-26 4:55 ` [PATCH linux-next v3 00/14] Split crash out from kexec and clean up related config items Nathan Chancellor
2024-01-26 6:07 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27d8aa3a9e604a7e45c87b7fbc5b1ec2a63f03e3.camel@physik.fu-berlin.de \
--to=glaubitz@physik.fu-berlin.de \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=ebiederm@xmission.com \
--cc=hbathini@linux.ibm.com \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=piliu@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).