From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11A66CDB474 for ; Thu, 12 Oct 2023 23:46:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:To:Cc:From:Subject:References: In-Reply-To:MIME-Version:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kocRrnNnHHaQI2hK9g9UPjuUCmUPdI4YrsWSAf+zPQo=; b=sh82aRA1gie+af +AhcKnBtsH5k00ifD1r2Y3vvT19U/3lk9w6PGVfKmRMvUlBorcFEsaz+DSTAtBeur6Q+luF3ww2y4 o0e96HY9tchfNvP/7Lyb3HsKuuL6vJ82cQtPCqznXAPIVR57x3xPbpjp6a9nFe57nIPX/L5v+yHU7 M8GGZRacpqh1aSCjhmTiZnJRFW6xXgCExIC7Vyh9GSRx/eO4Wr9Yr+jqAHZMnVEBJAtPp3hmQWYTa dbCNCZHeea2As7wkMcq2lnxLGhlpEdlRt/OSDe6c+61Z9HitJ9xcKRfsVwsTK1Wi99bPToo7e+zci bZLag/FlYexsKlmC2LGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qr5NR-0028fx-2L; Thu, 12 Oct 2023 23:46:01 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qr5NN-0028dM-1e for linux-arm-kernel@lists.infradead.org; Thu, 12 Oct 2023 23:45:59 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id BF237CE2C7F; Thu, 12 Oct 2023 23:45:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3051C433C7; Thu, 12 Oct 2023 23:45:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697154346; bh=tEqTqQdErxc85MNvTcwntt3VToH19q1ySiOXAqVp1bo=; h=In-Reply-To:References:Subject:From:List-Id:Cc:To:Date:From; b=GG2EZ8ChFoHokrcV6Aa/yS5dZwQ6qftFITMB/sAiBFdWBKu1rphruGzmWTSfihORm ug7zJ5TbSJ3viAbSO12SAVv8hCpfBfXlL5GSv+pGs3W7WaN+WInSdJsFpF32dJUSfy kBzle2OTVVao82RAf0QsU+LASfe8pvPYj2HUlnpm/NniYTezqOBCVoNGG5tdaS4TK5 /awHz9XUs1EIvahj2SquYubqoe/nUXWuzwC6YzOEJh8hh85zJgtsH4moR4BvsHWB+3 bBvmtIaFdEO6l6Vxa4S8nzgVx9TodDgQjo8Kgp6H5la1PXIzyfdhwSEEsGWEmR2rSK AGL6KPYmJNpog== Message-ID: <27e5de286fd0c209fc0540df7f77355b.sboyd@kernel.org> MIME-Version: 1.0 In-Reply-To: <20231011184823.443959-19-peter.griffin@linaro.org> References: <20231011184823.443959-1-peter.griffin@linaro.org> <20231011184823.443959-19-peter.griffin@linaro.org> Subject: Re: [PATCH v3 18/20] arm64: dts: google: Add initial Oriole/pixel 6 board support From: Stephen Boyd Cc: peter.griffin@linaro.org, tudor.ambarus@linaro.org, andre.draszik@linaro.org, semen.protsenko@linaro.org, saravanak@google.com, willmcvicker@google.com, soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org, kernel-team@android.com, linux-serial@vger.kernel.org To: Peter Griffin , arnd@arndb.de, catalin.marinas@arm.com, conor+dt@kernel.org, cw00.choi@samsung.com, gregkh@linuxfoundation.org, krzysztof.kozlowski+dt@linaro.org, linus.walleij@linaro.org, linux@roeck-us.net, mturquette@baylibre.com, olof@lixom.net, robh+dt@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com, will@kernel.org, wim@linux-watchdog.org Date: Thu, 12 Oct 2023 16:45:44 -0700 User-Agent: alot/0.10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231012_164557_732325_53063D75 X-CRM114-Status: GOOD ( 12.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Peter Griffin (2023-10-11 11:48:21) > diff --git a/arch/arm64/boot/dts/google/gs101-oriole.dts b/arch/arm64/boot/dts/google/gs101-oriole.dts > new file mode 100644 > index 000000000000..3bebca989d34 > --- /dev/null > +++ b/arch/arm64/boot/dts/google/gs101-oriole.dts > @@ -0,0 +1,79 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Oriole Device Tree > + * > + * Copyright 2021-2023 Google,LLC > + */ > + > +/dts-v1/; > +/plugin/; > + > +#include > +#include > +#include "gs101-pinctrl.h" > +#include "gs101.dtsi" > + > +/ { > + model = "Oriole"; > + compatible = "google,gs101-oriole", "google,gs101"; > + > + chosen { > + bootargs = "earlycon=exynos4210,mmio32,0x10A00000 console=ttySAC0"; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + pinctrl-names = "default"; > + pinctrl-0 = <&key_voldown &key_volup &key_power>; When a phandle starts an array presumably the next element after it is some cell or "argument" for that phandle. In this case, &key_voldown doesn't have any cells (there isn't a #pinctrl-cells property) so we typically write it like this pinctrl-0 = <&key_voldown>, <&key_volup>, <&key_power>; so that the reader doesn't think the phandles are related. In the DTB nothing is different from how you have it in this patch. This is a super nitpick! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel