From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 897DCC43334 for ; Tue, 19 Jul 2022 06:11:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O44z17CCkFPnpJ03dFqZJj3peC9KFzeH9Z49RqqtAVs=; b=KzJXeHC58WymCJ HVXklUZCZfQr1ilVvTOtCI+hkm6QgGw1byM0eeqfr0xHfTAoeyXUpmsXBvPeR5C1tJDPuhihh6W9X xzsPJMiABAl05z2DxvQe1OEryh4+W59tDv3oaQtYdNgtZ/qT4Lx6BarRjLw1JFlcL6suVCjuHQfef tMQze1qyTKdZz/ZDcmbrpHU1lhvm+9NkOpmO3hqcHnioIN8M9d8s3Fu1IY0ywu96t/3voVtNi0Ltt 2uUIZhxDs8mEbcdCVt2gypOfoC074QZyKAmmPz9Dvi/ii+BAIOc0rMNy62mKbxpZczRFY3Hs8bV/y v7Jqfbxc5tp6NNT1llRA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDgQW-005cKS-9x; Tue, 19 Jul 2022 06:09:48 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDgQS-005cIT-GS; Tue, 19 Jul 2022 06:09:45 +0000 X-UUID: 63f4317cbf1446cd93c71b210d183017-20220718 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=uScBq4Yl1Ck56/d2fzEHwnBVQDk5UP+kPLu5A0qdGms=; b=owcFtSYX8OgUMDkOiQmM2GZGaUF5xJ2ZfyDGH6udYeo2exLU2q+nG0HG88KmB4zC7NNkpq9AauZHDUeY0nV1h3B8HfSOEwYSmG7HC0ivxlgC6wVijuJ3EqanzVG2d+4iDr1lkkEfkv8gPdnWOXrK5fttHTrVWeY8DgqxCKRriZc=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.8,REQID:13a07f9e-b6dd-4173-a42d-54e7973818ce,OB:0,LO B:0,IP:0,URL:5,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:5 X-CID-META: VersionHash:0f94e32,CLOUDID:f042aa64-0b3f-4b2c-b3a6-ed5c044366a0,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:1,File:nil ,QS:nil,BEC:nil,COL:0 X-UUID: 63f4317cbf1446cd93c71b210d183017-20220718 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 661819556; Mon, 18 Jul 2022 23:09:33 -0700 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Tue, 19 Jul 2022 13:18:54 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Tue, 19 Jul 2022 13:18:54 +0800 Message-ID: <27fb716259fc88cba955691c246a6bdaf31b38d8.camel@mediatek.com> Subject: Re: [for-next][PATCH 13/23] USB: mtu3: tracing: Use the new __vstring() helper From: Chunfeng Yun To: Steven Rostedt CC: , Ingo Molnar , "Andrew Morton" , , , , Greg Kroah-Hartman Date: Tue, 19 Jul 2022 13:18:54 +0800 In-Reply-To: <20220715172423.6b57b9eb@gandalf.local.home> References: <20220714164256.403842845@goodmis.org> <20220714164330.311734558@goodmis.org> <962e59c25e981676014157cd111db9e16e237339.camel@mediatek.com> <20220715172423.6b57b9eb@gandalf.local.home> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220718_230944_575275_AFEA674F X-CRM114-Status: GOOD ( 15.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2022-07-15 at 17:24 -0400, Steven Rostedt wrote: > On Fri, 15 Jul 2022 18:01:44 +0800 > Chunfeng Yun wrote: > > > irq/254-1120100-137 [000] d..1. 266.629662: mtu3_log: > > 11201000.usb: ep0_state SETUPr-speed > > > > "r-speed" seems the remain of last log; > > I found an off-by-one bug in the vstring patch. I'll rebase, test and > try > again. > > In the mean time, care to add this on top to make sure it's fixed? > > Thanks! > > -- Steve > > diff --git a/include/linux/trace_events.h > b/include/linux/trace_events.h > index e6f8ba52a958..b18759a673c6 100644 > --- a/include/linux/trace_events.h > +++ b/include/linux/trace_events.h > @@ -922,16 +922,16 @@ perf_trace_buf_submit(void *raw_data, int size, > int rctx, u16 type, > * gcc warns that you can not use a va_list in an inlined > * function. But lets me make it into a macro :-/ > */ > -#define __trace_event_vstr_len(fmt, va) \ > -({ \ > - va_list __ap; \ > - int __ret; \ > - \ > - va_copy(__ap, *(va)); \ > - __ret = vsnprintf(NULL, 0, fmt, __ap); \ > - va_end(__ap); \ > - \ > - min(__ret, TRACE_EVENT_STR_MAX); \ > +#define __trace_event_vstr_len(fmt, va) \ > +({ \ > + va_list __ap; \ > + int __ret; \ > + \ > + va_copy(__ap, *(va)); \ > + __ret = vsnprintf(NULL, 0, fmt, __ap) + 1; \ It works fine now, thanks a lot > + va_end(__ap); \ > + \ > + min(__ret, TRACE_EVENT_STR_MAX); \ > }) > > #endif /* _LINUX_TRACE_EVENT_H */ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel