From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22CE6C433F5 for ; Thu, 25 Nov 2021 22:21:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GRC5wti3UELnZxIwTOXH+DpEFwKCFEW/aWDkFPlyoqI=; b=q0TL+ZrMAvMl7g eNGw1sm1/czwArXqtJkTubp/4JbZDrumV7AT2+CSIm7ZDj/N2RXMXFqXxPZAIvOPEDJCjCm9HqDTB MYBbvsMKHKpNoM99iraJr43Rpcg5RNIcgkOanwrVdX/FOcvMP3a1R+CC+6IhfomqjUR/GSy0b4eAk xGo2+4qv3iKdXd1D+OIA3Psrf91BqoJI997uAWSH9+gB4HqAOKXHqoj34QLogQnHRQpv0dx7mNd7G FMymaqpBr3xS8DXFNGlNWJ0THNY+EQKxF69uVp6MuGVS7bCnveQ5lOH8tdU+3CMY1c5+tprHE2pCQ Oev2NoKQZczLVSvkBk1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqN5Y-008nnY-BS; Thu, 25 Nov 2021 22:19:32 +0000 Received: from mail-qk1-x734.google.com ([2607:f8b0:4864:20::734]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqN5U-008nnE-6S for linux-arm-kernel@lists.infradead.org; Thu, 25 Nov 2021 22:19:29 +0000 Received: by mail-qk1-x734.google.com with SMTP id p4so13028053qkm.7 for ; Thu, 25 Nov 2021 14:19:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Jzu3IGp/+NtN4KbWEJ7SKM9mTl27O4zRYj7bMTCcrDE=; b=OjE3fyUCfvqLCfwTy5oIDirKOGtUiPlm61xh/sjmS8fkEGNT33LdV81wdUB26kbtD+ o8zIRbchPNkvhSf82WqVy5cR98VkXUL3DUtCs351sPiQsuLzkzpFRBuV+3yPC9MuKi6w ztjTUmlFr7zgqMeQbvXhCFSvV9tUHahyGpaVEuposSRCXhJL1BEIHoZfJ9nq99Xa5mL0 iqlDbGv8MrD6mEQYXgnWOIO7h++bdHD9ETNLZDJhtjpgdzXfMdDeIER6ssS7mJIZveQT OHfPxHMFSGuDUT9msVDJ0QMAOhe4RPz9NmE+MFV0Qbx0CrnoTfZL2xlHs1nyTwC7ZpKn AOLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Jzu3IGp/+NtN4KbWEJ7SKM9mTl27O4zRYj7bMTCcrDE=; b=2hcbdwDlc0L89vc0Vcku/NM0CuIKcU4cFyDTDZrtGp+kWmFSvJujoAPoiGkpdrVANu n03eDGihdHm21+nurY962fhidDg6I85E8CzGZgChTEJxBVYMTN6Ek6NxdXs5132jjENR QsqAAkYAjW/wlblbHydbKwwltiH3SD09OCDada04pnLxDWmxodOzjehGLxgn4sIAn/eS c89m1H8pfH4UirSHWht+FjuJp2vp3Llh3lLwce/IbEqd82RGn0LXUGFgKADuoFSt3hWj ozQXCH4/mAa2c8Wziu6YxTwMu5tzyelH7RVz6qk847vidy65kK/Xo2Hl4cBZKw4dBgeX kt8A== X-Gm-Message-State: AOAM532hzAy85/1reXdwrM2mOaL2mP5y8ZLIpQzc6HSXQNA/2Fk62bym qhIPyeWvOQsx/ccZM6/adx4= X-Google-Smtp-Source: ABdhPJxTOSRJIXYg48NDzBO2Igr258AXSKndwwjJmfQt6W5u0VUgTJ2R8cUwxHqE9Pp/9WV8nyLzhQ== X-Received: by 2002:a05:620a:2955:: with SMTP id n21mr11102232qkp.586.1637878765420; Thu, 25 Nov 2021 14:19:25 -0800 (PST) Received: from [10.4.10.38] (146-115-144-188.s4282.c3-0.nwt-cbr1.sbo-nwt.ma.cable.rcncustomer.com. [146.115.144.188]) by smtp.gmail.com with ESMTPSA id d5sm2347779qte.27.2021.11.25.14.19.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Nov 2021 14:19:25 -0800 (PST) Message-ID: <2801d9c2-f922-5cc7-4e43-c9a8db3004ba@gmail.com> Date: Thu, 25 Nov 2021 17:19:23 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH v3 13/13] ARM: imxrt_defconfig: add i.MXRT family defconfig Content-Language: en-US To: Arnd Bergmann Cc: NXP Linux Team , Michael Turquette , Stephen Boyd , Rob Herring , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , Ulf Hansson , Dong Aisheng , Stefan Agner , Linus Walleij , gregkh , Olof Johansson , SoC Team , Russell King - ARM Linux , Abel Vesa , Adrian Hunter , Jiri Slaby , giulio.benetti@benettiengineering.com, Nobuhiro Iwamatsu , linux-clk , DTML , Linux ARM , Linux Kernel Mailing List , linux-mmc , "open list:GPIO SUBSYSTEM" , "open list:SERIAL DRIVERS" References: <20211125211443.1150135-1-Mr.Bossman075@gmail.com> <20211125211443.1150135-14-Mr.Bossman075@gmail.com> From: Jesse Taube In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211125_141928_283472_3558C724 X-CRM114-Status: GOOD ( 44.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/25/21 16:42, Arnd Bergmann wrote: > On Thu, Nov 25, 2021 at 10:14 PM Jesse Taube wrote: >> >> From: Giulio Benetti >> >> Add generic i.MXRT family defconfig. >> >> Signed-off-by: Giulio Benetti >> Signed-off-by: Jesse Taube > > I see a lot of things in here that probably should not be part of the kernel, > either because they are rather obscure, or they take valuable memory: > >> --- >> arch/arm/configs/imxrt_defconfig | 157 +++++++++++++++++++++++++++++++ >> 1 file changed, 157 insertions(+) >> create mode 100644 arch/arm/configs/imxrt_defconfig >> >> diff --git a/arch/arm/configs/imxrt_defconfig b/arch/arm/configs/imxrt_defconfig >> new file mode 100644 >> index 000000000000..d673745a5462 >> --- /dev/null >> +++ b/arch/arm/configs/imxrt_defconfig >> @@ -0,0 +1,157 @@ >> +# CONFIG_LOCALVERSION_AUTO is not set >> +CONFIG_SYSVIPC=y >> +CONFIG_USELIB=y > > You almost certainly won't want USELIB, and SYSVIPC support > would only be useful for certain applications that you probably > won't run. > >> +CONFIG_BSD_PROCESS_ACCT=y >> +CONFIG_BSD_PROCESS_ACCT_V3=y >> +CONFIG_PSI=y >> +CONFIG_IKCONFIG=y >> +CONFIG_IKCONFIG_PROC=y > > Probably nonen of these are helpful here. > >> +CONFIG_MEMCG=y >> +CONFIG_BLK_CGROUP=y >> +CONFIG_CFS_BANDWIDTH=y >> +CONFIG_CGROUP_PIDS=y >> +CONFIG_CGROUP_RDMA=y >> +CONFIG_CGROUP_FREEZER=y >> +CONFIG_CGROUP_DEVICE=y >> +CONFIG_CGROUP_CPUACCT=y >> +CONFIG_CGROUP_PERF=y >> +CONFIG_CGROUP_BPF=y >> +CONFIG_NAMESPACES=y >> +CONFIG_USER_NS=y >> +CONFIG_CHECKPOINT_RESTORE=y > > Same for control groups overall as well as checkpoint_restore > >> +CONFIG_RELAY=y > > There are a few drivers using CONFIG_RELAY, but I don't see you enable > any of them, > so this is not actually used. > this makes scene will change >> +CONFIG_EXPERT=y > > Are you losing anything without EXPERT? If not, remove that > >> +CONFIG_SGETMASK_SYSCALL=y >> +# CONFIG_FUTEX is not set > > Futex is probably one of the things you /do/ want. > There is a weird bug in futexs that reads from null_ptr, otherwise if you hard code that access isn't allowed it works. This seems to be a problem on other no-MMU platforms. I changed it to not have futexs like the stm32s, CONFIG_EXPERT is required for this option. If you want I can explain more about this but, i was going to do that as a separate patch. >> +CONFIG_KALLSYMS_ALL=y >> +CONFIG_PC104=y > > Turning off KALLSYMS_ALL may save a noticeable amount of RAM. Intresting > > PC104 isn't actually that big, but it seems unlikely that you have > that hardware. > >> +CONFIG_PARAVIRT=y > > You don't seem to enable XEN, so I don't think PARAVIRT is useful by itself. > >> +# CONFIG_ATAGS is not set >> +CONFIG_CMDLINE="console=ttyS0 root=/dev/mmcblk0p2 rw earlycon rootwait" > > The command line should come from the boot loader, users probably have > a different root device. Presumably this will never be used but I have it there as an example for others, I can remove it if necessary. > >> +CONFIG_BLK_DEV_BSGLIB=y >> +CONFIG_BLK_DEV_INTEGRITY=y >> +CONFIG_BLK_DEV_ZONED=y >> +CONFIG_BLK_DEV_THROTTLING=y >> +CONFIG_BLK_WBT=y >> +CONFIG_BLK_SED_OPAL=y >> +CONFIG_PARTITION_ADVANCED=y >> +CONFIG_BSD_DISKLABEL=y >> +CONFIG_MINIX_SUBPARTITION=y >> +CONFIG_SOLARIS_X86_PARTITION=y >> +CONFIG_UNIXWARE_DISKLABEL=y >> +CONFIG_LDM_PARTITION=y > > I don't see you using OPAL or any of the 1990's partition formats. > ot set > >> +CONFIG_BINFMT_FLAT=y > > For the defconfig, you should probably have ELF_FDPIC enabled, > not just FLAT. > >> +CONFIG_CLEANCACHE=y >> +CONFIG_ZPOOL=y >> +CONFIG_ZBUD=y >> +CONFIG_Z3FOLD=y > > Do these work as expected on NOMMU? > >> +CONFIG_BLK_DEV_LOOP=y >> +CONFIG_BLK_DEV_RAM=y >> +CONFIG_BLK_DEV_RAM_COUNT=1 >> +CONFIG_BLK_DEV_RAM_SIZE=65536 > > I don't think you can have a ramdisk larger than RAM ;-) > Oh that's funny I left that from testing something I will remove it. >> +CONFIG_MEMORY=y > > No need to enable the subsystem when you don't enable any > of its drivers. > >> +CONFIG_EXT2_FS=y >> +CONFIG_EXT2_FS_XATTR=y >> +CONFIG_EXT2_FS_POSIX_ACL=y >> +CONFIG_EXT2_FS_SECURITY=y >> +CONFIG_EXT3_FS=y >> +CONFIG_EXT3_FS_POSIX_ACL=y >> +CONFIG_EXT3_FS_SECURITY=y > > Never use EXT3 on eMMC, just use EXT4 instead to make > the device actually live longer. You probably don't need to enable > EXT2 support separately. > >> +# CONFIG_FILE_LOCKING is not set >> +# CONFIG_DNOTIFY is not set >> +CONFIG_QUOTA=y > > dnotify and locking seem more useful than quota here > >> +# CONFIG_PRINT_QUOTA_WARNING is not set >> +CONFIG_AUTOFS4_FS=y > >> +CONFIG_CONFIGFS_FS=y > > I don't see anything using configfs > >> +CONFIG_LSM="yama,loadpin,integrity,apparmor" > > None of these are actually enabled as far as I can tell. > >> +CONFIG_DEBUG_INFO=y >> +CONFIG_DEBUG_INFO_DWARF4=y > > If you use DWARF4, you probably want DEBUG_INFO_SPLIT as well, > to reduce the vmlinux size. > > Arnd > Thx for telling me about this i will try to use only the necessary ones. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel