* [PATCH] ARM:Gemini:fix compiler waring
@ 2015-05-07 17:34 Hans Ulli Kroll
2015-05-08 13:24 ` Arnd Bergmann
0 siblings, 1 reply; 2+ messages in thread
From: Hans Ulli Kroll @ 2015-05-07 17:34 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Hans Ulli Kroll <ulli.kroll@googlemail.com>
---
arch/arm/mach-gemini/common.h | 4 +++-
arch/arm/mach-gemini/reset.c | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-gemini/common.h b/arch/arm/mach-gemini/common.h
index 38a4526..dd88369 100644
--- a/arch/arm/mach-gemini/common.h
+++ b/arch/arm/mach-gemini/common.h
@@ -12,6 +12,8 @@
#ifndef __GEMINI_COMMON_H__
#define __GEMINI_COMMON_H__
+#include <linux/reboot.h>
+
struct mtd_partition;
extern void gemini_map_io(void);
@@ -26,6 +28,6 @@ extern int platform_register_pflash(unsigned int size,
struct mtd_partition *parts,
unsigned int nr_parts);
-extern void gemini_restart(char mode, const char *cmd);
+extern void gemini_restart(enum reboot_mode mode, const char *cmd);
#endif /* __GEMINI_COMMON_H__ */
diff --git a/arch/arm/mach-gemini/reset.c b/arch/arm/mach-gemini/reset.c
index b266597..21a6d6d 100644
--- a/arch/arm/mach-gemini/reset.c
+++ b/arch/arm/mach-gemini/reset.c
@@ -14,7 +14,9 @@
#include <mach/hardware.h>
#include <mach/global_reg.h>
-void gemini_restart(char mode, const char *cmd)
+#include "common.h"
+
+void gemini_restart(enum reboot_mode mode, const char *cmd)
{
__raw_writel(RESET_GLOBAL | RESET_CPU1,
IO_ADDRESS(GEMINI_GLOBAL_BASE) + GLOBAL_RESET);
--
2.3.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] ARM:Gemini:fix compiler waring
2015-05-07 17:34 [PATCH] ARM:Gemini:fix compiler waring Hans Ulli Kroll
@ 2015-05-08 13:24 ` Arnd Bergmann
0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2015-05-08 13:24 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday 07 May 2015 19:34:28 Hans Ulli Kroll wrote:
> Signed-off-by: Hans Ulli Kroll <ulli.kroll@googlemail.com>
>
Can you re-send that patch with a description of what warning it fixes?
The patch looks reasonable, but we really want all patches we merge to
have a changelog.
Arnd
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-08 13:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-07 17:34 [PATCH] ARM:Gemini:fix compiler waring Hans Ulli Kroll
2015-05-08 13:24 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).