From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A502CCA476 for ; Mon, 13 Oct 2025 05:59:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qVaz1zwGuDSR6vm0lLRYYp/IrSSmnl0g1UxK/5AowGY=; b=FDyllZLyxy6/geX2uWSd+VKHJw KV40zflq/2y2Ha2oWlQVxXEkaic+WlMwcAOV4Z+WTctA/TfOKs+n6e1MXLHRkCGNQf8Q6JH6nBlXn Q7gxJ11vaO/PO/S0+RNq+U6gbGK+qmd4H/t3szjWfpd0rfVGodQKbEDoxQOY+ptl47cIgbDchIsOO 8nOoensFY3Xbs0xOnDCNvxfR2e01RRxDWADRO/gcrxFbCJSEDNzkU0CL8orDmqoCGzFOtLck9kRgK q0uo3ImHVAJOGiVutWPjyS75jgFdIZCWI4chp9y1svU+AsYYfOE3CgmAWAXkknvRcWDVu9ecfRVFw 4n829WDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v8BaI-0000000CJzU-3qKK; Mon, 13 Oct 2025 05:59:02 +0000 Received: from mx-relay58-hz1.antispameurope.com ([94.100.133.229]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1v8BaC-0000000CJy4-2378 for linux-arm-kernel@lists.infradead.org; Mon, 13 Oct 2025 05:59:00 +0000 ARC-Authentication-Results: i=1; mx-gate58-hz1.hornetsecurity.com 1; spf=pass reason=mailfrom (ip=94.100.132.6, headerfrom=ew.tq-group.com) smtp.mailfrom=ew.tq-group.com smtp.helo=hmail-p-smtp01-out04-hz1.hornetsecurity.com; dmarc=pass header.from=ew.tq-group.com orig.disposition=pass ARC-Message-Signature: a=rsa-sha256; bh=qVaz1zwGuDSR6vm0lLRYYp/IrSSmnl0g1UxK/5AowGY=; c=relaxed/relaxed; d=hornetsecurity.com; h=from:to:date:subject:mime-version:; i=1; s=hse1; t=1760335114; b=GEC2EhwTC6PBfrD4ughUEi8UphPpnDRmOV67RN8WS5G/Q385+oIRywvXeV/b20Cg/WMMH2MO bRhmJOBVA3LGsRiOQ0yXBsupuX3qPtKoXMhhsIlo+GKxg1rsTrpfna7Bp61OGnfR2lpk1lMN/s/ fPn3gwt5nadmm6Q+FPIt5ez0EHSo+7pNvkvmW3JWmaZfLGHhECY2M46zA+Nf7G4nwBIkYeWSBxF oRkYNIi96l/MYWHFcKkx+pQFmpj0wLYqA8d+4u3/7I/jV/zSyvwdFt+WrzHDXxJUAiG/niXVN4n DH/Cja/BGaYzWoNB/d87BWIHjlFYozB2Gh6OEpxZBh44g== ARC-Seal: a=rsa-sha256; cv=none; d=hornetsecurity.com; i=1; s=hse1; t=1760335114; b=eElKH+NhfT+9aBMcVWI/XVS5bnP3uymVP7B9I7gRmUXDvKA7VRhQby24UsrPYJjEOXnLEDgP Gr7MXlQis3BRWnJcAwz8jra0zuWGH8VMW6CM7ryma+jhN45xrXlPL+io7plJTJg4ATq48GUPVFi umbYsCCVhMHxfghyA1hTXIp0c7hVxLbXiMAVKodnbiAXk/FuOC5734Oc+m1mfXWMVpaUN6s5jix 78vXh0Brk+4e4+ZFHgGKMxppqrivV1M4RIP9ccRAzvZ/TF6Vp7tN9jhKJHMW+5UaML0Ik03OYlD Q0FJ4DnyG1MyHJMT4U0dvE4Rmwvo1zX6z9BKUjSnlqAUw== Received: from he-nlb01-hz1.hornetsecurity.com ([94.100.132.6]) by mx-relay58-hz1.antispameurope.com; Mon, 13 Oct 2025 07:58:34 +0200 Received: from steina-w.localnet (host-82-135-125-110.customer.m-online.net [82.135.125.110]) (Authenticated sender: alexander.stein@ew.tq-group.com) by hmail-p-smtp01-out04-hz1.hornetsecurity.com (Postfix) with ESMTPSA id DC35522054B; Mon, 13 Oct 2025 07:58:12 +0200 (CEST) From: Alexander Stein To: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Li Jun , Abel Vesa , Peng Fan , Michael Turquette , Stephen Boyd , linux-arm-kernel@lists.infradead.org Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Xu Yang , Frank Li , Xu Yang Subject: Re: [PATCH v2 3/4] phy: fsl-imx8mq-usb: support alternate reference clock Date: Mon, 13 Oct 2025 07:58:12 +0200 Message-ID: <2805917.mvXUDI8C0e@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20251010-usb-phy-alt-clk-support-v2-3-af4b78bb4ae8@nxp.com> References: <20251010-usb-phy-alt-clk-support-v2-0-af4b78bb4ae8@nxp.com> <20251010-usb-phy-alt-clk-support-v2-3-af4b78bb4ae8@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-cloud-security-sender: alexander.stein@ew.tq-group.com X-cloud-security-recipient: linux-arm-kernel@lists.infradead.org X-cloud-security-crypt: load encryption module X-cloud-security-Mailarchiv: E-Mail archived for: alexander.stein@ew.tq-group.com X-cloud-security-Mailarchivtype: outbound X-cloud-security-Virusscan: CLEAN X-cloud-security-disclaimer: This E-Mail was scanned by E-Mailservice on mx-relay58-hz1.antispameurope.com with 4clRTy0D7HzQkxm X-cloud-security-connect: he-nlb01-hz1.hornetsecurity.com[94.100.132.6], TLS=1, IP=94.100.132.6 X-cloud-security-Digest: 7d5dfab00112230566df6a60cb391a85 X-cloud-security: scantime:2.228 DKIM-Signature: a=rsa-sha256; bh=qVaz1zwGuDSR6vm0lLRYYp/IrSSmnl0g1UxK/5AowGY=; c=relaxed/relaxed; d=ew.tq-group.com; h=content-type:mime-version:subject:from:to:message-id:date; s=hse1; t=1760335114; v=1; b=noHwEuiYVWSbXiwBqK06r6q2AgJbB4UVGebYigC24RjaYxVeZR2Km4EL0LLFIjpDEN+36GJ4 1pOCxsUMynKF8cL+793KsKAPRZTjCRhN1vZq9k3ifYMJfkjLKsoBDgltwmrL1rHCIZ5VF2+O1ig 8ct5zvjK2O0kPq/5J6eN/XOKQb+1Xk/xp158j5GsfpPEMBjo+ocEUaI0XwJ/iqzvMrGsUKsrsNF o5xKubqwY3ZoWz0csoOyZW7CuIuLgEQIWEu+die3TtSa72RvS9VARkoT/qxao55DIXS9uHkmCWF kV1boanJhDfuNGZJxkdYxYRpV5HKsyyslDnz1uLM7HB5Q== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251012_225856_789464_5D6C7753 X-CRM114-Status: GOOD ( 22.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Freitag, 10. Oktober 2025, 13:01:12 CEST schrieb Xu Yang: > This phy supports both 24MHz and 100MHz clock inputs. By default it's > using XTAL 24MHz and the 100MHz clock is a alternate reference clock. > Add supports to use alternate reference clock in case 24MHz clock > can't work well. This driver supports imx8mx and imx8mp as well. Do these SoC also support the alternative clock? Best regards Alexander > > Reviewed-by: Frank Li > Signed-off-by: Xu Yang > > --- > Changes in v2: > - add Rb tag > --- > drivers/phy/freescale/phy-fsl-imx8mq-usb.c | 23 +++++++++++++++++++++-- > 1 file changed, 21 insertions(+), 2 deletions(-) > > diff --git a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c > index b94f242420fc733cd75abef8ba1cd4f59ac18eb5..ad8a55012e42f2c15496955d00c6d5fd85c5beb2 100644 > --- a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c > +++ b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c > @@ -16,6 +16,7 @@ > #define PHY_CTRL0_REF_SSP_EN BIT(2) > #define PHY_CTRL0_FSEL_MASK GENMASK(10, 5) > #define PHY_CTRL0_FSEL_24M 0x2a > +#define PHY_CTRL0_FSEL_100M 0x27 > > #define PHY_CTRL1 0x4 > #define PHY_CTRL1_RESET BIT(0) > @@ -108,6 +109,7 @@ struct tca_blk { > struct imx8mq_usb_phy { > struct phy *phy; > struct clk *clk; > + struct clk *alt_clk; > void __iomem *base; > struct regulator *vbus; > struct tca_blk *tca; > @@ -582,7 +584,8 @@ static int imx8mp_usb_phy_init(struct phy *phy) > /* USB3.0 PHY signal fsel for 24M ref */ > value = readl(imx_phy->base + PHY_CTRL0); > value &= ~PHY_CTRL0_FSEL_MASK; > - value |= FIELD_PREP(PHY_CTRL0_FSEL_MASK, PHY_CTRL0_FSEL_24M); > + value |= FIELD_PREP(PHY_CTRL0_FSEL_MASK, imx_phy->alt_clk ? > + PHY_CTRL0_FSEL_100M : PHY_CTRL0_FSEL_24M); > writel(value, imx_phy->base + PHY_CTRL0); > > /* Disable alt_clk_en and use internal MPLL clocks */ > @@ -626,13 +629,24 @@ static int imx8mq_phy_power_on(struct phy *phy) > if (ret) > return ret; > > - return clk_prepare_enable(imx_phy->clk); > + ret = clk_prepare_enable(imx_phy->clk); > + if (ret) > + return ret; > + > + ret = clk_prepare_enable(imx_phy->alt_clk); > + if (ret) { > + clk_disable_unprepare(imx_phy->clk); > + return ret; > + } > + > + return ret; > } > > static int imx8mq_phy_power_off(struct phy *phy) > { > struct imx8mq_usb_phy *imx_phy = phy_get_drvdata(phy); > > + clk_disable_unprepare(imx_phy->alt_clk); > clk_disable_unprepare(imx_phy->clk); > regulator_disable(imx_phy->vbus); > > @@ -681,6 +695,11 @@ static int imx8mq_usb_phy_probe(struct platform_device *pdev) > return PTR_ERR(imx_phy->clk); > } > > + imx_phy->alt_clk = devm_clk_get_optional(dev, "alt"); > + if (IS_ERR(imx_phy->alt_clk)) > + return dev_err_probe(dev, PTR_ERR(imx_phy->alt_clk), > + "Failed to get alt clk\n"); > + > imx_phy->base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(imx_phy->base)) > return PTR_ERR(imx_phy->base); > >