Re: [PATCH] pinctrl: stm32: Drop the nonexistent CONFIG_MACH_STM32MP25 from the STM32MP257 default

[Antonio Borneo <antonio.borneo@foss.st.com>]

On Sat, 2026-09-05 at 10:02 +0200, Karl Mehltretter wrote:
> Commit 619f8ca4a73d ("pinctrl: stm32: add stm32mp257 pinctrl support")
> made CONFIG_PINCTRL_STM32MP257 default to MACH_STM32MP25, following the
> MACH_* pattern of the arm32 entries above it, but no Kconfig symbol of
> that name exists and git log -S finds no Kconfig file that ever defined
> one: the STM32MP25 family is arm64 only, where CONFIG_ARCH_STM32 covers
> it. Commit dba0aff2b89b ("pinctrl: stm32: Allow compile as module for
> stm32mp257") added "|| (ARCH_STM32 && ARM64)" next to it, so the first
> half now evaluates to n and changes no configuration.
> 
> Drop the first half.
> 
> Fixes: 619f8ca4a73d ("pinctrl: stm32: add stm32mp257 pinctrl support")
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
> ---
>  drivers/pinctrl/stm32/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/stm32/Kconfig b/drivers/pinctrl/stm32/Kconfig
> index d6a171523012..cc425bbfc996 100644
> --- a/drivers/pinctrl/stm32/Kconfig
> +++ b/drivers/pinctrl/stm32/Kconfig
> @@ -55,7 +55,7 @@ config PINCTRL_STM32MP157
>  config PINCTRL_STM32MP257
>         tristate "STMicroelectronics STM32MP257 pin control"
>         depends on OF && HAS_IOMEM
> -       default MACH_STM32MP25 || (ARCH_STM32 && ARM64)
> +       default ARCH_STM32 && ARM64
>         select PINCTRL_STM32
>  
>  config PINCTRL_STM32_HDP

Reviewed-by: Antonio Borneo <antonio.borneo@foss.st.com>

Thanks,
Antonio