From: Heiko Stuebner <heiko@sntech.de>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Yi Wang <wang.yi59@zte.com.cn>,
Florian Fainelli <f.fainelli@gmail.com>,
Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
Wen Yang <wen.yang99@zte.com.cn>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [v3] ARM: rockchip: Fix a leaked reference by adding of_node_put() in two functions
Date: Sun, 28 Apr 2019 12:40:08 +0200 [thread overview]
Message-ID: <2816348.laE8LpYbrI@phil> (raw)
In-Reply-To: <cee2ab03-d0b7-c9c6-acc3-d5aa28979e2b@web.de>
Am Sonntag, 28. April 2019, 08:27:05 CEST schrieb Markus Elfring:
> > arch/arm/mach-rockchip/platsmp.c | 12 ++++++++++--
> > arch/arm/mach-rockchip/pm.c | 2 ++
>
> * Would a commit subject variant be nicer?
yeah, but I'll simply adjust that when applying.
> * I dare to present a reminder for a recurring development topic.
> How do you think about to adjust the exception handling in these function
> implementations a bit more according to the Linux coding style
> (so that the addition of duplicate function calls would be avoided)?
I actually requested not doing wild gotos for of_node_put calls,
as it makes the code harder to read, especially when the "node"
gets reused for a different node-source.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-28 10:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 7:08 [PATCH v3] ARM: rockchip: fix a leaked reference by adding missing of_node_put Wen Yang
2019-04-28 6:27 ` [v3] ARM: rockchip: Fix a leaked reference by adding of_node_put() in two functions Markus Elfring
2019-04-28 10:40 ` Heiko Stuebner [this message]
2019-04-28 10:52 ` Markus Elfring
2019-04-28 10:46 ` [PATCH v3] ARM: rockchip: fix a leaked reference by adding missing of_node_put Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2816348.laE8LpYbrI@phil \
--to=heiko@sntech.de \
--cc=Markus.Elfring@web.de \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=wang.yi59@zte.com.cn \
--cc=wen.yang99@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).