From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30EF3C43218 for ; Sun, 28 Apr 2019 10:40:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F27712075D for ; Sun, 28 Apr 2019 10:40:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZaAvVmkc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F27712075D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9YiTFwBXvl9zFSJc3RYudGML7gWJsJOwx2wScW34bh8=; b=ZaAvVmkc88FlND J+H8a8snULhnFUz+sCzeDKMFJokvwtRwvnsey0Bs/N4lfhg3wGechM/VmQ4Aun7LG4FTUXaEsybs0 JjbkM69BmvRc4L6NFOVkkD3V/oIyNL03s/gWuK8RfInx34+U0izAuKU3WGs7DC0BTN7JxU5kWMstH 4A1ER3qjWii3XdMpxmGFg6Yl/nqr46+RnTkUNatsFPx5vrck94T1PUWjrGlN+aAtFH1SS1ElxbLuH LKPbaGB37knZDch1pB6+NdDmRBAFSNPqF528lZ0LLqKD8m5UvHPDhUQ7e6ig4NG26iSixf0upqnEj AiPpX4w6Wi7VoxgsVvBw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hKhEN-0004Ip-5t; Sun, 28 Apr 2019 10:40:23 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hKhEJ-0004I6-IG; Sun, 28 Apr 2019 10:40:21 +0000 Received: from p57b775bf.dip0.t-ipconnect.de ([87.183.117.191] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hKhE9-0005IF-Ax; Sun, 28 Apr 2019 12:40:09 +0200 From: Heiko Stuebner To: Markus Elfring Subject: Re: [v3] ARM: rockchip: Fix a leaked reference by adding of_node_put() in two functions Date: Sun, 28 Apr 2019 12:40:08 +0200 Message-ID: <2816348.laE8LpYbrI@phil> In-Reply-To: References: <1556262488-21072-1-git-send-email-wen.yang99@zte.com.cn> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190428_034019_755508_0587922E X-CRM114-Status: GOOD ( 12.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yi Wang , Florian Fainelli , Russell King , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Wen Yang , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Sonntag, 28. April 2019, 08:27:05 CEST schrieb Markus Elfring: > > arch/arm/mach-rockchip/platsmp.c | 12 ++++++++++-- > > arch/arm/mach-rockchip/pm.c | 2 ++ > > * Would a commit subject variant be nicer? yeah, but I'll simply adjust that when applying. > * I dare to present a reminder for a recurring development topic. > How do you think about to adjust the exception handling in these function > implementations a bit more according to the Linux coding style > (so that the addition of duplicate function calls would be avoided)? I actually requested not doing wild gotos for of_node_put calls, as it makes the code harder to read, especially when the "node" gets reused for a different node-source. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel