From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mm: cpu_fa526_do_idle: remove WFI
Date: Mon, 17 Jun 2013 17:07:21 +0200 [thread overview]
Message-ID: <2819561.Rn435lDYbW@wuerfel> (raw)
In-Reply-To: <20130617143021.GI2718@n2100.arm.linux.org.uk>
On Monday 17 June 2013 15:30:21 Russell King - ARM Linux wrote:
> > > diff --git a/arch/arm/mm/proc-fa526.S b/arch/arm/mm/proc-fa526.S
> > > index d217e97..85280b1 100644
> > > --- a/arch/arm/mm/proc-fa526.S
> > > +++ b/arch/arm/mm/proc-fa526.S
> > > @@ -81,9 +81,7 @@ ENDPROC(cpu_fa526_reset)
> > > */
> > > .align 4
> > > ENTRY(cpu_fa526_do_idle)
> > > - mcr p15, 0, r0, c7, c0, 4 @ Wait for interrupt
> > > - mov pc, lr
> > > -
> > > + nop
>
> It replaces the WFI and return with a pure nop, so we will fall through
> to cpu_fa526_dcache_clean_area(). Do we really want to clean a random
> D cache entry depending on what r0 happened to hold at this point? I
> think not...
Right, I should have actually read the change...
Arnd
prev parent reply other threads:[~2013-06-17 15:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 13:39 [PATCH] ARM: mm: cpu_fa526_do_idle: remove WFI Jonas Jensen
2013-06-17 14:14 ` Arnd Bergmann
2013-06-17 14:30 ` Russell King - ARM Linux
2013-06-17 14:58 ` Jonas Jensen
2013-06-17 15:01 ` Arnd Bergmann
2013-06-17 15:07 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2819561.Rn435lDYbW@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox