From: hongjiujing@126.com (tommy.hong)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02/17] ARM: S5PC1XX: registers rename
Date: Fri, 6 Nov 2009 16:17:51 +0800 (CST) [thread overview]
Message-ID: <28219630.804641257495471280.JavaMail.coremail@bj126app54.126.com> (raw)
In-Reply-To: <20091106031845.GG3913@prithivi.gnumonks.org>
yeah,i agree
?2009-11-06?11:18:45?"Harald?Welte"?<laforge@gnumonks.org>????
>Hi?Marek,
>
>On?Tue,?Oct?13,?2009?at?10:11:07AM?+0200,?Marek?Szyprowski?wrote:
>
>>?S5PC110?and?S5PC100?register?maps?differs?in?many?places,?rename?all
>>?defined?registers?to?be?S5PC100?specific.?System?map?has?been?also?updated
>>?to?cover?more?integrated?peripherals.
>
>The?general?idea?of?this?patch?is?fine.??However,?I?have?some?questions:
>
>>??/*?System?*/
>>?-#define?S5PC100_PA_SYS (0xE0100000)
>>?-#define?S5PC100_PA_CLK (S5PC100_PA_SYS?+?0x0)
>>?-#define?S5PC100_PA_PWR (S5PC100_PA_SYS?+?0x8000)
>>?+#define?S5PC100_PA_CLK (0xE0100000)
>>?+#define?S5PC100_PA_CLK_OTHER (0xE0200000)
>>?+#define?S5PC100_PA_PWR (0xE0108000)
>
>this?is?more?like?a?rename.??Why?was?this?done???It?would?be?good?to?explain?in
>the?commitlog
>
>>?+/*?GPIO?*/
>>?+#define?S5PC100_PA_GPIO (0xE0300000)
>>?+#define?S5PC1XX_PA_GPIO S5PC100_PA_GPIO
>>?+#define?S5PC1XX_VA_GPIO S3C_ADDR(0x00500000)
>
>If?the?address?is?different?for?c100?and?c110:?why?do?we?need?a?S5CP1XX_*
>definition???In?my?personal?opinion,?all?those?compile-time?defines?are?a
>kludge?and?we?should?not?introduce?more?of?them.??They?will?bite?us?in?the?back
>if?we?ever?in?the?future?want?to?build?a?kernel?that?can?boot?on?both?c100?and
>c110.
>
>>??/*?ETC?*/
>>??#define?S5PC100_PA_SDRAM (0x20000000)
>>?+#define?S5PC1XX_PA_SDRAM S5PC100_PA_SDRAM
>
>Again?here.?We?already?have?the?c100?specific?define.??Why?add?a?new?c1xx?define?
>
>>?? /*?Maintainer:?Byungho?Min?<bhmin@samsung.com>?*/
>>?- .phys_io =?S5PC1XX_PA_UART?&?0xfff00000,
>>?+ .phys_io =?S5PC100_PA_UART?&?0xfff00000,
>
>this?is?the?change?I?like.
>
>>?? .io_pg_offst =?(((u32)S5PC1XX_VA_UART)?>>?18)?&?0xfffc,
>>?- .boot_params =?S5PC100_PA_SDRAM?+?0x100,
>>?+ .boot_params =?S5PC1XX_PA_SDRAM?+?0x100,
>
>This?is?the?wrong?kind?of?change,?from?my?point?of?view.??We?don't?know?yet
>if?all?future?s5pc1xx?products?will?also?have?the?same?address,?do?we?
>
>--?
>-?Harald?Welte?<laforge@gnumonks.org>???????????http://laforge.gnumonks.org/
>============================================================================
>"Privacy?in?residential?applications?is?a?desirable?marketing?option."
>??????????????????????????????????????????????????(ETSI?EN?300?175-7?Ch.?A6)
>
>_______________________________________________
>linux-arm-kernel?mailing?list
>linux-arm-kernel at lists.infradead.org
>http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20091106/1f8a0fb8/attachment.htm>
next prev parent reply other threads:[~2009-11-06 8:17 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-13 8:11 [PATCH] Update Samsung S5PC100 SoC support Marek Szyprowski
2009-10-13 8:11 ` [PATCH 01/17] ARM: MM: use 64bytes of L1 cache on plat S5PC1xx Marek Szyprowski
2009-10-13 8:11 ` [PATCH 02/17] ARM: S5PC1XX: registers rename Marek Szyprowski
2009-10-13 8:11 ` [PATCH 03/17] ARM: S5PC1XX: clock " Marek Szyprowski
2009-10-13 8:11 ` [PATCH 04/17] ARM: S5PC1XX: clocks reimplementation Marek Szyprowski
2009-10-13 8:11 ` [PATCH 05/17] ARM: S5PC1XX: add GPIO L banks to register definition Marek Szyprowski
2009-10-13 8:11 ` [PATCH 06/17] ARM: S5PC1XX: GPIO registers rename Marek Szyprowski
2009-10-13 8:11 ` [PATCH 07/17] ARM: S5PC1xx: add gpiolib and external/gpio interrupt support Marek Szyprowski
2009-10-13 8:11 ` [PATCH 08/17] ARM: S5PC1XX: add cpu idle and system reset support Marek Szyprowski
2009-10-13 8:11 ` [PATCH 09/17] ARM: S5PC1xx: add platform helpers for s3c-fb device Marek Szyprowski
2009-10-13 8:11 ` [PATCH 10/17] SMDKC100: enable S3C FrameBuffer Marek Szyprowski
2009-10-13 8:11 ` [PATCH 11/17] drivers: fb: enable S3C FrameBuffer on S5PC1XX platform Marek Szyprowski
2009-10-13 8:11 ` [PATCH 12/17] ARM: S5PC1xx: add platform helpers for i2c adapter devices Marek Szyprowski
2009-10-13 8:11 ` [PATCH 13/17] SMDKC100: add I2C0 and I2C1 buses support Marek Szyprowski
2009-10-13 8:11 ` [PATCH 14/17] drivers: i2c: s3c2410-i2c also on S5PC1XX platform Marek Szyprowski
2009-10-13 8:11 ` [PATCH 15/17] ARM: S5PC1xx: add platform helpers for SDHCI host controllers Marek Szyprowski
2009-10-13 8:11 ` [PATCH 16/17] SMDKC100: add SDHCI controllers 0, 1 and 2 support Marek Szyprowski
2009-10-13 8:11 ` [PATCH 17/17] drivers: MMC: enable SDHCI-S3C on S5PC1XX platform Marek Szyprowski
2009-11-06 3:31 ` [PATCH 15/17] ARM: S5PC1xx: add platform helpers for SDHCI host controllers Harald Welte
2009-11-06 3:30 ` [PATCH 13/17] SMDKC100: add I2C0 and I2C1 buses support Harald Welte
2009-11-06 3:30 ` [PATCH 12/17] ARM: S5PC1xx: add platform helpers for i2c adapter devices Harald Welte
2009-11-06 3:29 ` [PATCH 10/17] SMDKC100: enable S3C FrameBuffer Harald Welte
2009-11-06 3:29 ` [PATCH 09/17] ARM: S5PC1xx: add platform helpers for s3c-fb device Harald Welte
2009-11-09 0:02 ` Ben Dooks
2009-11-06 3:26 ` [PATCH 08/17] ARM: S5PC1XX: add cpu idle and system reset support Harald Welte
2009-11-06 3:23 ` [PATCH 07/17] ARM: S5PC1xx: add gpiolib and external/gpio interrupt support Harald Welte
2009-11-09 0:00 ` Ben Dooks
2009-11-06 3:20 ` [PATCH 06/17] ARM: S5PC1XX: GPIO registers rename Harald Welte
2009-11-06 3:20 ` [PATCH 05/17] ARM: S5PC1XX: add GPIO L banks to register definition Harald Welte
2009-11-06 3:19 ` [PATCH 03/17] ARM: S5PC1XX: clock registers rename Harald Welte
2009-11-06 3:18 ` [PATCH 02/17] ARM: S5PC1XX: " Harald Welte
2009-11-06 8:17 ` tommy.hong [this message]
2009-11-06 15:02 ` Marek Szyprowski
2009-11-09 0:07 ` Ben Dooks
2009-11-06 2:32 ` [PATCH 01/17] ARM: MM: use 64bytes of L1 cache on plat S5PC1xx Harald Welte
2009-11-08 23:58 ` Ben Dooks
2009-11-09 2:41 ` Kyungmin Park
2009-11-09 0:05 ` [PATCH] Update Samsung S5PC100 SoC support Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28219630.804641257495471280.JavaMail.coremail@bj126app54.126.com \
--to=hongjiujing@126.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).