public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Primoz Fiser <primoz.fiser@norik.com>
To: Wadim Egorov <w.egorov@phytec.de>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	upstream@lists.phytec.de
Subject: Re: [Upstream] [PATCH 2/2] arm64: dts: freescale: Add PHYTEC phyBOARD-Nash-i.MX93 support
Date: Mon, 5 May 2025 09:04:17 +0200	[thread overview]
Message-ID: <282a7e41-97f8-4fd4-9f03-29f70acc4df2@norik.com> (raw)
In-Reply-To: <000c1117-81d1-4a74-9d36-f83a2b0fedd3@phytec.de>

Hi Wadim,

On 28. 04. 25 16:31, Wadim Egorov wrote:
> Hi Primoz,
> 
> a few of the node references you are adding are out of alphabetical order.

Only &mdio node is out of alphabetical order.

But this is done by choice to keep it together with &eqos node since
both nodes are related to the 2nd Ethernet interface (&ethphy2) and thus
kept logically with each other.

We did the same for phyBOARD-Segin-i.MX93.

> 
> Am 25.04.25 um 09:41 schrieb Primoz Fiser:
>> Add initial support for PHYTEC phyBOARD-Nash-i.MX93 board [1] based on
>> the PHYTEC phyCORE-i.MX93 SoM (System-on-Module) [2].
>>
>> Supported board features:
>>   * ADC
>>   * CAN
>>   * Ethernet 2x
>>   * EEPROM
>>   * eMMC
>>   * Heartbeat LED
>>   * RTC
> 
> eMMC and Hearbeat LED are not board features but SoM features.

That's true.

I will remove those from the list in v2 and only list carrier-board
features.

BR,
Primoz

> 
>>   * RS-232/RS-485
>>   * SD-card
>>   * TPM 2.0
>>   * USB
>>
>> For more details see the product pages for the development kit and the
>> SoM:
>>
>> [1] https://www.phytec.eu/en/produkte/development-kits/phyboard-nash/
>> [2]
>> https://www.phytec.eu/en/produkte/system-on-modules/phycore-imx-91-93/
>>
>> Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>
> 
> With that changed,
> 
> Reviewed-by: Wadim Egorov <w.egorov@phytec.de>
> 

-- 
Primoz Fiser
phone: +386-41-390-545
email: primoz.fiser@norik.com
--
Norik systems d.o.o.
Your embedded software partner
Slovenia, EU
phone: +386-41-540-545
email: info@norik.com


  reply	other threads:[~2025-05-05  7:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-25  6:41 [PATCH 1/2] bindings: arm: fsl: Add PHYTEC phyBOARD-Nash-i.MX93 board Primoz Fiser
2025-04-25  6:41 ` [PATCH 2/2] arm64: dts: freescale: Add PHYTEC phyBOARD-Nash-i.MX93 support Primoz Fiser
2025-04-28 14:31   ` [Upstream] " Wadim Egorov
2025-05-05  7:04     ` Primoz Fiser [this message]
2025-04-29 12:06   ` Peng Fan
2025-04-28  8:29 ` [PATCH 1/2] bindings: arm: fsl: Add PHYTEC phyBOARD-Nash-i.MX93 board Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=282a7e41-97f8-4fd4-9f03-29f70acc4df2@norik.com \
    --to=primoz.fiser@norik.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=upstream@lists.phytec.de \
    --cc=w.egorov@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox