From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F604C43381 for ; Mon, 1 Apr 2019 18:32:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6DDDE20896 for ; Mon, 1 Apr 2019 18:32:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="G2FS4vrM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6DDDE20896 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q9XIo2NB89kG0FiXjt1VS5DoPUhjoFqBedMAE6Oo5zU=; b=G2FS4vrMdD8HTe BQrqgpScLz+lxn2AwRxPTdeAbBMRZJb/eolFHn5m3y4ZY49olXRFYKuevR3E+jAhHkiD4TxS6Gzjv B+eO5klzCshnyYAXigvVSTJ+/JyHct6QeQ7rfMuCK9pG97IyuOa+B47IVmJovkim5yk5g4Bic0je5 meMnDVSdlLnWwFzGhTDoh4gTqkPf3hYSlZwSwDlqgbM2N2BWcmderoMdjddj1GW7SC6bPmnRM7fnJ i4wka+rX35jtgTUf1GJGadC8yqa4xarK/Ddm6J5e6+IL1BKT8C27IpHlckKbQltEYiqog5zNZiNIk n8XZ3oBKPUAxEhoVyuPg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB1j7-0003vC-Tg; Mon, 01 Apr 2019 18:32:09 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB1j4-0003tz-J4 for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2019 18:32:08 +0000 Received: from ip5f5a6320.dynamic.kabel-deutschland.de ([95.90.99.32] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hB1ix-00078O-HA; Mon, 01 Apr 2019 20:31:59 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: "Leonidas P. Papadakos" Subject: Re: [PATCH 1/2] stmmac: introduce flag to dynamically disable TX offload for rockchip devices Date: Mon, 01 Apr 2019 20:31:58 +0200 Message-ID: <2839092.mkRqKCgQVQ@diego> In-Reply-To: <20190401181840.31255-1-papadakospan@gmail.com> References: <20190401181840.31255-1-papadakospan@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190401_113206_776266_A9069098 X-CRM114-Status: GOOD ( 14.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Torgue , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jose Abreu , Maxime Coquelin , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Leonidas, Am Montag, 1. April 2019, 20:18:40 CEST schrieb Leonidas P. Papadakos: > From: =?UTF-8?q?Kamil=20Trzci=C5=84ski?= > > Some rockchip boards exhibit an issue where tx checksumming does not work with > packets larger than 1498. > > This is bad for network stability. > > The previous approach was using force_thresh_dma_mode in the board dts, which > does more than we need. > > Signed-off-by: Leonidas P. Papadakos > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > index 3031f2bf1..807cf5826 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > @@ -519,6 +519,8 @@ stmmac_probe_config_dt(struct platform_device *pdev, const char **mac) > pr_warn("force_sf_dma_mode is ignored if force_thresh_dma_mode is set."); > } > > + plat->bugged_tx_coe = of_property_read_bool(np, "rockchip,bugged_tx_coe"); > + you're adding a new devicetree property, so please (1) also update the binding doc in Documentation/devicetree/bindings/net/rockchip-dwmac.txt (2) Cc devicetree maintainers and lists (via get_maintainer.pl once you've added the binding change) to let them look at it. Thanks Heiko > of_property_read_u32(np, "snps,ps-speed", &plat->mac_port_sel_speed); > > plat->axi = stmmac_axi_setup(pdev); > diff --git a/include/linux/stmmac.h b/include/linux/stmmac.h > index 4335bd771..60c411f43 100644 > --- a/include/linux/stmmac.h > +++ b/include/linux/stmmac.h > @@ -162,6 +162,7 @@ struct plat_stmmacenet_data { > int pmt; > int force_sf_dma_mode; > int force_thresh_dma_mode; > + int bugged_tx_coe; > int riwt_off; > int max_speed; > int maxmtu; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel