From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C701C3DA49 for ; Tue, 30 Jul 2024 07:31:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=phzzdkq7fOGAfE/5nN2HQ8Rb+AHqVU2SBA1vaHHG5FY=; b=QkEC5bUbH8VZECY6Qxn6NZPDLE hTJ3SXDtn/fvb0DR8CtRR4LCv62vOp1OglwlaOt3huUafAdGBDQODwHmhG18Fr5JvCT9Dli5rOCim hUxfilSUtYFUuWBja/1kmKchj1SzkbBsVLWU+HeM24M2ahx/E3IskBkTaA4BeBdU9XS888j5GC6i2 ckpTo2/EUg523oJg02+ZLKuG+b+kuzEwpDcpWGo7i+vgDZBJpD+pmyEKDCiqkp+DOt2KFflzTcddS nqTXsQj0XO2LrOA9CryAAuT1b304x/+0c5qiUxkneoppFTN6nXwLZrcCTfbfI3VxDIoE/W0ki7lna LPCvo2tw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYhJs-0000000E2GS-1xJ4; Tue, 30 Jul 2024 07:30:52 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYhJP-0000000E29O-3kNG for linux-arm-kernel@lists.infradead.org; Tue, 30 Jul 2024 07:30:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1722324623; x=1753860623; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=phzzdkq7fOGAfE/5nN2HQ8Rb+AHqVU2SBA1vaHHG5FY=; b=qE22YwTm3CvwYHIWIQHdk8KtrjnDf9fF/+5hokGk47v5ODvSB6TAFIeS pQPxOE89shYUxrq4i4oOVqZPLBX/Bq9qr6k8UBK/PbDovG9PR9Ay9RUh3 ZQPm+hLw0/30tIBYOVGGCYSZZROI8jn/sbCwR8sZ285OTRc5DBZoorrZy Rxf40LG1b9GjwPoV2H9sfVm09AZ43ytnOJ62FRLZPFu6dRJcmoL2rKIXl Rsa+SsRh6La5Ut3u560+Dp60E64Cc5Mx4/+ZJVt4u9aWg5ITjsB6IQ5Ib AJtjMB6RJdhd6XxiNfh/bSe8yzPHma/XekaVLvhlQ1i5yVJNFHrlX4ccW w==; X-CSE-ConnectionGUID: kypxY0/5SNCSnqMUHtlmgQ== X-CSE-MsgGUID: BxK5qmE6Tnuw52PxG5QURQ== X-IronPort-AV: E=Sophos;i="6.09,248,1716242400"; d="scan'208";a="38139756" Received: from vmailcow01.tq-net.de ([10.150.86.48]) by mx1.tq-group.com with ESMTP; 30 Jul 2024 09:30:21 +0200 X-CheckPoint: {66A8968D-20-CA1431AC-CF855369} X-MAIL-CPID: 1C57A42B986A162BA27F0E30C682380C_1 X-Control-Analysis: str=0001.0A782F1F.66A8968D.0165,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 1DA58167B75; Tue, 30 Jul 2024 09:30:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ew.tq-group.com; s=dkim; t=1722324617; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=phzzdkq7fOGAfE/5nN2HQ8Rb+AHqVU2SBA1vaHHG5FY=; b=gOjKUvEgQdABiwt2rGFfKsC2GaDVi1OjvnUHPzG4nHO9QcJSqcVG0m5wLIsNEuPL8NQx1q QOd6uuKxN9Gu15HJjw9PPlz27O+GMgXDFzZeLwAkiJZPYSKKDPK2u/uNyRbKs+j8IV7QYr e/S68gvGaErQKHLLbEXw00ZjPWN/v6KR7tXx1ZfqebVwPb+wdz7xLdK7kq24/hXPHKGbOh HBsuFCzJhLbe9TxYtgbZkIWI2THz+4RQCv0hgHrXuHbNdt2O3NQMXxmdrMfiidW7lAPLvg aFMQa2CpRrQ0snmip0vYxUUXjl6sUsvE82lr+U1j2kHXoc1KMersq4sG+nZLTA== From: Alexander Stein To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Krzysztof Kozlowski Cc: Clark Wang , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] arm64: dts: imx8-ss-dma: enable dma support for lpspi Date: Tue, 30 Jul 2024 09:30:16 +0200 Message-ID: <2840074.mvXUDI8C0e@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <6c6bb89e-a9d8-4d5c-837a-30f3bae56f0f@kernel.org> References: <20240729094511.159467-1-alexander.stein@ew.tq-group.com> <6c6bb89e-a9d8-4d5c-837a-30f3bae56f0f@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240730_003024_450343_513FA6E4 X-CRM114-Status: GOOD ( 15.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, Am Montag, 29. Juli 2024, 17:10:48 CEST schrieb Krzysztof Kozlowski: > On 29/07/2024 11:45, Alexander Stein wrote: > > From: Clark Wang > >=20 > > Add DMA configurations for LPSPI nodes on i.MX8QX/QM/DXL. > >=20 > > Signed-off-by: Clark Wang > > Signed-off-by: Alexander Stein > > --- > > Using the DMA configuration bits from downstream kernel. > > Tested on TQMa8XxS. > >=20 > > arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 8 ++++++++ > > 1 file changed, 8 insertions(+) > >=20 > > diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi b/arch/arm6= 4/boot/dts/freescale/imx8-ss-dma.dtsi > > index 1ee9496c988c5..8ae5f065b4180 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi > > @@ -34,6 +34,8 @@ lpspi0: spi@5a000000 { > > assigned-clocks =3D <&clk IMX_SC_R_SPI_0 IMX_SC_PM_CLK_PER>; > > assigned-clock-rates =3D <60000000>; > > power-domains =3D <&pd IMX_SC_R_SPI_0>; > > + dma-names =3D "tx","rx"; >=20 > Missing spaces. Unexpected order, unless that's the coding style for imx. Ack for the space, will correct. But the order is defined that way in Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml Best regards, Alexander =2D-=20 TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/