linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: rockchip: fix rk3066 pll lock bit location
Date: Fri, 26 Dec 2014 22:23:26 +0100	[thread overview]
Message-ID: <2847519.2sf188msm1@phil> (raw)
In-Reply-To: <2140322.FD0TUOM80V@phil>

Am Mittwoch, 24. Dezember 2014, 15:11:00 schrieb Heiko St?bner:
> The bit locations indicating the locking status of the plls on rk3066 are
> shifted by one to the right when compared to the rk3188, bits [7:4] instead
> of [8:5] on the rk3188, thus indicating the locking state of the wrong pll
> or a completely different information in case of the gpll.
> 
> The recently introduced pll init code exposed that problem on some rk3066
> boards when it tried to bring the boot-pll value in line with the value
> from the rate table.
> 
> Fix this by defining separate pll definitions for rk3066 with the correct
> locking indices.
> 
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>

applied to my clk-fixes branch with naobsd's tested-by.

I've also received another positive response of the patch fixing the issue on 
IRC.


Heiko

      parent reply	other threads:[~2014-12-26 21:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-24 14:11 [PATCH] clk: rockchip: fix rk3066 pll lock bit location Heiko Stübner
2014-12-26 15:54 ` Naoki FUKAUMI
2014-12-26 21:23 ` Heiko Stübner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2847519.2sf188msm1@phil \
    --to=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).