linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [v.1] clk:clk-rockchip:-of_iomap failed to remap then abort clock initialization.
Date: Wed, 24 Aug 2016 16:56:08 +0200	[thread overview]
Message-ID: <2854111.gibmD6ORig@diego> (raw)
In-Reply-To: <fa254e23-818c-0698-cbbc-68c983e83203@gmail.com>

Hi Arvind,

Am Mittwoch, 24. August 2016, 19:52:45 schrieb arvind Yadav:
> yes, I am referring this code for clock control.

Please definitly do not use that old gate driver anymore!

Instead please look at the real clock drivers for specific Rockchip socs in the 
same directory.
Which Rockchip soc are you working on?


Heiko

> On Tuesday 23 August 2016 09:45 PM, Heiko St?bner wrote:
> > Hi Arvind,
> > 
> > Am Samstag, 13. August 2016, 20:56:18 schrieb Arvind Yadav:
> >> -check return of 'of_iomap'.if It's falied to remap then abort.
> >> 
> >> -Unmap a region obtained by remap. iounmap frees the mapping when failed
> >> to allocate the memory.
> >> 
> >> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> >> ---
> >> 
> >>   drivers/clk/rockchip/clk-rockchip.c | 7 ++++++-
> > 
> > I've applied the patch, after rewording both patch subject and message
> > [0].
> > 
> > That driver is deprecated for quite some time, see
> > Documenation/devicetree/bindings/clock/rockchip.txt - so I'm hoping this
> > is
> > more of a random find and you're not actually using it?
> > 
> > 
> > Thanks
> > Heiko
> > 
> > [0]
> > https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/com
> > mit/?id=023a8280b8355a0aebe094299afec8d8b7b264cd

      reply	other threads:[~2016-08-24 14:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1471101978-1881-1-git-send-email-arvind.yadav.cs@gmail.com>
2016-08-23 16:15 ` [v.1] clk:clk-rockchip:-of_iomap failed to remap then abort clock initialization Heiko Stübner
2016-08-24 14:22   ` arvind Yadav
2016-08-24 14:56     ` Heiko Stübner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2854111.gibmD6ORig@diego \
    --to=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).