From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C32AC433DB for ; Wed, 27 Jan 2021 19:38:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 041F464DA0 for ; Wed, 27 Jan 2021 19:38:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 041F464DA0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9+AEeo1sKUUk4ydrEr5M2jjxeF1Xqw5kCP2yRmzpI2w=; b=ehaE58SUipGyhYVS0nMI971ix dCK+UOPJ+8CU7YHzzblI7bnjN48XZ6Ei6IECBIwiAn8RsEiejASkLooXRfoQaVuF4Hn+bnptXYH04 TQtNE/IfDyQhePCXwzqea5hq67y5q/THbJyovfV1g6ErtEW2DcBdk8FbXzbfYuh6d6aDi6LLw4c36 59zEXwNDIw0w865kh7PlelsQvUSPkJwQR/UlZHtJCNfcckX2XlHFRm2nydhaJ6PXSKVuMHxu/xLRq ywYM7angDoVoDtzq9dnbgAiaynPJnzeTJv4boVt0qzyz+fbdudk/VRy4KUVg/6/GPU2JVYMC9QEiU XHdByia1Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4qcj-0002rQ-QD; Wed, 27 Jan 2021 19:37:05 +0000 Received: from mail-pg1-x534.google.com ([2607:f8b0:4864:20::534]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4qcg-0002qK-Sm for linux-arm-kernel@lists.infradead.org; Wed, 27 Jan 2021 19:37:03 +0000 Received: by mail-pg1-x534.google.com with SMTP id j2so620905pgl.0 for ; Wed, 27 Jan 2021 11:37:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Lrgo7ExcxZOc6wDuEAWDaLWJ735zWTiQ6RpyvZWHowE=; b=ZAte76qDU3nNVp9j191EvXLtls45dYfuBYA30x1Is8f3Ws5n9bF5mCOTvAwpMxkjcY C6XcIYWQQck07cfCsfdWYgPPhp9Ja0hLOncYd0iryR7JT1luEvfgRE4FDv2NfZJPbUzz YqnEIlxbDrEv9b+WUl5I2+st0lN+LWHo7Pw6sHdiHp1ygmp41t7ydCtZ1m+Z9Yp1pt9t ywu6ymO9xKppkTEsMpVe9VBPAXo5zYxkCnG0sgKn1tuc5I9TEZIINqz4dw7smaBGkxTW EqXi0hZCBziaaoFKFEWplwKfcT5h+Qh+2wRZBjf7TdUMCkbNkhoUJ2LpVt/D7VLa0ViB N/fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Lrgo7ExcxZOc6wDuEAWDaLWJ735zWTiQ6RpyvZWHowE=; b=P4ybrWyyfBXkJNMIyute6xtwWZJfKiHmxcwT/6qci5cLpKf8aLeWKaT3yF0NHETDWT pMP+hgdc2/spdozZ+yEwDuhQPahdeWOlzEkcYxurRhoHzZs6OaT+yknab2mIPOIHxCmN cVhUd6VEzDP+76KzJvSnTZoSKGKev55ZyU+hTmiwUcHYmfdH2KsSXhKTxs6UIKdWP6nA ibOx3rb5ZmuUrjxuWSkNgAeeb/8c/x/j/dsKi7ncWB6ZGeXrtwdtOBy7TijSwYJP0SWI 5tVhxB53iUnSTxg5LJY/9nxBOCLOg24Mh/VyN9t77SYeOZtQ0IGAVj+kQQwOU8a6N205 qpKw== X-Gm-Message-State: AOAM533gvyj922+3Chp4cNLGv4rCLuanz7G+psCldTmalQmW0+pQ+9ZT Cq/xCSbAgvGt/CNW4XR/g5Oxf/4ag4U= X-Google-Smtp-Source: ABdhPJxUwRLChY+8LiSGb7sRv98f5AL/zks0hzlPO6MsZlqFz+QJb/0HO3lNWw4YYxmed+DRXYG6tg== X-Received: by 2002:a65:6881:: with SMTP id e1mr13045178pgt.290.1611776218876; Wed, 27 Jan 2021 11:36:58 -0800 (PST) Received: from [10.230.29.30] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id gg22sm2853963pjb.24.2021.01.27.11.36.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Jan 2021 11:36:58 -0800 (PST) Subject: Re: [PATCH v7 2/2] ARM: ftrace: Add MODULE_PLTS support To: Alexander A Sverdlin , Steven Rostedt , Ingo Molnar , Russell King , linux-arm-kernel@lists.infradead.org References: <20210127110944.41813-1-alexander.sverdlin@nokia.com> <20210127110944.41813-3-alexander.sverdlin@nokia.com> From: Florian Fainelli Message-ID: <2855919e-2bc4-ff26-8f1b-c2a96aec9018@gmail.com> Date: Wed, 27 Jan 2021 11:36:56 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210127110944.41813-3-alexander.sverdlin@nokia.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210127_143702_949119_1F3D191F X-CRM114-Status: GOOD ( 12.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, Ard Biesheuvel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/27/2021 3:09 AM, Alexander A Sverdlin wrote: > From: Alexander Sverdlin > > Teach ftrace_make_call() and ftrace_make_nop() about PLTs. > Teach PLT code about FTRACE and all its callbacks. > Otherwise the following might happen: > > ------------[ cut here ]------------ > WARNING: CPU: 14 PID: 2265 at .../arch/arm/kernel/insn.c:14 __arm_gen_branch+0x83/0x8c() > ... > Hardware name: LSI Axxia AXM55XX > [] (unwind_backtrace) from [] (show_stack+0x11/0x14) > [] (show_stack) from [] (dump_stack+0x81/0xa8) > [] (dump_stack) from [] (warn_slowpath_common+0x69/0x90) > [] (warn_slowpath_common) from [] (warn_slowpath_null+0x17/0x1c) > [] (warn_slowpath_null) from [] (__arm_gen_branch+0x83/0x8c) > [] (__arm_gen_branch) from [] (ftrace_make_nop+0xf/0x24) > [] (ftrace_make_nop) from [] (ftrace_process_locs+0x27b/0x3e8) > [] (ftrace_process_locs) from [] (load_module+0x11e9/0x1a44) > [] (load_module) from [] (SyS_finit_module+0x59/0x84) > [] (SyS_finit_module) from [] (ret_fast_syscall+0x1/0x18) > ---[ end trace e1b64ced7a89adcc ]--- > ------------[ cut here ]------------ > WARNING: CPU: 14 PID: 2265 at .../kernel/trace/ftrace.c:1979 ftrace_bug+0x1b1/0x234() > ... > Hardware name: LSI Axxia AXM55XX > [] (unwind_backtrace) from [] (show_stack+0x11/0x14) > [] (show_stack) from [] (dump_stack+0x81/0xa8) > [] (dump_stack) from [] (warn_slowpath_common+0x69/0x90) > [] (warn_slowpath_common) from [] (warn_slowpath_null+0x17/0x1c) > [] (warn_slowpath_null) from [] (ftrace_bug+0x1b1/0x234) > [] (ftrace_bug) from [] (ftrace_process_locs+0x285/0x3e8) > [] (ftrace_process_locs) from [] (load_module+0x11e9/0x1a44) > [] (load_module) from [] (SyS_finit_module+0x59/0x84) > [] (SyS_finit_module) from [] (ret_fast_syscall+0x1/0x18) > ---[ end trace e1b64ced7a89adcd ]--- > ftrace failed to modify [] 0xe9ef7006 > actual: 02:f0:3b:fa > ftrace record flags: 0 > (0) expected tramp: c0314265 > > Signed-off-by: Alexander Sverdlin Tested-by: Florian Fainelli -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel