Re: [GIT PULL] Rockchip dts64 changes for 6.16 #1

["Heiko Stübner" <heiko@sntech.de>]

Hi Arnd,

Am Freitag, 9. Mai 2025, 23:03:54 Mitteleuropäische Sommerzeit schrieb Arnd Bergmann:
> On Thu, May 8, 2025, at 00:04, Heiko Stuebner wrote:
> > Hi soc maintainers,
> >
> > please find below and in a subsequent pull-requests
> > Rockchip changes for for 6.16 .
> >
> > Even some arm32 boards got some love (in the next PR)
> 
> One small issue stuck out here:
> 
> 
> > Yao Zi (2):
> >       arm64: dts: rockchip: Add I2C controllers for RK3528
> 
> This creates a lot of new aliases in the dtsi file:
> 
> index 826f9be0be19..2c9780069af9 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3528.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3528.dtsi
> @@ -24,6 +24,14 @@ aliases {
>                 gpio2 = &gpio2;
>                 gpio3 = &gpio3;
>                 gpio4 = &gpio4;
> +               i2c0 = &i2c0;
> +               i2c1 = &i2c1;
> +               i2c2 = &i2c2;
> +               i2c3 = &i2c3;
> +               i2c4 = &i2c4;
> +               i2c5 = &i2c5;
> +               i2c6 = &i2c6;
> +               i2c7 = &i2c7;
>                 serial0 = &uart0;
>                 serial1 = &uart1;
> 
> but the corresponding nodes are left at disabled. I see
> that the same mistake is present in the uart nodes.
> 
> Please send a fixup to remove these from the .dtsi file
> here and the similar chips, unless you are sure that every
> board will have them enabled (like e.g. the gpio nodes).
> 
> The aliases are not meant to refer to soc-internal names,
> but the identifiers on board.

For the uarts and i2c (and spi), all the identifiers are always numerical
both in the SoC documentation as well as on the boards and board
schematics.

If you look in a random Rockchip schematic file, the lines for the i2c0
controller will be called i2c0_scl_foo, i2c0_sda_foo, etc.
Similar uart0_tx, uart0_rx, etc.

So while I fully understand that mmc0 -> emmc, mmc1 -> sd-card are very
much board specific, somehow repeating the very same i2c aliases for every
board feels strange. The 7th i2c controller on the soc, will never be
called anything else than i2c7 afterall.


But ok, if you feel strongly about that, I'll move the i2c and uart aliases.


Heiko