From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B9FDC0015E for ; Tue, 1 Aug 2023 09:54:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/C5DEoTaCZoNFFJ+cxy9JkU6aw+DYJ9xIR4yj64XTGg=; b=lFxP161nyxZU/fOj1f2Tvjtc4G YhrZfg5H5iaaj2sv2D0FCQhTdoBd00+VphYI8MTlMsIdzBGo8WlUBKLedc5ZN3qmk4E/hsOiIvOkZ ezDfduWu05z5I6tSoMHyGfxuDGl+eZyP2B6iJMRw/qxyESL3DVcOLEUdLddu9/uHcKGrF+Q6CDIv1 87IOCDD4sfmSyvAzCWUqhEBfwmZPGcWXVLuWFcpYq4//seJpQm16j9gtQ8Q44b0DOLBW7TH3MBaB3 9HbYRRqjWPztavKy0381PPHD/+n3oeKTzhnGz7MZNCSW7fesWquwcYNQE7zp7ypCIJFCFM29vfGa2 V8X80jlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qQm4w-001gQy-0b; Tue, 01 Aug 2023 09:54:10 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qQm4u-001gPf-28 for linux-arm-kernel@bombadil.infradead.org; Tue, 01 Aug 2023 09:54:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:References:Cc:To:Subject:Reply-To:From:MIME-Version:Date: Message-ID:Sender:Content-ID:Content-Description; bh=B8htkPfQN7tDCTKzLvcKLdUtnIHD1CgSdgnE1gTJ9+A=; b=f3TLhv9FF65G4Nw1R3LQLuBiy+ /zkLjlFa7kvVetKWee5JOP534QgTnzf4IkhS94wB7X/0+6G4Uk3Iswl1Zm5IK0SB1s1lIevgCawP+ STXqjE918VKwx7P+DnBWchykRXa/06YA+n/hrqF4Y8ZIshzP8puSIXvit5Q3H2TKeH66xHiIUOS5t h/MKRYOKsrQv3TfM7lopa3k6rPnVgD62dIfWN5emxQXRTM6TBO2aeZHPVZeI6K9FWaUb95sOEEf+/ KmSEKeT4CC9lH1np9m+2y/dupoeWTVYnig/YuV/HmTfoeUsQP53h0SnDfn++5kWPT2N784nh5XCYn Y7QgYTEw==; Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qQltr-00E6lP-1g for linux-arm-kernel@lists.infradead.org; Tue, 01 Aug 2023 09:42:45 +0000 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-3174aac120aso4992793f8f.2 for ; Tue, 01 Aug 2023 02:42:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690882961; x=1691487761; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=B8htkPfQN7tDCTKzLvcKLdUtnIHD1CgSdgnE1gTJ9+A=; b=GOFohhf7EJlA6jrKUeTDGHDzyuW7gl2OJAwUqkqYQeM8p3uwkHQtamtSxytNvLo5ie 3dtsNnrjYJpsfkpJJ3X1biDoOBEzJcRxLsCW3xw1089uR4gJrvQZe4T+JjzKKMMQtMJT c1h73M90WwJEXC/cA3GhxA3kyLlJUN38rJXBI/w+FzoZe65JH8TmyaxaHOfnQ0jUpfUJ IkMrcpxgXqGjFWzSJeGpYq2xNRJLIEK3UdOl2Wp6Wlr9O3KW+Y4m/hSPiBPdDt+0h2bV 3TVSwqECd9JWHfOF8rJWy5jPGvCR3q8tLWBOB2P5MPPEau0rGh9eXch5VRRAKwpW8pHW TL6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690882961; x=1691487761; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=B8htkPfQN7tDCTKzLvcKLdUtnIHD1CgSdgnE1gTJ9+A=; b=CK6W0TQ2ySfOAw5q4ZE/UNX3hBl9GbsWWvYHKfewqyCFBtEC1UsGmnFyVKZ3Tlg1gU F9p2FIHPIuuLvpgo9R5hDmzFem8xf5f2DtFvI0XLBEVagSSFWFqfQbsHO5NyYCxiPb0X 8YkFk63cTLeqSEj/oKWKSI1OazJeUquPPTRlspHduVvBYAEb6HlqXHhbBpzdANzpUcFW D/uIy1b6yu8yEwE86zdsn/f4lPLY/ZXR3ziKadwE7j4TCcylGTmL1VgC+XYYYlZyR2qn 5ezTEPmrLSf+N40cAhky1NFRvDpdWNXEJURRgrgK2rvVwLGyfJn0DZsAb32yePZ+zx2k gZpQ== X-Gm-Message-State: ABy/qLYF+ZyYBSnLus9uGfCy1CZwoh74Fo1h1Nn41lhbp4xAl9SzFWUU Msz9rti2W9iFm2wPlBACiHEN4Q== X-Google-Smtp-Source: APBJJlH8+vyOv7Y4rRY+pMDO1yXUEHYynaydqbSPnfpp1Dyw3Ic6Q3e5j6BfodNBBIcBgpdzjPUK5Q== X-Received: by 2002:adf:f206:0:b0:313:e9f6:3378 with SMTP id p6-20020adff206000000b00313e9f63378mr1858599wro.4.1690882960821; Tue, 01 Aug 2023 02:42:40 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:b92a:81a9:df6e:1e3? ([2a01:e0a:982:cbb0:b92a:81a9:df6e:1e3]) by smtp.gmail.com with ESMTPSA id r5-20020a056000014500b0031751d7d8a6sm15609359wrx.18.2023.08.01.02.42.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Aug 2023 02:42:40 -0700 (PDT) Message-ID: <285db5bc-f901-e09f-7f86-6638d260c283@linaro.org> Date: Tue, 1 Aug 2023 11:42:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 From: neil.armstrong@linaro.org Subject: Re: [PATCH 5/9] drm/bridge: synopsys: dw-mipi-dsi: Use pixel clock rate to calculate lbcc Content-Language: en-US To: Liu Ying , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: andrzej.hajda@intel.com, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@gmail.com, daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com References: <20230717061831.1826878-1-victor.liu@nxp.com> <20230717061831.1826878-6-victor.liu@nxp.com> Organization: Linaro Developer Services In-Reply-To: <20230717061831.1826878-6-victor.liu@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230801_104243_707503_7384EF0E X-CRM114-Status: GOOD ( 18.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: neil.armstrong@linaro.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17/07/2023 08:18, Liu Ying wrote: > To get better accuration, use pixel clock rate to calculate lbcc instead of > lane_mbps since the pixel clock rate is in KHz while lane_mbps is in MHz. > Without this, distorted image can be seen on a HDMI monitor connected with > i.MX93 11x11 EVK through ADV7535 DSI to HDMI bridge in 1920x1080p@60 video > mode. > > Signed-off-by: Liu Ying > --- > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > index c754d55f71d1..332388fd86da 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -762,8 +763,15 @@ static u32 dw_mipi_dsi_get_hcomponent_lbcc(struct dw_mipi_dsi *dsi, > u32 hcomponent) > { > u32 frac, lbcc; > + int bpp; > > - lbcc = hcomponent * dsi->lane_mbps * MSEC_PER_SEC / 8; > + bpp = mipi_dsi_pixel_format_to_bpp(dsi->format); > + if (bpp < 0) { > + dev_err(dsi->dev, "failed to get bpp\n"); > + return 0; > + } > + > + lbcc = div_u64((u64)hcomponent * mode->clock * bpp, dsi->lanes * 8); > > frac = lbcc % mode->clock; > lbcc = lbcc / mode->clock; Reviewed-by: Neil Armstrong _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel