From: "Heiko Stübner" <heiko@sntech.de>
To: Fabio Estevam <festevam@gmail.com>, Conor Dooley <conor@kernel.org>
Cc: broonie@kernel.org, linux-spi@vger.kernel.org,
otavio.salvador@ossystems.com.br, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/3] dt-bindings: trivial-devices: Document elgin,jg10309-01
Date: Fri, 26 Jul 2024 23:57:49 +0200 [thread overview]
Message-ID: <28702815.czjnFlTdjD@diego> (raw)
In-Reply-To: <20240719-unquote-query-a76fd9487bf9@spud>
Am Freitag, 19. Juli 2024, 16:45:24 CEST schrieb Conor Dooley:
> On Fri, Jul 19, 2024 at 08:12:08AM -0300, Fabio Estevam wrote:
> > The rv1108-elgin-r1 board has an LCD controlled via SPI in userspace.
> > The marking on the LCD is JG10309-01.
> >
> > Add an entry for the "elgin,jg10309-01" compatible string.
> >
> > Signed-off-by: Fabio Estevam <festevam@gmail.com>
>
> Please send cover letter for patch series. The whole lot seems fine,
> although ideally this wouldn't be in trivial devices - but I think the
> series is an improvement on lying about what's on the board ;)
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
with the error Rob's bot reported about the usage of spi-cpol and
spi-cpha, it really looks like the bindings needs to be more fleshed out.
next prev parent reply other threads:[~2024-07-26 21:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-19 11:12 [PATCH v2 1/3] dt-bindings: trivial-devices: Document elgin,jg10309-01 Fabio Estevam
2024-07-19 11:12 ` [PATCH v2 2/3] spi: spidev: Add an entry for elgin,jg10309-01 Fabio Estevam
2024-08-10 21:22 ` Heiko Stübner
2024-07-19 11:12 ` [PATCH v2 3/3] ARM: dts: rockchip: rv1108-elgin-r1: Do not describe unexisting DAC device Fabio Estevam
2024-08-10 21:23 ` Heiko Stübner
2024-08-29 17:31 ` Fabio Estevam
2024-08-29 17:40 ` Heiko Stübner
2024-07-19 14:45 ` [PATCH v2 1/3] dt-bindings: trivial-devices: Document elgin,jg10309-01 Conor Dooley
2024-07-26 21:57 ` Heiko Stübner [this message]
2024-08-05 13:18 ` Fabio Estevam
2024-08-05 22:05 ` Conor Dooley
2024-07-23 2:57 ` Rob Herring (Arm)
2024-08-10 21:22 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28702815.czjnFlTdjD@diego \
--to=heiko@sntech.de \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=otavio.salvador@ossystems.com.br \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).