From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65B7BC3DA49 for ; Fri, 26 Jul 2024 21:58:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XdeWz3+cPURG7IxQ1n4Bos5t2zWMZ1Hsv9VEufcfAqY=; b=bA0a9HqyHATcbSw1zUm+KNzNFD siDMrfIzKJdRgp3bl9LfQaGtc4awgrgmoZWUV/HAwSCcFjNFX5QDeFojjANU3NDcnVggrXm7+u8ps DRZefZckp/NX+xZQaJIDScPB1VPd0bW4IcthV7laW2DvzDloB45JD82kPYT6ZeFGbbsslbZImZtzh 5sUet2MZy3bjByrHGBychRbzU5hpT36PjFK7ibRXmrKmDjYv54vPiO8Ejz8EBoWSBGc/MG02BYIL+ UgAcu0Q/4Ld+t4qlkvKGqo/6K9HTdqBIY0ZMiDJ4y5EI6okMtHI7ATIj/pdYfZ9NU4CQO6fdx2W6r yZK90JLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sXSxG-000000057y6-1DJi; Fri, 26 Jul 2024 21:58:26 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sXSwm-000000057jL-00Cr for linux-arm-kernel@lists.infradead.org; Fri, 26 Jul 2024 21:57:58 +0000 Received: from i5e860cde.versanet.de ([94.134.12.222] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sXSwg-0006AP-9o; Fri, 26 Jul 2024 23:57:50 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Fabio Estevam , Conor Dooley Cc: broonie@kernel.org, linux-spi@vger.kernel.org, otavio.salvador@ossystems.com.br, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 1/3] dt-bindings: trivial-devices: Document elgin,jg10309-01 Date: Fri, 26 Jul 2024 23:57:49 +0200 Message-ID: <28702815.czjnFlTdjD@diego> In-Reply-To: <20240719-unquote-query-a76fd9487bf9@spud> References: <20240719111210.1287783-1-festevam@gmail.com> <20240719-unquote-query-a76fd9487bf9@spud> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240726_145756_102655_D251E596 X-CRM114-Status: GOOD ( 15.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Freitag, 19. Juli 2024, 16:45:24 CEST schrieb Conor Dooley: > On Fri, Jul 19, 2024 at 08:12:08AM -0300, Fabio Estevam wrote: > > The rv1108-elgin-r1 board has an LCD controlled via SPI in userspace. > > The marking on the LCD is JG10309-01. > > > > Add an entry for the "elgin,jg10309-01" compatible string. > > > > Signed-off-by: Fabio Estevam > > Please send cover letter for patch series. The whole lot seems fine, > although ideally this wouldn't be in trivial devices - but I think the > series is an improvement on lying about what's on the board ;) > Acked-by: Conor Dooley with the error Rob's bot reported about the usage of spi-cpol and spi-cpha, it really looks like the bindings needs to be more fleshed out.