[PATCH v2 1/3] dt-bindings: trivial-devices: Document elgin,jg10309-01

[PATCH v2 1/3] dt-bindings: trivial-devices: Document elgin,jg10309-01

[Fabio Estevam]

The rv1108-elgin-r1 board has an LCD controlled via SPI in userspace.
The marking on the LCD is JG10309-01.

Add an entry for the "elgin,jg10309-01" compatible string.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Changes since v1:
- Use a more specific compatible string. (Conor)

 Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 7913ca9b6b54..49dee2a1f6b4 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -110,6 +110,8 @@ properties:
           - domintech,dmard09
             # DMARD10: 3-axis Accelerometer
           - domintech,dmard10
+            # Elgin SPI-controlled LCD
+          - elgin,jg10309-01
             # MMA7660FC: 3-Axis Orientation/Motion Detection Sensor
           - fsl,mma7660
             # MMA8450Q: Xtrinsic Low-power, 3-axis Xtrinsic Accelerometer
-- 
2.34.1

[PATCH v2 2/3] spi: spidev: Add an entry for elgin,jg10309-01

[Fabio Estevam]

The rv1108-elgin-r1 board has an LCD controlled via SPI in userspace.
The marking on the LCD is JG10309-01.

Add the "elgin,jg10309-01" compatible string.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Changes since v1:
- Use a more specific compatible string. (Conor)

 drivers/spi/spidev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c
index 05e6d007f9a7..316ed3664cb2 100644
--- a/drivers/spi/spidev.c
+++ b/drivers/spi/spidev.c
@@ -730,6 +730,7 @@ static int spidev_of_check(struct device *dev)
 static const struct of_device_id spidev_dt_ids[] = {
 	{ .compatible = "cisco,spi-petra", .data = &spidev_of_check },
 	{ .compatible = "dh,dhcom-board", .data = &spidev_of_check },
+	{ .compatible = "elgin,jg10309-01", .data = &spidev_of_check },
 	{ .compatible = "lineartechnology,ltc2488", .data = &spidev_of_check },
 	{ .compatible = "lwn,bk4", .data = &spidev_of_check },
 	{ .compatible = "menlo,m53cpld", .data = &spidev_of_check },
-- 
2.34.1

Re: [PATCH v2 2/3] spi: spidev: Add an entry for elgin,jg10309-01

[Heiko Stübner]

Am Freitag, 19. Juli 2024, 13:12:09 CEST schrieb Fabio Estevam:
> The rv1108-elgin-r1 board has an LCD controlled via SPI in userspace.
> The marking on the LCD is JG10309-01.
> 
> Add the "elgin,jg10309-01" compatible string.
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

> ---
> Changes since v1:
> - Use a more specific compatible string. (Conor)
> 
>  drivers/spi/spidev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c
> index 05e6d007f9a7..316ed3664cb2 100644
> --- a/drivers/spi/spidev.c
> +++ b/drivers/spi/spidev.c
> @@ -730,6 +730,7 @@ static int spidev_of_check(struct device *dev)
>  static const struct of_device_id spidev_dt_ids[] = {
>  	{ .compatible = "cisco,spi-petra", .data = &spidev_of_check },
>  	{ .compatible = "dh,dhcom-board", .data = &spidev_of_check },
> +	{ .compatible = "elgin,jg10309-01", .data = &spidev_of_check },
>  	{ .compatible = "lineartechnology,ltc2488", .data = &spidev_of_check },
>  	{ .compatible = "lwn,bk4", .data = &spidev_of_check },
>  	{ .compatible = "menlo,m53cpld", .data = &spidev_of_check },
> 

[PATCH v2 3/3] ARM: dts: rockchip: rv1108-elgin-r1: Do not describe unexisting DAC device

[Fabio Estevam]

There is no DAC connected to the SPI bus of the Elgin RV1108 R1 board.

There is a JG10309-01 LCD controlled via SPI though.

Properly describe it by adding the "elgin,jg10309-01" compatible
string.

Reported-by: Conor Dooley <conor.dooley@microchip.com>
Closes: https://lore.kernel.org/linux-arm-kernel/20240717-parrot-malt-83cc04bf6b36@spud/
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Changes since v1:
- Use a more specific compatible string. (Conor)

 arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts b/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts
index 2d9994379eb2..971bb617e845 100644
--- a/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts
+++ b/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts
@@ -168,8 +168,8 @@ &spi {
 	pinctrl-0 = <&spim1_clk &spim1_cs0 &spim1_tx &spim1_rx>;
 	status = "okay";
 
-	dh2228fv: dac@0 {
-		compatible = "rohm,dh2228fv";
+	display: display@0 {
+		compatible = "elgin,jg10309-01";
 		reg = <0>;
 		spi-max-frequency = <24000000>;
 		spi-cpha;
-- 
2.34.1

Re: [PATCH v2 3/3] ARM: dts: rockchip: rv1108-elgin-r1: Do not describe unexisting DAC device

[Heiko Stübner]

Am Freitag, 19. Juli 2024, 13:12:10 CEST schrieb Fabio Estevam:
> There is no DAC connected to the SPI bus of the Elgin RV1108 R1 board.
> 
> There is a JG10309-01 LCD controlled via SPI though.
> 
> Properly describe it by adding the "elgin,jg10309-01" compatible
> string.
> 
> Reported-by: Conor Dooley <conor.dooley@microchip.com>
> Closes: https://lore.kernel.org/linux-arm-kernel/20240717-parrot-malt-83cc04bf6b36@spud/
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Acked-by: Heiko Stuebner <heiko@sntech.de>

Mark, do you want to take all 3 patches (fine by me) or just the
first two?


Heiko

Re: [PATCH v2 3/3] ARM: dts: rockchip: rv1108-elgin-r1: Do not describe unexisting DAC device

[Fabio Estevam]

Hi Heiko,

On Sat, Aug 10, 2024 at 6:23 PM Heiko Stübner <heiko@sntech.de> wrote:

> Acked-by: Heiko Stuebner <heiko@sntech.de>
>
> Mark, do you want to take all 3 patches (fine by me) or just the
> first two?

Mark has applied the spidev patch on his for-6.11 branch:

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git/commit/?h=for-6.11&id=5f3eee1eef5d0edd23d8ac0974f56283649a1512

Could you please apply the other two to your tree?

Thanks

Re: [PATCH v2 3/3] ARM: dts: rockchip: rv1108-elgin-r1: Do not describe unexisting DAC device

[Heiko Stübner]

Hi Fabio,

Am Donnerstag, 29. August 2024, 19:31:58 CEST schrieb Fabio Estevam:
> On Sat, Aug 10, 2024 at 6:23 PM Heiko Stübner <heiko@sntech.de> wrote:
> 
> > Acked-by: Heiko Stuebner <heiko@sntech.de>
> >
> > Mark, do you want to take all 3 patches (fine by me) or just the
> > first two?
> 
> Mark has applied the spidev patch on his for-6.11 branch:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git/commit/?h=for-6.11&id=5f3eee1eef5d0edd23d8ac0974f56283649a1512
> 
> Could you please apply the other two to your tree?

Actually Mark has applied patches 1+2 from v4 it seems, so I grabbed the
dts patch from there too :-)

Heiko

Re: [PATCH v2 1/3] dt-bindings: trivial-devices: Document elgin,jg10309-01

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 562 bytes --]

On Fri, Jul 19, 2024 at 08:12:08AM -0300, Fabio Estevam wrote:
> The rv1108-elgin-r1 board has an LCD controlled via SPI in userspace.
> The marking on the LCD is JG10309-01.
> 
> Add an entry for the "elgin,jg10309-01" compatible string.
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Please send cover letter for patch series. The whole lot seems fine,
although ideally this wouldn't be in trivial devices - but I think the
series is an improvement on lying about what's on the board ;)
Acked-by: Conor Dooley <conor.dooley@microchip.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2 1/3] dt-bindings: trivial-devices: Document elgin,jg10309-01

[Heiko Stübner]

Am Freitag, 19. Juli 2024, 16:45:24 CEST schrieb Conor Dooley:
> On Fri, Jul 19, 2024 at 08:12:08AM -0300, Fabio Estevam wrote:
> > The rv1108-elgin-r1 board has an LCD controlled via SPI in userspace.
> > The marking on the LCD is JG10309-01.
> > 
> > Add an entry for the "elgin,jg10309-01" compatible string.
> > 
> > Signed-off-by: Fabio Estevam <festevam@gmail.com>
> 
> Please send cover letter for patch series. The whole lot seems fine,
> although ideally this wouldn't be in trivial devices - but I think the
> series is an improvement on lying about what's on the board ;)
> Acked-by: Conor Dooley <conor.dooley@microchip.com>

with the error Rob's bot reported about the usage of spi-cpol and
spi-cpha, it really looks like the bindings needs to be more fleshed out.

Re: [PATCH v2 1/3] dt-bindings: trivial-devices: Document elgin,jg10309-01

[Fabio Estevam]

Hi Heiko,

On Fri, Jul 26, 2024 at 6:57 PM Heiko Stübner <heiko@sntech.de> wrote:

> with the error Rob's bot reported about the usage of spi-cpol and
> spi-cpha, it really looks like the bindings needs to be more fleshed out.

I just wanted to let you know that the warning reported by Rob's bot
is very old.

Running "make dtbs_check DT_SCHEMA_FILES=trivial-devices.yaml" on the
existing tree:

  DTC [C] arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dtb
rv1108-elgin-r1.dtb: dac@0: 'spi-cpha', 'spi-cpol' do not match any of
the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/trivial-devices.yaml#

So we are not making things worse in this aspect.

I can work on removing the warnings as an incremental patch, if you agree.

Regards,

Fabio Estevam

Re: [PATCH v2 1/3] dt-bindings: trivial-devices: Document elgin,jg10309-01

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1018 bytes --]

On Mon, Aug 05, 2024 at 10:18:24AM -0300, Fabio Estevam wrote:
> Hi Heiko,
> 
> On Fri, Jul 26, 2024 at 6:57 PM Heiko Stübner <heiko@sntech.de> wrote:
> 
> > with the error Rob's bot reported about the usage of spi-cpol and
> > spi-cpha, it really looks like the bindings needs to be more fleshed out.
> 
> I just wanted to let you know that the warning reported by Rob's bot
> is very old.
> 
> Running "make dtbs_check DT_SCHEMA_FILES=trivial-devices.yaml" on the
> existing tree:
> 
>   DTC [C] arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dtb
> rv1108-elgin-r1.dtb: dac@0: 'spi-cpha', 'spi-cpol' do not match any of
> the regexes: 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/trivial-devices.yaml#
> 
> So we are not making things worse in this aspect.
> 
> I can work on removing the warnings as an incremental patch, if you agree.

Yeah, I acked it cos the issue would've been there before so it's not
any worse. I think adding a "real" binding can be a follow on.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2 1/3] dt-bindings: trivial-devices: Document elgin,jg10309-01

[Rob Herring (Arm)]

On Fri, 19 Jul 2024 08:12:08 -0300, Fabio Estevam wrote:
> The rv1108-elgin-r1 board has an LCD controlled via SPI in userspace.
> The marking on the LCD is JG10309-01.
> 
> Add an entry for the "elgin,jg10309-01" compatible string.
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> Changes since v1:
> - Use a more specific compatible string. (Conor)
> 
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y rockchip/rv1108-elgin-r1.dtb' for 20240719111210.1287783-1-festevam@gmail.com:

arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dtb: display@0: 'spi-cpha', 'spi-cpol' do not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/trivial-devices.yaml#

Re: [PATCH v2 1/3] dt-bindings: trivial-devices: Document elgin,jg10309-01

[Heiko Stübner]

Am Freitag, 19. Juli 2024, 13:12:08 CEST schrieb Fabio Estevam:
> The rv1108-elgin-r1 board has an LCD controlled via SPI in userspace.
> The marking on the LCD is JG10309-01.
> 
> Add an entry for the "elgin,jg10309-01" compatible string.
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Acked-by: Heiko Stuebner <heiko@sntech.de>

> ---
> Changes since v1:
> - Use a more specific compatible string. (Conor)
> 
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 7913ca9b6b54..49dee2a1f6b4 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -110,6 +110,8 @@ properties:
>            - domintech,dmard09
>              # DMARD10: 3-axis Accelerometer
>            - domintech,dmard10
> +            # Elgin SPI-controlled LCD
> +          - elgin,jg10309-01
>              # MMA7660FC: 3-Axis Orientation/Motion Detection Sensor
>            - fsl,mma7660
>              # MMA8450Q: Xtrinsic Low-power, 3-axis Xtrinsic Accelerometer
>