From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBE3F606A31A for ; Mon, 26 Oct 2026 10:42:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=pYWwaCy+; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.a=rsa-sha256 header.s=default2602 header.b=MFad3Qp5 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=KvDGt/SRGq4OwemsueeHKMWOsPxmzxj7gt+ZtB5TDoQ=; b=pYWwaCy+qoOMY+4SShxE7T5kZ/ nKv7jRif9njoZMKq8+4Tz5lNUW7MAZHd9NxZZo27f4qRpB7j3a4dvmoV+rJZFKjjOIyPH9kV91Mje DITwue3G/V4romMN3s9ePpyfFybob83YWk1JOGAjoYmtBHnW9tomVNfbEXEwprTUuPV62oKThb0hO eJFS7viysLyTvbNf5whniLvYLRdZDbQAkHKcOR6nsVYzPLIumW/LiLMvy6hQ4v5Itn3kY3dT73xV8 gCdi3PJhaEyvXHtvLLIfKtoftM9df39cqAJhtb9zxV8jnKzW04ZHtbn3ttb20qifsCHyRun5Ay3Vq YVGv23Yw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLI9U-00000002HF6-45B4; Mon, 26 Oct 2026 10:42:04 +0000 Received: from www537.your-server.de ([188.40.3.216]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLI9R-00000002HEN-2r3l for linux-arm-kernel@lists.infradead.org; Mon, 26 Oct 2026 10:42:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ew.tq-group.com; s=default2602; h=Content-Type:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=KvDGt/SRGq4OwemsueeHKMWOsPxmzxj7gt+ZtB5TDoQ=; b=MFad3Qp5Vnc/Y/7ivVaTeBE+8W eSSk8wtCZjsQ3SkjA+9L9KvlNjXIn6WVIuuMW+y+lp5DUXWKIQHfKXeBCjz60Y5jlH9S6zexKEVgp N94EDEGiiu+GdpC4Ljwod3udKQaT+9a0AmYE5dNtuGmmFzqRtgawVfmVEjQs8aU2bA+scoQC/jVm8 /8SzWY7qcDG0KAWNjT7ubW7LKnueD/czINcbYiuqkWnErjt2+q+S2G+55Xp22GyduannGH+QGSdn1 fyvk3bRp4y6uHUa2i5QZytWla2lpU/WsLMA88VufRhZt2cHyPR4O/jXZMeURIPLrfojjqcWUw7lFO 77gqjGaw==; Received: from sslproxy07.your-server.de ([78.47.199.104]) by www537.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1xLI94-000Jam-3A; Mon, 26 Oct 2026 11:41:39 +0100 Received: from localhost ([127.0.0.1]) by sslproxy07.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xLI94-00053P-0p; Mon, 26 Oct 2026 11:41:38 +0100 From: Alexander Stein To: Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Dmitry Baryshkov , linux-arm-kernel@lists.infradead.org Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Marek Vasut , Liu Ying , Frank Li , Liu Ying Subject: Re: [PATCH v7 10/15] drm/imx: dc-ed: Support getting source selection Date: Mon, 26 Oct 2026 11:41:36 +0100 Message-ID: <2873454.mvXUDI8C0e@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20261026-imx8-dc-prefetch-v7-10-a0b50cc4fc65@nxp.com> References: <20261026-imx8-dc-prefetch-v7-0-a0b50cc4fc65@nxp.com> <20261026-imx8-dc-prefetch-v7-10-a0b50cc4fc65@nxp.com> X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Virus-Scanned: Clear (ClamAV 1.4.6/28165/Mon Oct 26 07:27:07 2026) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261026_034201_837772_15429143 X-CRM114-Status: GOOD ( 16.24 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Hi, thanks for the patch and adding me. Am Montag, 26. Oktober 2026, 11:05:15 Mitteleurop=C3=A4ische Normalzeit sch= rieb Liu Ying: > Add a helper to get ExtDst source selection. This is needed by > disabling CRTC at boot in an upcoming commit which tries to get > the source selection. >=20 > Reviewed-by: Frank Li > Acked-by: Maxime Ripard > Signed-off-by: Liu Ying > -- > v7: > - Collect Maxime's A-b tag. > - Check regmap_read()'s return valure. (Sashiko AI bot) >=20 > v2: > - Collect Frank's R-b tag. > --- > drivers/gpu/drm/imx/dc/dc-ed.c | 29 +++++++++++++++++++++++++++++ > drivers/gpu/drm/imx/dc/dc-pe.h | 1 + > 2 files changed, 30 insertions(+) >=20 > diff --git a/drivers/gpu/drm/imx/dc/dc-ed.c b/drivers/gpu/drm/imx/dc/dc-e= d.c > index de1b71315eab..67163dca1363 100644 > --- a/drivers/gpu/drm/imx/dc/dc-ed.c > +++ b/drivers/gpu/drm/imx/dc/dc-ed.c > @@ -149,6 +149,35 @@ void dc_ed_pec_src_sel(struct dc_ed *ed, enum dc_lin= k_id src) > } > } > =20 > +int dc_ed_pec_src_sel_get(struct dc_ed *ed, enum dc_link_id *src) > +{ > + u32 val; > + int ret; > + > + ret =3D regmap_read(ed->reg_pec, PIXENGCFG_DYNAMIC, &val); > + if (ret) > + return -EINVAL; Shouldn't you return ret here instead? With that fixed: Reviewed-by: Alexander Stein Best regards Alexander > + > + switch (val) { > + case LINK_ID_NONE: > + case LINK_ID_CONSTFRAME0: > + case LINK_ID_CONSTFRAME4: > + case LINK_ID_CONSTFRAME1: > + case LINK_ID_CONSTFRAME5: > + case LINK_ID_FETCHWARP2: > + case LINK_ID_FETCHLAYER0: > + case LINK_ID_LAYERBLEND0: > + case LINK_ID_LAYERBLEND1: > + case LINK_ID_LAYERBLEND2: > + case LINK_ID_LAYERBLEND3: > + *src =3D val; > + dev_dbg(ed->dev, "get source selection: 0x%02x\n", val); > + return 0; > + default: > + return -EINVAL; > + } > +} > + > void dc_ed_pec_sync_trigger(struct dc_ed *ed) > { > regmap_write(ed->reg_pec, PIXENGCFG_TRIGGER, SYNC_TRIGGER); > diff --git a/drivers/gpu/drm/imx/dc/dc-pe.h b/drivers/gpu/drm/imx/dc/dc-p= e.h > index f5e01a6eb9e9..0b81dc6b251c 100644 > --- a/drivers/gpu/drm/imx/dc/dc-pe.h > +++ b/drivers/gpu/drm/imx/dc/dc-pe.h > @@ -85,6 +85,7 @@ void dc_cf_init(struct dc_cf *cf); > =20 > /* External Destination Unit */ > void dc_ed_pec_src_sel(struct dc_ed *ed, enum dc_link_id src); > +int dc_ed_pec_src_sel_get(struct dc_ed *ed, enum dc_link_id *src); > void dc_ed_pec_sync_trigger(struct dc_ed *ed); > void dc_ed_init(struct dc_ed *ed); > =20 >=20 >=20 =2D-=20 TQ-Systems GmbH | M=C3=BChlstra=C3=9Fe 2, Gut Delling | 82229 Seefeld, Germ= any Amtsgericht M=C3=BCnchen, HRB 105018 Gesch=C3=A4ftsf=C3=BChrer: Detlef Schneider, R=C3=BCdiger Stahl, Stefan Sch= neider http://www.tq-group.com/