From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] serial: xuartps: add __init to earlycon write method
Date: Thu, 07 May 2015 11:27:39 +0200 [thread overview]
Message-ID: <2877098.2SVXFizf2K@wuerfel> (raw)
In-Reply-To: <CAK7LNATxom6m-sP_hx19qVy8waTZ=-ypGSz64pZ0QHRw9=mDjw@mail.gmail.com>
On Thursday 07 May 2015 18:14:43 you wrote:
> 2015-05-07 18:08 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
> > On Thursday 07 May 2015 18:02:39 Masahiro Yamada wrote:
> >> @@ -1075,7 +1075,8 @@ static void cdns_uart_console_putchar(struct uart_port *port, int ch)
> >> writel(ch, port->membase + CDNS_UART_FIFO_OFFSET);
> >> }
> >>
> >> -static void cdns_early_write(struct console *con, const char *s, unsigned n)
> >> +static void __init cdns_early_write(struct console *con, const char *s,
> >> + unsigned n)
> >> {
> >> struct earlycon_device *dev = con->data;
> >>
> >>
> >
> > Why?
> >
>
> I thought this function is used during the early boot stage.
>
> I am seeing drivers/tty/serial/8250/8250_early.c
> for reference.
>
> All the functions in this file are marked as __init.
>
> Perhaps, am I misunderstanding?
>
Makes sense, please explain that in the commit message and send the
patch again.
Arnd
prev parent reply other threads:[~2015-05-07 9:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 9:02 [PATCH] serial: xuartps: add __init to earlycon write method Masahiro Yamada
2015-05-07 9:08 ` Arnd Bergmann
2015-05-07 9:14 ` Masahiro Yamada
2015-05-07 9:27 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2877098.2SVXFizf2K@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox