From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8FE7C433EF for ; Thu, 2 Jun 2022 09:09:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iRqadcJqV226eA5ZSuhgT/UCfwPb2uP053AugBHvQr4=; b=BJ2VF/+nOtJc3N CeovRKVGdFbj0FlCAjpAbXxsFUWIdCmBSNcVnZ16+cOKQjm7bkFz/GISw79fxh4BJg0Xz41WRDhQV 20oYmpEDRUXvxKRkdLzOtGXaH8EisGBYIbuFLL6iZaH5q+gjl0WNoFBa/AA3BrMLyATEGFUYLG/L3 csjYqF/ByNCB53p+nSN06mMbIIWC8EHwiuXLu7ZJ/uQkK4TjEYtF4cc7xVc4Mx1h3V+cqxHLVilJi LMZ65ERmsJdIUulzUPEG3uR5Y6BqS8rtZ8RCTGuF7yQ5qL7zqiaEi5AVU2SNZo3e4/esQ0tCsE6OU rf6wmE2WS0n1duxhYPpA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwgo4-002NNd-KS; Thu, 02 Jun 2022 09:07:52 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwgo0-002NMF-MC; Thu, 02 Jun 2022 09:07:50 +0000 X-UUID: 63d6747bbad34171879ecd1ea63e4a9d-20220602 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.5,REQID:f323286e-3e04-41a9-8319-419ac146659b,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:2a19b09,CLOUDID:b676ac6e-b02c-4af4-b838-5c14aaa063c7,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,QS:0,BEC:nil X-UUID: 63d6747bbad34171879ecd1ea63e4a9d-20220602 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 427262239; Thu, 02 Jun 2022 02:07:43 -0700 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 2 Jun 2022 01:58:09 -0700 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Thu, 2 Jun 2022 16:58:07 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 2 Jun 2022 16:58:07 +0800 Message-ID: <287d88a62fd13cd762b20faa3e9df826632fe1eb.camel@mediatek.com> Subject: Re: [PATCH v1 01/15] dt-binding: remoteproc: mediatek: Support dual-core SCP From: Tinghan Shen To: Krzysztof Kozlowski , Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Lee Jones , Benson Leung , Guenter Roeck , Daisuke Nojiri , Sebastian Reichel , "Dustin L. Howett" , Tzung-Bi Shih , "Gustavo A. R. Silva" , Prashant Malani , Enric Balletbo i Serra , Brian Norris CC: , , , , , , , Date: Thu, 2 Jun 2022 16:58:07 +0800 In-Reply-To: <476baef8-0255-45ed-85f4-2b9d877c4af1@linaro.org> References: <20220601112201.15510-1-tinghan.shen@mediatek.com> <20220601112201.15510-2-tinghan.shen@mediatek.com> <3c837acfbefa5b7e23e1121678b5b878f08e4ef2.camel@mediatek.com> <476baef8-0255-45ed-85f4-2b9d877c4af1@linaro.org> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220602_020748_778570_47CBA22D X-CRM114-Status: GOOD ( 40.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, On Thu, 2022-06-02 at 08:55 +0200, Krzysztof Kozlowski wrote: > On 02/06/2022 07:21, Tinghan Shen wrote: > > Hi Krzysztof, > > > > On Wed, 2022-06-01 at 13:50 +0200, Krzysztof Kozlowski wrote: > > > On 01/06/2022 13:21, Tinghan Shen wrote: > > > > The SCP co-processor is a dual-core RISC-V MCU on MT8195. > > > > > > > > Add a new property to identify each core and helps to find drivers > > > > through device tree API to cooperate with each other, e.g. boot flow and > > > > watchdog timeout flow. > > > > > > > > Add a new compatile for the driver of SCP 2nd core. > > > > > > > > Signed-off-by: Tinghan Shen > > > > --- > > > > .../devicetree/bindings/remoteproc/mtk,scp.yaml | 12 ++++++++++++ > > > > 1 file changed, 12 insertions(+) > > > > > > > > diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > > > > b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > > > > index eec3b9c4c713..b181786d9575 100644 > > > > --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > > > > +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > > > > @@ -20,6 +20,7 @@ properties: > > > > - mediatek,mt8186-scp > > > > - mediatek,mt8192-scp > > > > - mediatek,mt8195-scp > > > > + - mediatek,mt8195-scp-dual > > > > > > > > reg: > > > > description: > > > > @@ -57,6 +58,16 @@ properties: > > > > memory-region: > > > > maxItems: 1 > > > > > > > > + mediatek,scp-core: > > > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > > > + description: > > > > + The property value is a list with 2 items, a core id and a phandle > > > > > > uint32, not phandle. > > > > > > > + to the sibling SCP node. > > > > > > Skip this. First part is obvious from the schema, second part should be > > > described via items. > > > > > > The core id represents the id of the dts node contains > > > > + this property. The valid values of core id are 0 and 1 for dual-core SCP. > > > > + The phandle of sibling SCP node is used to find the register settings, > > > > + trigger core dependent callback, and invoke rproc API. > > > > > > Entire description did not help me to understand what's this. So far it > > > looks like it is not a hardware property but some programming help, so > > > it does not look like properly described in bindings. > > > > > > > + maxItems: 1 > > > > > > In description you said - two items. > > > > > > You need allOf:if:then disallowing this property for other variants. > > > > > > > + > > > > required: > > > > - compatible > > > > - reg > > > > @@ -115,6 +126,7 @@ examples: > > > > reg-names = "sram", "cfg", "l1tcm"; > > > > clocks = <&infracfg CLK_INFRA_SCPSYS>; > > > > clock-names = "main"; > > > > + mediatek,scp-core = <0 &scp_dual>; > > > > > > This looks like phandle, so wrong type. > > > > > > > > cros_ec { > > > > mediatek,rpmsg-name = "cros-ec-rpmsg"; > > > > Thanks for your feedback. > > After looking for a comparable uses case, I find out a different approach. > > > > mediatek,scp-core: > > $ref: "/schemas/types.yaml#/definitions/phandle-array" > > description: > > Enable the dual-core support in scp driver. > > You describe desired functional behavior, not the hardware. What is the > property about? If you just want to indicate this is two-core processor, > then it could be: > mediatek,cores = <2>; /* number of cores */ > > > However it seems you want to achieve here something different and as I > raised last time - it does not look like DT property. > > Or maybe this is for first core and you want to indicate the sibling? > Something like that was mentioned in previous description. This property is mainly added for scp 1st core driver and scp 2nd core driver to find each other via DT API. After reconsidering the use of core id in the scp driver, it is not necessary in the control flow. I'll remove the core id at next version. How about change the description as following, This property enables the dual-core support in scp driver. By providing the phandle of SCP 2nd core node, the 1st SCP node can control the SCP 2nd core as the subdevice of remoteproc framework. Thanks, Tinghan > > > > items: > > - items: > > - description: Assign a core id for current scp node. > > enum: [0, 1] > > - description: > > Phandle of another SCP node. This helps to find > > the scp driver of another core to trigger core > > dependent callback, invoke rproc subdevice API, etc. > > Items should be rather reversed, as [0,1] being the argument to phandle > for a provider (see examples with syscon)... > > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel