From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A5AAC77B7C for ; Thu, 4 May 2023 06:06:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LPvnCaz+jmWXnxZif8sW/0d1GHafSOITDLfjgElNfjo=; b=xif0Erp5HPdfAb Cn58fTlZBkeFBGzPtmnTqpP1wb/M3khoBkuZ8+Jocwbs9OpUVva9fXevUc99lP9PS6mlQMGPTgzEy zpvvwwX3ps60jhG244nNCo1OlM7+KMymFydyqIHMpuLswlurFYGpH1P7E9JnzWDj6c0Rdd+PkmbSv mq6w5Wjy3yrSB7hBSSmOsNGLtoJfJXG7jCJkXJBQ42e+QTVL+5k4zzKLffSTOWSRW/PuoG1xI+lVi l6WdR3dPUzKMTxlZ8I0hUIGTUHV5cmytVjZRZ2GmDAK360KEN8ORtfw9kaFNrEM2DnrYP+5xLfSly zJUDMiIYhi2DESXy7sgg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1puS5a-006hM0-16; Thu, 04 May 2023 06:05:14 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1puS5W-006hLQ-2u for linux-arm-kernel@lists.infradead.org; Thu, 04 May 2023 06:05:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1683180310; x=1714716310; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=jXYGIIMVLZaw4V6Gl4TKwQXLQ0j62SDGef2QqA9aaSA=; b=cwOxzQZ4RsxWDj5jlgQ8EPtH2+12vVAjr1bVPFdRwC9a3lEmRtvaLX7Y p9DZTFFB3Ye8Bjscsbt4wFRDvCKohZ0uu3hSSDvMpDlI8RsSejWPQF3uv rYasNRx6cJrjg7hPfpREg2K69GhlcdkYHEBO+8dXwbAE+vTDqoSUdCD7O zFPdos+6ju0/bNaTdoBWYnOKlnnOtRbtr0EJZbJuPsjFyvMruK7pHF+rj hHPa7jd8fHarRuPwgOdO2K1D8s+thGXWbxuVVCH1McidyBghxB9D2ByLD AtSUKAfRdXL3CCrIM+BoD91Qwwz6VpAI/Ywy6JnToJRJaL8sG22rWbBYq Q==; X-IronPort-AV: E=Sophos;i="5.99,249,1677538800"; d="scan'208";a="30707190" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 04 May 2023 08:05:06 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Thu, 04 May 2023 08:05:06 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Thu, 04 May 2023 08:05:06 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1683180306; x=1714716306; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=jXYGIIMVLZaw4V6Gl4TKwQXLQ0j62SDGef2QqA9aaSA=; b=IzahgQiGn6mOcRJySkjufUw7p7/UD69ezlHCqzOU3jQpOo6zdYTtjkT8 8j24cndCq7DQd+MXvhbz7LlJygEL2XT/m5dUfElShC4rAVem78itxA0CS WsNlzXE7zhSy69EAjqzNv89vsz1VYQMKXBKJZ1i9ILIQpU6eH/JzjZZUr 89a4ckfAxOVUfzrPxJCzZ12zlg2eJs+fGd0vc39mpbT3aX9gn9Q6hQXJP an+pE1XwFj2gOvuuh6IwXTo1/fFJbVrILEDlFJOH8/jxNTBHcF8Zo4xqT GiiDUMeDRdMuJBYs6Xk89vD54OPbVgHpa8PvdedpnrgXe8U7cr9GcGBNN g==; X-IronPort-AV: E=Sophos;i="5.99,249,1677538800"; d="scan'208";a="30707189" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 04 May 2023 08:05:06 +0200 Received: from steina-w.localnet (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 280AA280056; Thu, 4 May 2023 08:05:06 +0200 (CEST) From: Alexander Stein To: Ahmad Fatoum Cc: Srinivas Kandagatla , Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/1] nvmem: imx-ocotp: Fix MAC address reversal for i.MX6/7 derivates Date: Thu, 04 May 2023 08:05:04 +0200 Message-ID: <2882062.e9J7NaK4W3@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <170fc93b-b660-ec7b-7ceb-070651dfb02f@pengutronix.de> References: <20230503141627.2546884-1-alexander.stein@ew.tq-group.com> <170fc93b-b660-ec7b-7ceb-070651dfb02f@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230503_230511_341170_7A3D258D X-CRM114-Status: GOOD ( 23.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Ahmad, Am Mittwoch, 3. Mai 2023, 16:24:13 CEST schrieb Ahmad Fatoum: > Hello Alexander, > = > On 03.05.23 16:16, Alexander Stein wrote: > > Not just i.MX8M, but all i.MX6/7 (and subtypes) need to reverse the > > MAC address read from fuses. Exceptions are i.MX6SLL and i.MX7ULP which > > do not support ethernet at all. > = > Can't we just drop the reverse_mac_address member then and make > reversing the default for mac-address? That's a nice idea. Thanks Regards Alexander > Cheers, > Ahmad > = > > Fixes: d0221a780cbc ("nvmem: imx-ocotp: add support for post processing= ") > > Signed-off-by: Alexander Stein > > --- > > Looking at [1] reading MAC address from fuses in u-boot is the same for > > all i.MX. Only difference is one or two MAC addresses. > > I hit the problem on TQMa6Q (i.MX6Q) and could test this patch. For the > > others I checked which have ethernet on NXP page. > > = > > [1] > > https://elixir.bootlin.com/u-boot/v2023.07-rc1/source/arch/arm/mach-imx= /m > > ac.c> = > > drivers/nvmem/imx-ocotp.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > = > > diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem/imx-ocotp.c > > index ac0edb6398f1..93628cd756ec 100644 > > --- a/drivers/nvmem/imx-ocotp.c > > +++ b/drivers/nvmem/imx-ocotp.c > > @@ -490,6 +490,7 @@ static const struct ocotp_params imx6q_params =3D { > > = > > .bank_address_words =3D 0, > > .set_timing =3D imx_ocotp_set_imx6_timing, > > .ctrl =3D IMX_OCOTP_BM_CTRL_DEFAULT, > > = > > + .reverse_mac_address =3D true, > > = > > }; > > = > > static const struct ocotp_params imx6sl_params =3D { > > = > > @@ -497,6 +498,7 @@ static const struct ocotp_params imx6sl_params =3D { > > = > > .bank_address_words =3D 0, > > .set_timing =3D imx_ocotp_set_imx6_timing, > > .ctrl =3D IMX_OCOTP_BM_CTRL_DEFAULT, > > = > > + .reverse_mac_address =3D true, > > = > > }; > > = > > static const struct ocotp_params imx6sll_params =3D { > > = > > @@ -511,6 +513,7 @@ static const struct ocotp_params imx6sx_params =3D { > > = > > .bank_address_words =3D 0, > > .set_timing =3D imx_ocotp_set_imx6_timing, > > .ctrl =3D IMX_OCOTP_BM_CTRL_DEFAULT, > > = > > + .reverse_mac_address =3D true, > > = > > }; > > = > > static const struct ocotp_params imx6ul_params =3D { > > = > > @@ -518,6 +521,7 @@ static const struct ocotp_params imx6ul_params =3D { > > = > > .bank_address_words =3D 0, > > .set_timing =3D imx_ocotp_set_imx6_timing, > > .ctrl =3D IMX_OCOTP_BM_CTRL_DEFAULT, > > = > > + .reverse_mac_address =3D true, > > = > > }; > > = > > static const struct ocotp_params imx6ull_params =3D { > > = > > @@ -525,6 +529,7 @@ static const struct ocotp_params imx6ull_params =3D= { > > = > > .bank_address_words =3D 0, > > .set_timing =3D imx_ocotp_set_imx6_timing, > > .ctrl =3D IMX_OCOTP_BM_CTRL_DEFAULT, > > = > > + .reverse_mac_address =3D true, > > = > > }; > > = > > static const struct ocotp_params imx7d_params =3D { > > = > > @@ -532,6 +537,7 @@ static const struct ocotp_params imx7d_params =3D { > > = > > .bank_address_words =3D 4, > > .set_timing =3D imx_ocotp_set_imx7_timing, > > .ctrl =3D IMX_OCOTP_BM_CTRL_DEFAULT, > > = > > + .reverse_mac_address =3D true, > > = > > }; > > = > > static const struct ocotp_params imx7ulp_params =3D { -- = TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel